From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9842F1A1E8E for ; Tue, 11 Oct 2016 16:33:24 -0700 (PDT) Received: by mail-wm0-x22e.google.com with SMTP id c78so14992494wme.1 for ; Tue, 11 Oct 2016 16:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=U9uE3lCSqh1uTG6kq8kU12UUne5WXPpDeaXvN1p2pDw=; b=iJU0h68xrPonfdzMyPnNfwYQAx11CCJ3xRxi85gkYz63hDDE+7JiCuRKpM7LjgkAmZ LcaXT1jngBXTCOCOHa5r3Fq7LENI/GbC1yXtPUo8CaLUjeet/xLCTvyj2FolkDdIasCv TpWz7UucMo3+IVP9Mr6blq7Tt9tisuziQqe/A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=U9uE3lCSqh1uTG6kq8kU12UUne5WXPpDeaXvN1p2pDw=; b=HNicJPsP7l34IAwhi2nD/dvMmGTrQmz1qQzaTGNCh6NwEboLrNoez+9h/gW6WwZNx3 g0XtH0zWr6yw77Ra7XIAXgJaL+w3DLdV3EkZWqZIfQojZq7kxiBnEw5lsHkwJbUjNV7s HeeXMIg8BrCrI9kl4bCUc8HFwwTbTb5DOgU4eT5LI7PfE0eeUWEdrmdR8hesHjxmXwoD M3xoDrrSOjQ4mbJi7hzL7STEIpJeHE7ZIQlPaeetctwjaZnnUWK59Ih/ZRMsadkco57i 9/rvmg/LmT1eXAqOYQ6SXi+pgiT2pEHIX2iEWufnwEQXbGoMx0AJ2q1QxGDTiZYQT057 excg== X-Gm-Message-State: AA6/9RlnN3lDZ/wceRHpIDz7LhR2gZPd0WMxgMtT3rg3VnzlaqPYgyugZZAVTu6+N8mgaCRv7DYASqoY89ujyVe7 X-Received: by 10.28.54.140 with SMTP id y12mr72313wmh.87.1476228803072; Tue, 11 Oct 2016 16:33:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.33.167 with HTTP; Tue, 11 Oct 2016 16:33:22 -0700 (PDT) In-Reply-To: References: <1474470147-23156-1-git-send-email-haojian.zhuang@linaro.org> From: Haojian Zhuang Date: Wed, 12 Oct 2016 07:33:22 +0800 Message-ID: To: Ryan Harkin Cc: Ard Biesheuvel , edk2-devel-01 , Leif Lindholm Subject: Re: [PATCH v3 00/10] enhance mmc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 23:33:25 -0000 Content-Type: text/plain; charset=UTF-8 On 12 October 2016 at 01:03, Ryan Harkin wrote: > On 11 October 2016 at 17:28, Ard Biesheuvel wrote: >> On 11 October 2016 at 17:27, Ryan Harkin wrote: >>> On 11 October 2016 at 17:24, Ard Biesheuvel wrote: >>>> Hi Ryan, >>>> >>>> On 11 October 2016 at 17:22, Ryan Harkin wrote: >>>> [...] >>>>> And OpenPlatformPkg was taken from my repo, which only carries one >>>>> patch essential for TC2 booting: >>>>> c22a665 2016-01-29 HACK: Platforms/ARM: TC2: set >>>>> gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride TRUE [Ryan >>>>> Harkin] >>>> >>>> Shouldn't we simply merge that patch? >>> >>> I think Leif said no, back when TC2 broken in mainline. >>> >>> The commit that broke it was 0c9a522f28772049ae37c85b8ae589a98d2d3b81 >>> "ArmPkg/ArmLib: mark all cached mappings as (inner) shareable". IIRC >>> Leif said there is something wrong with the TC2 setup code meaning >>> that we need to set the PCD, even though we shouldn't need to. >>> >>> And I've never had time to work it out, so I've just carried the patch. >> >> Ah right, I remember now. > > And if I'd looked further down my HACK commit, I'd have seen this text > explaining what happened: > > However, the topic was discussed on the mailing list: > > https://www.mail-archive.com/edk2-devel@lists.01.org/msg03974.html > > The correct solution for platforms that wish to revert this behaviour > is to set the following PCD to TRUE: > > gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride > > However, for TC2 should not need to do this. Work continues to > ascertain why TC2 breaks with shareable mappings. Current thinking is > that CCI-400 needs configuring before shareable mappings will work. > > :-) Hi Ryan, Does it mean that you'll give the fix configuration of CCI-400 on TC2 in upstream? Best Regards Haojian