From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x22e.google.com (mail-qt0-x22e.google.com [IPv6:2607:f8b0:400d:c0d::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B0307817B4 for ; Fri, 6 Jan 2017 00:18:38 -0800 (PST) Received: by mail-qt0-x22e.google.com with SMTP id l7so23898933qtd.1 for ; Fri, 06 Jan 2017 00:18:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JkVMIUXKrwegiDyJZ2oChMjHS2+BnsWqC1/Wq7/dQz0=; b=Qmk/M/XtSYuieouYEgVuy0tPB9df7BYA7ONA4cTabBMpHsGLuvDiH+Fcv7N4QfuXgY xWMwFByhY4UE3Z3z30byzRGm0LeX+SiAUblVY/UDSejH4b++8uEJlSFTuCHlz1T9hPkH cD/slxKw1+I8HLdSV1iLg7XGIKdDeWNFRQYdI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JkVMIUXKrwegiDyJZ2oChMjHS2+BnsWqC1/Wq7/dQz0=; b=QnU9M25GxLFRMTVWobFJ7yjVziBjKJjka8s29rqjbhUeNuVk3iV4EYrCNgiasvmthz RC6WJMg4ZXh3cKP0tA1vrGBHTg2zlMplyjQxxJ7Y8WZl+ufAo/QXjVdYPH6fqM4XHvsL EwJQ8gdjh1DPVO6NXRz9sJF540pVtXJT2CMF+xqGT0KW7y5+6tzQnCQ0pnkjNIGh1P3F /jrtj/2lqpgRkYGR4RPKR4CAFqXUtiQuT1X8poW7KgcqJKCsuNRTbxc1ovV9K3q/g2te PZWRaqC77X9+QdpYqK8X0uHJ8/dWGa5emZrPZzGyTM34yXsO8V9g0QfT7PuxOeRjKmTo ahIA== X-Gm-Message-State: AIkVDXJropWicP6h34+B+6ufPkBW3CdiZc6QzFApHTcQIkQYCbXrso1AhhhGVp39cDbtSrzcZWwLci1AvjmMIOOK X-Received: by 10.200.2.76 with SMTP id o12mr75780708qtg.181.1483690717724; Fri, 06 Jan 2017 00:18:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.41.114 with HTTP; Fri, 6 Jan 2017 00:18:37 -0800 (PST) In-Reply-To: <7F1BAD85ADEA444D97065A60D2E97EE5699A5FFA@SHSMSX101.ccr.corp.intel.com> References: <1483685538-11058-1-git-send-email-haojian.zhuang@linaro.org> <1483685538-11058-8-git-send-email-haojian.zhuang@linaro.org> <7F1BAD85ADEA444D97065A60D2E97EE5699A5FFA@SHSMSX101.ccr.corp.intel.com> From: Haojian Zhuang Date: Fri, 6 Jan 2017 16:18:37 +0800 Message-ID: To: "Tian, Feng" Cc: "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" , "edk2-devel@lists.01.org" Subject: Re: [PATCH 7/9] Ufs: fix initialize OCS value to 0x0F X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2017 08:18:38 -0000 Content-Type: text/plain; charset=UTF-8 Sure. Best Regards Haojian On 6 January 2017 at 15:26, Tian, Feng wrote: > Same with previous patches, could you please fix Ufs PEI driver as well? > > Reviewed-by: Feng Tian > > Thanks > Feng > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Haojian Zhuang > Sent: Friday, January 6, 2017 2:52 PM > To: Tian, Feng ; leif.lindholm@linaro.org; ard.biesheuvel@linaro.org; edk2-devel@lists.01.org > Cc: Haojian Zhuang > Subject: [edk2] [PATCH 7/9] Ufs: fix initialize OCS value to 0x0F > > The OCS value should be initiliazed as 0x0F according to UFS spec. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Haojian Zhuang > --- > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c > index 7c01d57..db70fb1 100644 > --- a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c > +++ b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c > @@ -551,6 +551,7 @@ UfsCreateScsiCommandDesc ( > Trd->Int = UFS_INTERRUPT_COMMAND; > Trd->Dd = DataDirection; > Trd->Ct = UFS_STORAGE_COMMAND_TYPE; > + Trd->Ocs = 0x0F; > Trd->UcdBa = (UINT32)RShiftU64 ((UINT64)CmdDescPhyAddr, 7); > Trd->UcdBaU = (UINT32)RShiftU64 ((UINT64)CmdDescPhyAddr, 32); > Trd->RuL = (UINT16)DivU64x32 ((UINT64)ROUNDUP8 (sizeof (UTP_RESPONSE_UPIU)), sizeof (UINT32)); > @@ -719,6 +720,7 @@ UfsCreateNopCommandDesc ( > Trd->Int = UFS_INTERRUPT_COMMAND; > Trd->Dd = 0x00; > Trd->Ct = UFS_STORAGE_COMMAND_TYPE; > + Trd->Ocs = 0x0F; > Trd->UcdBa = (UINT32)RShiftU64 ((UINT64)CmdDescPhyAddr, 7); > Trd->UcdBaU = (UINT32)RShiftU64 ((UINT64)CmdDescPhyAddr, 32); > Trd->RuL = (UINT16)DivU64x32 ((UINT64)ROUNDUP8 (sizeof (UTP_NOP_IN_UPIU)), sizeof (UINT32)); > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel