public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Haojian Zhuang <haojian.zhuang@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v1 0/2] add DwUsb3Dxe driver
Date: Mon, 22 Oct 2018 10:09:38 +0800	[thread overview]
Message-ID: <CAD6h2NS3V-6KjN7=mjV1mOSTcOy3ju9yEb3cmuwjRCD9HqDH4g@mail.gmail.com> (raw)
In-Reply-To: <20181004141541.kcnzzu5juuss7ldv@bivouac.eciton.net>

On Thu, 4 Oct 2018 at 22:15, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> Hi Haojian,
>
> I will start with a few high-level requests:
> - Could you rework this for inclusion in edk2-platforms instead?
>   Silicon/Synopsys I guess?

Sure. I'll rework it into edk2-platforms.

> - Could you submit Usb2 and Usb3 support in a single set for v2?

No problem.

> - Can you convert these to UEFI driver model with
>   NonDiscoverableDeviceRegistrationLib instead of a hard-coded base
>   address?
>

The only problem is related on Usb Device. Could I append a new type
"UsbDevice" into NonDiscoverableDeviceRegistrationLib?

Best Regards
Haojian


      reply	other threads:[~2018-10-22  2:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20 10:31 [PATCH v1 0/2] add DwUsb3Dxe driver Haojian Zhuang
2018-08-20 10:31 ` [PATCH v1 1/2] EmbeddedPkg: add DwUsb protocol Haojian Zhuang
2018-10-04 14:49   ` Leif Lindholm
2018-10-22  2:39     ` Haojian Zhuang
2018-08-20 10:31 ` [PATCH v1 2/2] EmbeddedPkg/Drivers: add DwUsb3Dxe driver Haojian Zhuang
2018-10-04 16:32   ` Leif Lindholm
2018-10-22  2:51     ` Haojian Zhuang
2018-10-04 14:15 ` [PATCH v1 0/2] " Leif Lindholm
2018-10-22  2:09   ` Haojian Zhuang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD6h2NS3V-6KjN7=mjV1mOSTcOy3ju9yEb3cmuwjRCD9HqDH4g@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox