From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=haojian.zhuang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 308C22116325C for ; Sun, 21 Oct 2018 19:09:50 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id d2-v6so43115986wro.7 for ; Sun, 21 Oct 2018 19:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=136OZOZlW832KMm39R1XLQQOqP+cOakwa9mHegG4K4c=; b=Y7h1X+Zf6z9A04gOGrXXLEIs2HRlIHmA5AhilUC2pD1Rc/e8IlhoPfoxcgd+evKY8M iq0oWswPeZ4H4ZNhp82UabuRSjVYeNBq4myLm8XLS3aM2WxAByXoY3e4mKi1/m/4TX7I zbzMPigZMFyc2JrWJQV6xtfrXNOqSfgwmsFqo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=136OZOZlW832KMm39R1XLQQOqP+cOakwa9mHegG4K4c=; b=ejk31iVhw5AFXaVrD9XoiaQVjlqrmzPpmbsEu7PVEXOSKjc40oCABrGgDo7Gb9oR8t YilQV6JOB3kN5n35xwTH11UKDa8xamXYCUp/ddEJsAEcsE2z3FoEuVhdGiQEizYq10Mk QdCh1L0jSB+cNZEJStI9cl1VeDM1BeHC0qy//TOrJIwRpGNG18c0yPkBBMnmfsgs3JGH LVbCEuyDxc5kzhNKBDoqV4x40RIyYptr3u2fNC64Z441zxFf9u+iBKQmLOiN2WunOGYM HRiqulp9NpuAMflvJrhoY1lnyFTzFLJvaCprQvhL2B0EZAOCkHYGryZMbWiaHYM1tZRm 8PQg== X-Gm-Message-State: ABuFfojlXvKxr6AJdTTwAbhXJIwlDItDyCElz1x0HCHQB3Rv16kqpC6T LZWJqZsJ2KlbzM8oZ+Zo7ukNgn2+B7wnHQ/Sj/d1IQ== X-Google-Smtp-Source: ACcGV60tvSWodc0Ob4fjr1h+YbIFQmpxHswGW6A7cwLbYBX2lxNd5H2l5bNjXDoh3fbaz0fENFYe+vKMcup4H6+0c0I= X-Received: by 2002:adf:e645:: with SMTP id b5-v6mr46039562wrn.324.1540174189015; Sun, 21 Oct 2018 19:09:49 -0700 (PDT) MIME-Version: 1.0 References: <1534761085-26972-1-git-send-email-haojian.zhuang@linaro.org> <20181004141541.kcnzzu5juuss7ldv@bivouac.eciton.net> In-Reply-To: <20181004141541.kcnzzu5juuss7ldv@bivouac.eciton.net> From: Haojian Zhuang Date: Mon, 22 Oct 2018 10:09:38 +0800 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Ard Biesheuvel Subject: Re: [PATCH v1 0/2] add DwUsb3Dxe driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 02:09:51 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 4 Oct 2018 at 22:15, Leif Lindholm wrote: > > Hi Haojian, > > I will start with a few high-level requests: > - Could you rework this for inclusion in edk2-platforms instead? > Silicon/Synopsys I guess? Sure. I'll rework it into edk2-platforms. > - Could you submit Usb2 and Usb3 support in a single set for v2? No problem. > - Can you convert these to UEFI driver model with > NonDiscoverableDeviceRegistrationLib instead of a hard-coded base > address? > The only problem is related on Usb Device. Could I append a new type "UsbDevice" into NonDiscoverableDeviceRegistrationLib? Best Regards Haojian