public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Haojian Zhuang <haojian.zhuang@linaro.org>
To: Ryan Harkin <ryan.harkin@linaro.org>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	 Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v4 00/11] enhance MMC
Date: Wed, 9 Nov 2016 08:30:09 +0800	[thread overview]
Message-ID: <CAD6h2NSbB8eODaC67q52_0W1B9hK2kQA64c2TRH+qbHcDjAXzw@mail.gmail.com> (raw)
In-Reply-To: <CAD0U-h+9oWtfmbLsgMOohStxnz6DMVyqhTarTHUkmpgcTH9a+A@mail.gmail.com>

On 9 November 2016 at 01:32, Ryan Harkin <ryan.harkin@linaro.org> wrote:
> Hi Haojian,
>
> I've tested your v4 series.
>
> On 8 November 2016 at 15:21, Haojian Zhuang <haojian.zhuang@linaro.org> wrote:
>> v4:
>>   * Fix PL180 hang in some cases. Since the proper variable length
>>     isn't set for CMD6 & ACMD51.
>>
>> v3:
>>   * Fix PL180 hang because of CMD6 & ACMD51 not supported.
>>
>> v2:
>>   * Fix print error with missing parameter.
>>   * Change CMD51 to ACMD51.
>>   * Add the protection after CMD55 for SD. If there's no
>>     response of CMD55, skip to send ACMD51.
>>
>> v1:
>>   * Wait OCR busy bit free according to eMMC spec.
>>   * Define ECSD structure.
>>   * Add interface to set IO bus width and speed.
>>   * Support to access multiple blocks.
>>
>> Haojian Zhuang (11):
>>   MmcDxe: wait OCR busy bit free
>>   MmcDxe: move ECSD into CardInfo structure
>>   MmcDxe: add SPEC_VERS field in CSD structure
>>   MmcDxe: add interface to change io width and speed
>>   MmcDxe: declare ECSD structure
>>   MmcDxe: set io bus width before reading EXTCSD
>>   MmcDxe: Fix uninitialized mediaid for SD
>>   MmcDxe: set iospeed and bus width in SD stack
>
> After this patch is applied, TC2 no longer boots.
>
> I can see this patch add support for MMC_ACMD51
>
>>   MmcDxe: expand to support multiple blocks
>>   PL180: update for indentifying SD
>>   PL180: set variable length for CMD6 and ACMD51
>
> I can see this patch is fixing the data size for ACMD51. And it is
> only when this patch is applied that it starts to boot again.
>
> So I think they still need to be stacked or squashed differently so
> they are bisect-able, sorry.
>
OK. I'll pack them into one single patch.

Best Regards
Haojian


      reply	other threads:[~2016-11-09  0:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08 15:21 [PATCH v4 00/11] enhance MMC Haojian Zhuang
2016-11-08 15:21 ` [PATCH v4 01/11] MmcDxe: wait OCR busy bit free Haojian Zhuang
2016-11-08 19:27   ` Leif Lindholm
2016-11-08 15:21 ` [PATCH v4 02/11] MmcDxe: move ECSD into CardInfo structure Haojian Zhuang
2016-11-08 20:27   ` Leif Lindholm
2016-11-08 15:21 ` [PATCH v4 03/11] MmcDxe: add SPEC_VERS field in CSD structure Haojian Zhuang
2016-11-08 20:27   ` Leif Lindholm
2016-11-08 15:21 ` [PATCH v4 04/11] MmcDxe: add interface to change io width and speed Haojian Zhuang
2016-11-08 15:21 ` [PATCH v4 05/11] MmcDxe: declare ECSD structure Haojian Zhuang
2016-11-08 20:43   ` Leif Lindholm
2016-11-09  0:34     ` Haojian Zhuang
2016-11-08 15:21 ` [PATCH v4 06/11] MmcDxe: set io bus width before reading EXTCSD Haojian Zhuang
2016-11-08 15:21 ` [PATCH v4 07/11] MmcDxe: Fix uninitialized mediaid for SD Haojian Zhuang
2016-11-08 23:59   ` Leif Lindholm
2016-11-13  6:46     ` Haojian Zhuang
2016-11-08 15:21 ` [PATCH v4 08/11] MmcDxe: set iospeed and bus width in SD stack Haojian Zhuang
2016-11-08 15:21 ` [PATCH v4 09/11] MmcDxe: expand to support multiple blocks Haojian Zhuang
2016-11-09  0:14   ` Leif Lindholm
2016-11-08 15:21 ` [PATCH v4 10/11] PL180: update for indentifying SD Haojian Zhuang
2016-11-08 15:21 ` [PATCH v4 11/11] PL180: set variable length for CMD6 and ACMD51 Haojian Zhuang
2016-11-08 17:32 ` [PATCH v4 00/11] enhance MMC Ryan Harkin
2016-11-09  0:30   ` Haojian Zhuang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAD6h2NSbB8eODaC67q52_0W1B9hK2kQA64c2TRH+qbHcDjAXzw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox