From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x22f.google.com (mail-qt0-x22f.google.com [IPv6:2607:f8b0:400d:c0d::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C9BBB81D57 for ; Tue, 8 Nov 2016 16:30:07 -0800 (PST) Received: by mail-qt0-x22f.google.com with SMTP id w33so117906654qtc.3 for ; Tue, 08 Nov 2016 16:30:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2JkVUcQMZz1R/3kpWLToast3M1U6QIjhdZJ1zFUml6o=; b=kd1IKprTVscZUmvEEHRFAqIhKDVZ9tizG0swu30mp5ZO2cRIjBCj+wbPw5eAsCvHsw 84axde4S3HaCeDnHvj9htS173oBoqP1JWz+zbdPYUlig5Q09PerN03NdrXe9bkjEPdM9 pa2SggYG9jFEj3A9OPNtM2tEScQs9hERUJhE4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2JkVUcQMZz1R/3kpWLToast3M1U6QIjhdZJ1zFUml6o=; b=TDQBl+NSbhzwSpB8w1nXL5xLRFfF11BqNPlD4EpYXk6J6fiC9h2aTMsFai7c2RF/4Z QhKVmOgemQGbeIhqMmGPmQFNOJrtysXTGvuP5AXfuBKDOrU7OdvAtY6fvSNJcky+tJz+ hh8NeybDzahJ+ckiOuHD2rIKIogtSDyAHkqMISJCbb4zvOi0mOAHtyccQw+GS03/qEJk Rpo7j20WsDOZuFESFsK9F63zJn+d/0uC3I4EJitGEYI6OiqzjX1vi5BhVk3hmRxe30RL LgTHxzaXuNh188Ni9HaDhxLWa3BEpzoMC480LfLvN+OkQIbl81G4JYTCocUX61dUhfNf M5DQ== X-Gm-Message-State: ABUngvdtxkP+2KLR7tPpIB/couiUTgff7OipJRSzIarqDBeAdJrcrehTB7xdStFBMYQjiOtHH6CTlzEsc3hBkZHW X-Received: by 10.237.56.40 with SMTP id j37mr16224057qte.134.1478651409824; Tue, 08 Nov 2016 16:30:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.85.165 with HTTP; Tue, 8 Nov 2016 16:30:09 -0800 (PST) In-Reply-To: References: <1478618476-12608-1-git-send-email-haojian.zhuang@linaro.org> From: Haojian Zhuang Date: Wed, 9 Nov 2016 08:30:09 +0800 Message-ID: To: Ryan Harkin Cc: edk2-devel-01 , Leif Lindholm , Ard Biesheuvel Subject: Re: [PATCH v4 00/11] enhance MMC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2016 00:30:08 -0000 Content-Type: text/plain; charset=UTF-8 On 9 November 2016 at 01:32, Ryan Harkin wrote: > Hi Haojian, > > I've tested your v4 series. > > On 8 November 2016 at 15:21, Haojian Zhuang wrote: >> v4: >> * Fix PL180 hang in some cases. Since the proper variable length >> isn't set for CMD6 & ACMD51. >> >> v3: >> * Fix PL180 hang because of CMD6 & ACMD51 not supported. >> >> v2: >> * Fix print error with missing parameter. >> * Change CMD51 to ACMD51. >> * Add the protection after CMD55 for SD. If there's no >> response of CMD55, skip to send ACMD51. >> >> v1: >> * Wait OCR busy bit free according to eMMC spec. >> * Define ECSD structure. >> * Add interface to set IO bus width and speed. >> * Support to access multiple blocks. >> >> Haojian Zhuang (11): >> MmcDxe: wait OCR busy bit free >> MmcDxe: move ECSD into CardInfo structure >> MmcDxe: add SPEC_VERS field in CSD structure >> MmcDxe: add interface to change io width and speed >> MmcDxe: declare ECSD structure >> MmcDxe: set io bus width before reading EXTCSD >> MmcDxe: Fix uninitialized mediaid for SD >> MmcDxe: set iospeed and bus width in SD stack > > After this patch is applied, TC2 no longer boots. > > I can see this patch add support for MMC_ACMD51 > >> MmcDxe: expand to support multiple blocks >> PL180: update for indentifying SD >> PL180: set variable length for CMD6 and ACMD51 > > I can see this patch is fixing the data size for ACMD51. And it is > only when this patch is applied that it starts to boot again. > > So I think they still need to be stacked or squashed differently so > they are bisect-able, sorry. > OK. I'll pack them into one single patch. Best Regards Haojian