From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=haojian.zhuang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C53BD21E0B9E0 for ; Wed, 7 Feb 2018 07:40:12 -0800 (PST) Received: by mail-wr0-x243.google.com with SMTP id h9so1521843wre.12 for ; Wed, 07 Feb 2018 07:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rr3QOh2yOJUAAjPqLs874FYYhD/XM2Wclv+QPXoHdkg=; b=iYUEOj3Aztp+sB4kWsAl5Or9Hba6BuK3CvsCnb5PHBi4U5RZ2jJMzOhDfHO/AcvSvl sQLZQPEY1nUe7djhEayxuH1QwVfHgYsEylnBZE3PSdkoTrkKOW52L0aqFTkb/11tn37x fs8aoDEcNqomcdBXO8ImnG5hHjJI8K9mhqMmk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rr3QOh2yOJUAAjPqLs874FYYhD/XM2Wclv+QPXoHdkg=; b=GeljFJw3GZdECaiLii03hdia3C4PreG9eVYvV8EhBZ+0mWGPZVblJZU1NN/1ceU/bQ gwyg7Y1uEnZXbjvjrmp3eMMAk0x/6aFMu+oDzSA/6OUM6FDphvz/mOazEWuNExLRgzRa wGP6zsHLDjCnxUQeVFPfPVwhPnRw6BDuDVFpIgyl3113Utp1nQ583zfCqzxyRLOo7iPp sfxhvbSn7FDKxc2ywY/7hs+IqgBkGRlMuKFsX/9C9P0taphxSyuLOjiJ4PKgdAyp6/Ma 4CovIaFiptS1ZhkLlZGCfGxmD1iVTuunmf7ao/V+LtuxJ5plBd4n0pVHHXBvTMHjMvRp m6YA== X-Gm-Message-State: APf1xPAV9tbB/FFd8iU54XSaEwF3l3n2+e6A6ViD/gRavy978oOU6qlW VHMImwvAVHtbUbPg5jJz5vPHleYbRiuE8Z86ifrDhQ== X-Google-Smtp-Source: AH8x227hF+5cnr3NVyAUDa3UJ70XW1MdyE7Y7eY3DaRKLQKIgXLSfEEXjKops/HiMe7EJKbCVaURc7bipkiLdERGT0k= X-Received: by 10.223.209.6 with SMTP id a6mr6366993wri.169.1518018355261; Wed, 07 Feb 2018 07:45:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.132.12 with HTTP; Wed, 7 Feb 2018 07:45:54 -0800 (PST) In-Reply-To: <20180206172956.buzy2wyiionbugxt@bivouac.eciton.net> References: <1517819152-20583-1-git-send-email-haojian.zhuang@linaro.org> <20180206172956.buzy2wyiionbugxt@bivouac.eciton.net> From: Haojian Zhuang Date: Wed, 7 Feb 2018 23:45:54 +0800 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Linaro UEFI Mailman List , Ard Biesheuvel Subject: Re: [edk2-platforms][PATCH] Platform/Hisilicon/HiKey960: add skeleton of HiKey960 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 15:40:13 -0000 Content-Type: text/plain; charset="UTF-8" On 7 February 2018 at 01:29, Leif Lindholm wrote: > On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote: >> Add skeleton of HiKey960 platform. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Haojian Zhuang >> --- >> + gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE >> + >> + gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE > > The above Pcds are all obsolete. > Seeing this patch made me go through and clean up EmbeddedPkg and > platform templates. > > Could you generate a new version of this patch that applies and builds > cleanly against the cleanup series I just posted to edk2-devel?: > https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=embeddedpkg-cleanup > and > https://git.linaro.org/people/leif.lindholm/edk2-platforms.git/log/?h=embeddedpkg-cleanup > OK. I'll rebase on it. > (I would be even happier if you could break the common parts of > Hikey/Hikey960 descriptions into a common .dsc, like the d02,3,5 > platforms do with Silicon/Hisilicon/Hisilicon.dsc.inc.) > OK. Best Regards Haojian