From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::344; helo=mail-wm1-x344.google.com; envelope-from=haojian.zhuang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 742C72194D3AE for ; Sun, 21 Oct 2018 19:40:10 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id y11-v6so8613786wma.3 for ; Sun, 21 Oct 2018 19:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tI/weh4WB5hagyH35pdHMaw4b/fCgkuQHfCvIy0o1tI=; b=XKem1f2SWUWIOCMmHtKCllzIfLOQx2ZNqH8SV2T2lgQN6Yb7hWOkIyDCmTqLan1BgF TgMd3mWu7MckvclUg5AUtPfvBmNa1TVDpM8buF+uF3sfHltlyYF+8NFKpCj6AIz9ez6s LVIwyNc8+nVfNYmH2r4cwOqDArBtgOpfy2cOQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tI/weh4WB5hagyH35pdHMaw4b/fCgkuQHfCvIy0o1tI=; b=c529eu1bpRZ3mdI4HzwC2MG4S88EiMnas3CleqPYip38Xk8YiwV5OdBbDgudPQ51g/ EQwrmJjBErTbYlVBVbaSTvbZLnlodsjHMxDDobRZYpmsE4g8/U9ajXXh/Gphabj0UCuc jc9Ba+gX1C39WQkLupcxTvqGvwpTzFdsyEj6UaVD/iUNFDumyXz6jpYC+BJjZbMuJ0X2 DzEDxR3iui2jDWeHBtbwcZzvbwO1Q+OKGTwK9sDIbdTxaTOkGru+x7yOjiyWFvi5JQj5 aY85R2iH6c+q+VvPRiCeKVF9ozE4MzUZ9S/VQ3oCsgeidwW3FgKZy8KVJZmDSH+jr/1t ICFg== X-Gm-Message-State: ABuFfohRb3vH45r/Ss61S+mx36D7Sv7CQssWAdDz9lNhYUYf8ktGT7TH 0PEr1TmMsx5IOTAF4va8NUo1ftT9VGN5IRzfw3ywMA== X-Google-Smtp-Source: ACcGV62Y+paOTiFsjFsSRb5OVnMxLfM1kNZrfrz0XDTOUlVQF5IqadljYHS9HXvuxkcqaiLlCXS8tXJh+/8rcZozkI0= X-Received: by 2002:a1c:771a:: with SMTP id t26-v6mr13277236wmi.126.1540176008404; Sun, 21 Oct 2018 19:40:08 -0700 (PDT) MIME-Version: 1.0 References: <1534761085-26972-1-git-send-email-haojian.zhuang@linaro.org> <1534761085-26972-2-git-send-email-haojian.zhuang@linaro.org> <20181004144904.sdanz2vstp4hwhwk@bivouac.eciton.net> In-Reply-To: <20181004144904.sdanz2vstp4hwhwk@bivouac.eciton.net> From: Haojian Zhuang Date: Mon, 22 Oct 2018 10:39:57 +0800 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Ard Biesheuvel Subject: Re: [PATCH v1 1/2] EmbeddedPkg: add DwUsb protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 02:40:10 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 4 Oct 2018 at 22:49, Leif Lindholm wrote: > > On Mon, Aug 20, 2018 at 06:31:24PM +0800, Haojian Zhuang wrote: > > The protocol defines the callbacks that could be implemented in > > platform driver. DwUsb device driver needs these callbacks to > > implement USB device functionality. > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Haojian Zhuang > > --- > > EmbeddedPkg/Include/Protocol/DwUsb.h | 81 ++++++++++++++++++++ > > 1 file changed, 81 insertions(+) > > > > diff --git a/EmbeddedPkg/Include/Protocol/DwUsb.h b/EmbeddedPkg/Include/Protocol/DwUsb.h > > new file mode 100644 > > index 000000000000..b9fb776f9258 > > --- /dev/null > > +++ b/EmbeddedPkg/Include/Protocol/DwUsb.h > > @@ -0,0 +1,81 @@ > > +/** @file > > + > > + Copyright (c) 2018, Linaro. All rights reserved. > > + > > + This program and the accompanying materials are licensed and made available > > + under the terms and conditions of the BSD License which accompanies this > > + distribution. The full text of the license may be found at > > + http://opensource.org/licenses/bsd-license.php > > + > > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > + > > +**/ > > + > > +#ifndef __DW_USB_H__ > > +#define __DW_USB_H__ > > Can you expand all instances of public interfaces to DESIGNWARE? > OK > > + > > +// > > +// Protocol GUID > > +// > > +#define DW_USB_PROTOCOL_GUID { 0x109fa264, 0x7811, 0x4862, { 0xa9, 0x73, 0x4a, 0xb2, 0xef, 0x2e, 0xe2, 0xff }} > > + > > +// > > +// Protocol interface structure > > +// > > +typedef struct _DW_USB_PROTOCOL DW_USB_PROTOCOL; > > + > > +#define USB_HOST_MODE 0 > > +#define USB_DEVICE_MODE 1 > > +#define USB_CABLE_NOT_ATTACHED 2 > > And add a DESIGNWARE_ prefix to these? > OK > > + > > +#define LANG_LENGTH 8 > > +#define MANU_FACTURER_STRING_LENGTH 32 > > MANUFACTURER. > OK > Why the hardcoded string lengths? > Are they mandated somewhere? > > > +#define PRODUCT_STRING_LENGTH 32 > > +#define SERIAL_STRING_LENGTH 17 > > + > > +typedef > > +EFI_STATUS > > +(EFIAPI *DW_USB_GET_LANG) ( > > + OUT CHAR16 *Lang, > > + OUT UINT8 *Length > > + ); > > + > > +typedef > > +EFI_STATUS > > +(EFIAPI *DW_USB_GET_MANU_FACTURER) ( > > + OUT CHAR16 *ManuFacturer, > > ManuFacturer -> > Manufacturer. > OK > > + OUT UINT8 *Length > > + ); > > + > > +typedef > > +EFI_STATUS > > +(EFIAPI *DW_USB_GET_PRODUCT) ( > > + OUT CHAR16 *Product, > > + OUT UINT8 *Length > > + ); > > + > > +typedef > > +EFI_STATUS > > +(EFIAPI *DW_USB_GET_SERIAL_NO) ( > > SERIAL_NUMBER > > > + OUT CHAR16 *SerialNo, > > SerialNumber. > OK > > + OUT UINT8 *Length > > + ); > > + > > +typedef > > +EFI_STATUS > > +(EFIAPI *DW_USB_PHY_INIT) ( > > + IN UINT8 Mode > > + ); > > + > > +struct _DW_USB_PROTOCOL { > > + DW_USB_GET_LANG GetLang; > > + DW_USB_GET_MANU_FACTURER GetManuFacturer; > > GetManuFacturer -> > GetManufacturer. > OK > > + DW_USB_GET_PRODUCT GetProduct; > > + DW_USB_GET_SERIAL_NO GetSerialNo; > > + DW_USB_PHY_INIT PhyInit; > > +}; > > + > > +extern EFI_GUID gDwUsbProtocolGuid; > > gDesignWareUsbProtocolGuid. > OK Best Regards Haojian