public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Haojian Zhuang <haojian.zhuang@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
	 Linaro UEFI Mailman List <linaro-uefi@lists.linaro.org>,
	Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [issue] Arrow key can't be read on tty terminal in release build
Date: Thu, 8 Feb 2018 00:12:13 +0800	[thread overview]
Message-ID: <CAD6h2NTOGA9b_kVsWpy69VtLcHJbxmcc6xZO=eQcEcTNyJY1jA@mail.gmail.com> (raw)
In-Reply-To: <78656541-A557-41BE-A302-0CB8F9CAAA5B@linaro.org>

On 7 February 2018 at 23:52, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
>> On 7 Feb 2018, at 15:50, Haojian Zhuang <haojian.zhuang@linaro.org> wrote:
>>
>> Hi all,
>>
>> I have an issue on tty terminal. I setup PL011 serial console as the
>> tty terminal on HiKey platform. When it's built in debug mode, arrow
>> key works well. When it's built in release mode, arrow key can't work.
>>
>> For example, DOWN key is gotten in terminal with "~[B" value in debug
>> build. DOWN key is gotten in terminal with "~" value in release build.
>> These values are fetched by GetOneKeyFromSerial().
>>
>> But I can't find any difference on PL011 serial driver between debug
>> and release mode.
>>
>> Do you have any idea on this?
>>
>>
>
> You need to set the FIFO depth to 16 iirc

I think you mean the initialization code in PL011UartInitializePort ().

  HardwareFifoDepth = (PL011_UARTPID2_VER (MmioRead32 (UartBase + UARTPID2)) \
                       > PL011_VER_R1P4) \
                      ? 32 : 16 ;

I tried to hardcode the value with both 32 and 16. The issue still exists.

Best Regards
Haojian


  reply	other threads:[~2018-02-07 16:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 15:50 [issue] Arrow key can't be read on tty terminal in release build Haojian Zhuang
2018-02-07 15:52 ` Ard Biesheuvel
2018-02-07 16:12   ` Haojian Zhuang [this message]
2018-02-07 16:13     ` Ard Biesheuvel
2018-02-07 16:43       ` Haojian Zhuang
2018-02-07 16:52         ` Ard Biesheuvel
2018-02-09 15:52 ` [Linaro-uefi] " Jeremy Linton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD6h2NTOGA9b_kVsWpy69VtLcHJbxmcc6xZO=eQcEcTNyJY1jA@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox