public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Haojian Zhuang <haojian.zhuang@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	 Linaro UEFI Mailman List <linaro-uefi@lists.linaro.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Heyi Guo <heyi.guo@linaro.org>
Subject: Re: [edk2-platforms][PATCH] Platform/Hisilicon/HiKey960: add skeleton of HiKey960
Date: Fri, 9 Feb 2018 00:01:24 +0800	[thread overview]
Message-ID: <CAD6h2NTRJeYpHM2wnFU7BsuL_7sF6zB_aN=JS0SKtCGgQxv2hw@mail.gmail.com> (raw)
In-Reply-To: <20180206172956.buzy2wyiionbugxt@bivouac.eciton.net>

On 7 February 2018 at 01:29, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote:
>> Add skeleton of HiKey960 platform.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
>> ---
>>  Platform/Hisilicon/HiKey960/HiKey960.dsc           | 457 +++++++++++++++++++++
>>  Platform/Hisilicon/HiKey960/HiKey960.fdf           | 343 ++++++++++++++++
>>  .../HiKey960/Library/HiKey960Lib/HiKey960.c        | 144 +++++++
>>  .../HiKey960/Library/HiKey960Lib/HiKey960Helper.S  |  52 +++
>>  .../HiKey960/Library/HiKey960Lib/HiKey960Lib.inf   |  47 +++
>>  .../HiKey960/Library/HiKey960Lib/HiKey960Mem.c     | 167 ++++++++
>>  6 files changed, 1210 insertions(+)
>>  create mode 100644 Platform/Hisilicon/HiKey960/HiKey960.dsc
>>  create mode 100644 Platform/Hisilicon/HiKey960/HiKey960.fdf
>>  create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960.c
>>  create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960Helper.S
>>  create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960Lib.inf
>>  create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960Mem.c
>>
>
> (I would be even happier if you could break the common parts of
> Hikey/Hikey960 descriptions into a common .dsc, like the d02,3,5
> platforms do with Silicon/Hisilicon/Hisilicon.dsc.inc.)
>

Hi Leif,

I met an issue that blocks me. Hisilicon.dsc.inc makes use of dynamic
PCD value on PcdPlatformBootTimeOut.
And this PCD value is expected to store in variable storage device. As you know,
we haven't enabled variable storage device on HiKey yet.

This one makes UEFI hang on HiKey.

Best Regards
Haojian


  parent reply	other threads:[~2018-02-08 15:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05  8:25 [edk2-platforms][PATCH] Platform/Hisilicon/HiKey960: add skeleton of HiKey960 Haojian Zhuang
2018-02-06 17:29 ` Leif Lindholm
2018-02-07 15:45   ` Haojian Zhuang
2018-02-07 16:28     ` Leif Lindholm
2018-02-08 16:01   ` Haojian Zhuang [this message]
2018-02-08 16:02     ` Ard Biesheuvel
2018-02-09  1:54       ` Guo Heyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD6h2NTRJeYpHM2wnFU7BsuL_7sF6zB_aN=JS0SKtCGgQxv2hw@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox