Re: [PATCH v4 05/11] MmcDxe: declare ECSD structure

[Haojian Zhuang <haojian.zhuang@linaro.org>]

On 9 November 2016 at 04:43, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Nov 08, 2016 at 11:21:10PM +0800, Haojian Zhuang wrote:
>> Declare fields in ECSD structure. And drop the original 128 words
>> arrary.
>
> Functionality-wise, I'm happy with this, if it is moved to directly
> after "add SPEC_VERS field in CSD structure".
>
> A few comments inline with regards to improving readability.
>
>>
>> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
>> ---
>>  EmbeddedPkg/Universal/MmcDxe/Mmc.h               | 157 ++++++++++++++++++++++-
>>  EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c |   4 +-
>>  2 files changed, 158 insertions(+), 3 deletions(-)
>>
>> diff --git a/EmbeddedPkg/Universal/MmcDxe/Mmc.h b/EmbeddedPkg/Universal/MmcDxe/Mmc.h
>> index 8f30a9a..d3e9b71 100644
>> --- a/EmbeddedPkg/Universal/MmcDxe/Mmc.h
>> +++ b/EmbeddedPkg/Universal/MmcDxe/Mmc.h
>> @@ -133,13 +133,168 @@ typedef struct {
>>    UINT8   CSD_STRUCTURE:      2; // CSD structure [127:126]
>>  } CSD;
>>
>> +typedef struct {
>> +  UINT8   RESERVED_1[16];                     // Reserved [15:0]
>> +  UINT8   SECURE_REMOVAL_TYPE;                // Secure Removal Type [16:16]
>> +  UINT8   PRODUCT_STATE_AWARENESS_ENABLEMENT; // Product state awareness enablement [17:17]
>> +  UINT8   MAX_PRE_LOADING_DATA_SIZE[4];       // MAX pre loading data size [21:18]
>> +  UINT8   PRE_LOADING_DATA_SIZE[4];           // Pre loading data size [25:22]
>> +  UINT8   FFU_STATUS;                         // FFU Status [26:26]
>> +  UINT8   RESERVED_2[2];                      // Reserved [28:27]
>> +  UINT8   MODE_OPERATION_CODES;               // Mode operation codes [29:29]
>> +  UINT8   MODE_CONFIG;                        // Mode config [30:30]
>> +  UINT8   RESERVED_3;                         // Reserved [31:31]
>> +  UINT8   FLUSH_CACHE;                        // Flushing of the cache [32:32]
>> +  UINT8   CACHE_CTRL;                         // Control to turn the cache ON/OFF [33:33]
>> +  UINT8   POWER_OFF_NOTIFICATION;             // Power Off Notification [34:34]
>> +  UINT8   PACKED_FAILURE_INDEX;               // Packed command failure index [35:35]
>> +  UINT8   PACKED_COMMAND_STATUS;              // Packed command status [36:36]
>> +  UINT8   CONTEXT_CONF[15];                   // Context configuration [51:37]
>> +  UINT8   EXT_PARTITIONS_ATTRIBUTE[2];        // Extended partitions attribute [53:52]
>> +  UINT8   EXCEPTION_EVENTS_STATUS[2];         // Exception events status [55:54]
>> +  UINT8   EXCEPTION_EVENTS_CTRL[2];           // Exception events control [57:56]
>> +  UINT8   DYNCAP_NEEDED;                      // Number of addressed group to be released [58:58]
>> +  UINT8   CLASS_6_CTRL;                       // Class 6 commands control [59:59]
>> +  UINT8   INI_TIMEOUT_EMU;                    // 1st initialization after disabling sector size emulation [60:60]
>> +  UINT8   DATA_SECTOR_SIZE;                   // Sector size [61:61]
>> +  UINT8   USE_NATIVE_SECTOR;                  // Sector size emulation [62:62]
>> +  UINT8   NATIVE_SECTOR_SIZE;                 // Native sector size [63:63]
>> +  UINT8   VENDOR_SPECIFIC_FIELD[64];          // Vendor specific fields [127:64]
>> +  UINT8   RESERVED_4[2];                      // Reserved [129:128]
>> +  UINT8   PROGRAM_CID_CSD_DDR_SUPPORT;        // Program CID/CSD in DDR mode support [130:130]
>> +  UINT8   PERIODIC_WAKEUP;                    // Periodic wake-up [131:131]
>> +  UINT8   TCASE_SUPPORT;                      // Package case temperature is controlled [132:132]
>> +  UINT8   PRODUCTION_STATE_AWARENESS;         // Production state awareness [133:133]
>> +  UINT8   SEC_BAD_BLK_MGMNT;                  // Bad block management mode [134:134]
>> +  UINT8   RESERVED_5;                         // Reserved [135:135]
>> +  UINT8   ENH_START_ADDR[4];                  // Enhanced user data start address [139:136]
>> +  UINT8   ENH_SIZE_MULT[3];                   // Enhanced user data area size [142:140]
>> +  UINT8   GP_SIZE_MULT[12];                   // General purpose partition size [154:143]
>> +  UINT8   PARTITION_SETTING_COMPLETED;        // Partitioning setting [155:155]
>> +  UINT8   PARTITIONS_ATTRIBUTE;               // Partitions attribute [156:156]
>> +  UINT8   MAX_ENH_SIZE_MULT[3];               // Max enhanced area size [159:157]
>> +  UINT8   PARTITIONING_SUPPORT;               // Partitioning [160:160]
>> +  UINT8   HPI_MGMT;                           // HPI management [161:161]
>> +  UINT8   RST_N_FUNCTION;                     // H/W reset function [162:162]
>> +  UINT8   BKOPS_EN;                           // Enable background operations handshake [163:163]
>> +  UINT8   BKOPS_START;                        // Manually start background operations [164:164]
>> +  UINT8   SANITIZE_START;                     // Start sanitize operation [165:165]
>> +  UINT8   WR_REL_PARAM;                       // Write reliability parameter register [166:166]
>> +  UINT8   WR_REL_SET;                         // Write reliability setting register [167:167]
>> +  UINT8   RPMB_SIZE_MULT;                     // RPMB size [168:168]
>> +  UINT8   FW_CONFIG;                          // FW configuration [169:169]
>> +  UINT8   RESERVED_6;                         // Reserved [170:170]
>> +  UINT8   USER_WP;                            // User area write protection register [171:171]
>> +  UINT8   RESERVED_7;                         // Reserved [172:172]
>> +  UINT8   BOOT_WP;                            // Boot area write protection register [173:173]
>> +  UINT8   BOOT_WP_STATUS;                     // Boot write protection register [174:174]
>> +  UINT8   ERASE_GROUP_DEF;                    // High-density erase group definition [175:175]
>> +  UINT8   RESERVED_8;                         // Reserved [176:176]
>> +  UINT8   BOOT_BUS_CONDITIONS;                // Boot bus conditions [177:177]
>> +  UINT8   BOOT_CONFIG_PROT;                   // Boot config protection [178:178]
>> +  UINT8   PARTITION_CONFIG;                   // Partition config [179:179]
>> +  UINT8   RESERVED_9;                         // Reserved [180:180]
>> +  UINT8   ERASED_MEM_CONT;                    // Erased memory content [181:181]
>> +  UINT8   RESERVED_10;                        // Reserved [182:182]
>> +  UINT8   BUS_WIDTH;                          // Bus width mode [183:183]
>> +  UINT8   RESERVED_11;                        // Reserved [184:184]
>> +  UINT8   HS_TIMING;                          // High-speed interface timing [185:185]
>> +  UINT8   RESERVED_12;                        // Reserved [186:186]
>> +  UINT8   POWER_CLASS;                        // Power class [187:187]
>> +  UINT8   RESERVED_13;                        // Reserved [188:188]
>> +  UINT8   CMD_SET_REV;                        // Command set revision [189:189]
>> +  UINT8   RESERVED_14;                        // Reserved [190:190]
>> +  UINT8   CMD_SET;                            // Command set [191:191]
>> +  UINT8   EXT_CSD_REV;                        // Extended CSD revision [192:192]
>> +  UINT8   RESERVED_15;                        // Reserved [193:193]
>> +  UINT8   CSD_STRUCTURE;                      // CSD Structure [194:194]
>> +  UINT8   RESERVED_16;                        // Reserved [195:195]
>> +  UINT8   DEVICE_TYPE;                        // Device type [196:196]
>> +  UINT8   DRIVER_STRENGTH;                    // I/O Driver strength [197:197]
>> +  UINT8   OUT_OF_INTERRUPT_TIME;              // Out-of-interrupt busy timing [198:198]
>> +  UINT8   PARTITION_SWITCH_TIME;              // Partition switching timing [199:199]
>> +  UINT8   PWR_CL_52_195;                      // Power class for 52MHz at 1.95V 1 R [200:200]
>> +  UINT8   PWR_CL_26_195;                      // Power class for 26MHz at 1.95V 1 R [201:201]
>> +  UINT8   PWR_CL_52_360;                      // Power class for 52MHz at 3.6V 1 R [202:202]
>> +  UINT8   PWR_CL_26_360;                      // Power class for 26MHz at 3.6V 1 R [203:203]
>> +  UINT8   RESERVED_17;                        // Reserved [204:204]
>> +  UINT8   MIN_PERF_R_4_26;                    // Minimum read performance for 4bit at 26MHz [205:205]
>> +  UINT8   MIN_PERF_W_4_26;                    // Minimum write performance for 4bit at 26MHz [206:206]
>> +  UINT8   MIN_PERF_R_8_26_4_52;               // Minimum read performance for 8bit at 26MHz, for 4bit at 52MHz [207:207]
>> +  UINT8   MIN_PERF_W_8_26_4_52;               // Minimum write performance for 8bit at 26MHz, for 4bit at 52MHz [208:208]
>> +  UINT8   MIN_PERF_R_8_52;                    // Minimum read performance for 8bit at 52MHz [209:209]
>> +  UINT8   MIN_PERF_W_8_52;                    // Minimum write performance for 8bit at 52MHz [210:210]
>> +  UINT8   RESERVED_18;                        // Reserved [211:211]
>> +  UINT32  SEC_COUNT;                          // Sector count [215:212]
>
> So, this field is the only one we currently look at.
> In the code below, this replaces the field previously identified vi
> EMMC_ECSD_SIZE_OFFSET. Where does this change in name come from?

I found them in JEDEC eMMC spec (JESD84-A44).

>
> Could all SEC_ fields referring to SECTOR rbe renamed SECTOR_, and all
> referring to SECURE be renamed SECURE_?

OK. I'll do the rename.

Best Regards
Haojian