public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm via groups.io" <leif.lindholm=oss.qualcomm.com@groups.io>
To: devel@edk2.groups.io
Cc: Michael Kubacki <mikuback@linux.microsoft.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: [edk2-devel] MOV64 and CLANGPDB
Date: Thu, 13 Feb 2025 22:33:36 +0000	[thread overview]
Message-ID: <CAD=n3R0=3YEkLHOkaZRkSF0agNho_EvC2BRQyB+7i361f+V9yQ@mail.gmail.com> (raw)

I would very much like to have a MOV64 that's universally usable.
That's sort of the point.

However, I'm wondering if the error is in fact triggered by the first
stanza (movz), which doesn't mask its result, and will have 48 sign
extended bits above the ones we care about for the instruction.

Annoyingly I cannot reproduce the build error in my setup, so I can't
verify if that is the problem.

Michael, could you possibly do a test and change
  movz      Reg, (Val) >> 48, lsl #48             ; \
to
  movz      Reg, ((Val) >> 48) & 0xffff, lsl #48             ; \

on line 51 in MdePkg/Include/AArch64/AsmMacroLib.h ?

And then rebuild the MOV64 version of ArmStandaloneMmCoreEntryPoint?

/
    Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#121119): https://edk2.groups.io/g/devel/message/121119
Mute This Topic: https://groups.io/mt/111172486/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2025-02-13 22:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-13 22:33 Leif Lindholm via groups.io [this message]
2025-02-14  1:54 ` [edk2-devel] MOV64 and CLANGPDB Michael Kubacki via groups.io
2025-02-14 10:48   ` Leif Lindholm via groups.io
2025-02-14 14:25     ` Michael Kubacki via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=n3R0=3YEkLHOkaZRkSF0agNho_EvC2BRQyB+7i361f+V9yQ@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox