From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id AFD9DAC0E4B for ; Thu, 26 Jun 2025 09:58:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hO/J2duVsgSPRwgIk4qr9vwOMV/t91fOewhTDHERxII=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=groups1; t=1750931932; v=1; x=1751191131; b=o8Pta8Y0EX6KY+WQGupfYJA98K57UwJnLkcNPJhZ4alVs5xJYtjJN3BKUbBmuG3Ei+1nmBDw KTSgmAvUjxTgQjYD9X7pb0EAs60SSyI9NVwFcVITHBiVIiv6w21POrvPmsViLh4eJiHJgoO0+WV 2vnNWFv5kJzO7O072UZoQEjNSr9Dif5CwhHstUzgh6MthEjuUx3zgLqbq26xpDDmHpwz5xwoppM +M0Ehi/xw95wSeEoxCQ9CppqbahcAF9RX1n78lBHDW26XtY2TvFpxodAIUDwBEkDawZY6jVoxj/ OspMSC7G7gcEM8+HeEUEeaeUhPNUvZm0q1RnCpVLx36ag== X-Received: by 127.0.0.2 with SMTP id KyFMYY7687511xMiMH4dilWB; Thu, 26 Jun 2025 02:58:51 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.4648.1750931930250881915 for ; Thu, 26 Jun 2025 02:58:50 -0700 X-Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55Q9flYN000433 for ; Thu, 26 Jun 2025 09:58:49 GMT X-Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47f2rq33au-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 26 Jun 2025 09:58:49 +0000 (GMT) X-Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-311ef4fb5eeso763017a91.1 for ; Thu, 26 Jun 2025 02:58:49 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX38TEY6dwiccIgsxJLhSKxkMMqb+hmb2CjZGRlRfNkSutfs/QlFwwJYLOc2j/96SrxLG/+9A==@edk2.groups.io X-Gm-Message-State: rLS0e2tjaOgMcle3tJEIXYg7x7686176AA= X-Gm-Gg: ASbGncugO250U8vwGZjbbx+aGP5K/v7dcTI58YAvBUlMCBedj3Fjo9xcw1XpozMBp3W epUoYcTFBRNcWSE7ztY7WhCUCPwvcvyRkZ9DUJaUuCe2aoRNMAuP89moCn/3EDbzD7/rzuX+XI/ wZkqP/PvqRPVDxh6CwSjlCeAa5lqoi51FPero= X-Received: by 2002:a17:90b:3fcb:b0:313:d342:448c with SMTP id 98e67ed59e1d1-316d6a1ab04mr4074094a91.17.1750931927840; Thu, 26 Jun 2025 02:58:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbZ5Q+8NPpEC90TZh0zB035NX3nvCpSmlQZkW9+XwT+9FiKJSaYl20i0GpkoA07mFkZGeyn9PN0kNEzRNC4ho= X-Received: by 2002:a17:90b:3fcb:b0:313:d342:448c with SMTP id 98e67ed59e1d1-316d6a1ab04mr4074057a91.17.1750931927405; Thu, 26 Jun 2025 02:58:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Leif Lindholm via groups.io" Date: Thu, 26 Jun 2025 10:58:36 +0100 X-Gm-Features: Ac12FXy3Zv5BDI5susJdNdsmsdsPFpnGvAOy7iKUTaK4GNquuJkLDjOdiIWwxlc Message-ID: Subject: Re: [edk2-devel] [edk2-discuss] [Bug]: EmbeddedPkg/VirtualRealTimeClockLib fails to build. To: rithrama@amd.com Cc: "Kinney, Michael D" , Michael Kubacki , discuss@edk2.groups.io, edk2-devel-groups-io X-Authority-Analysis: v=2.4 cv=NdDm13D4 c=1 sm=1 tr=0 ts=685d19d9 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=NEAV23lmAAAA:8 a=zd2uoN0lAAAA:8 a=uy95kIGqSSGc86Xdz4UA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI2MDA4MiBTYWx0ZWRfX+9/E0Jy55BLC PA+B/s+V7GwagI0pxY6MvvEsliRhgDKAzbzmlanwBb8k8WJA+jILYy4AaJL4sDb/7Cdy0YcuoVB Or/Kf56DXc/jpHBQl2XIU6P+JA10bUSrK05CKlLuiao9nJWomxBxfQyLmyAql+uLquGvJSsYF88 LOX0+H1zFCGdWBdqExEvzj9EP65x81WWtufAO1Ujawcmb/Mo9TDhI9XUE9HE5wtOTC9Ipu1RzkW jfCJUr5tevjtWJOQnkcyJjs4MYWbb7FaQzBNlw1A7j9scFM/a6Mr1a/SNqI3Qkjj85e1N706fMk 58XZKWhvyq5A+pWIJMfTCVlgOcpP9PX3lMd4RLUoIlgJsh98de46TSGS5dJd8AGGlyoaURVdZ2v wlY02O3KR3azwW3Jc10sYDsVKMT5UAa9HlK63sea7e1q9LB5Ny1YYkaUL0I1CPva58mvDXww X-Proofpoint-ORIG-GUID: Xmp-mXDukqeJ8OE2SSsFPfxdhMMV7AXO X-Proofpoint-GUID: Xmp-mXDukqeJ8OE2SSsFPfxdhMMV7AXO Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 26 Jun 2025 02:58:50 -0700 Resent-From: leif.lindholm@oss.qualcomm.com Reply-To: devel@edk2.groups.io,leif.lindholm@oss.qualcomm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=groups1 header.b=o8Pta8Y0; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 25 Jun 2025 at 23:14, Rithvik Rama via groups.io wrote: > The EmulatorPkg throws below error when running a build: > edk2\EmbeddedPkg\Library\VirtualRealTimeClockLib\VirtualRealTimeClockLib.c(89): error C2065: 'BUILD_EPOCH': undeclared identifier I don't see EmbeddedPkg referenced in EmulatorPkg. Is EmulatorPkg a typo above? > The reason I raised this discussion is because the source file comments asks me to bring this up with the mailing list: > // > // The following is intended to produce a compilation error on build > // environments where BUILD_EPOCH can not be set from inline shell. > // If you are attempting to use this library on such an environment, please > // contact the edk2 mailing list, so we can try to add support for it. > // > > The toolchain I used: > VS2022 > Windows 11. > > May I know the root cause of this issue and how do I continue to build the EmbeddedPkg successfully? The answer is simple. A lot of EmbeddedPkg has only been tested with/developed for GCC family of toolchains. For those, we generate the BUILD_EPOCH here: https://github.com/tianocore/edk2/blob/master/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf#L37 GCC:*_*_*_CC_FLAGS = -DBUILD_EPOCH=`printenv SOURCE_DATE_EPOCH || date +%s` only sets BUILD_EPOCH for GCC family of toolchains. I don't know how to best wrangle this together for a Visual Studio environment. Maybe a better way there would be to do something with __DATE__ and __TIME__ macros, but I don't think the formats of those are portable between toolchains. Mike, Michael - thoughts? A hack that would let you build this would be to add a line like such: MSFT:*_*_*_CC_FLAGS = -DBUILD_EPOCH=1750931236 (timestamp generated by me in a linux shell with "git log -1 --pretty=%ct | date +%s") / Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121432): https://edk2.groups.io/g/devel/message/121432 Mute This Topic: https://groups.io/mt/113840675/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-