From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2F785AC19A6 for ; Tue, 7 Jan 2025 19:04:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qSutc9iJtwgQSTtKD28cBFAq4/fhtsrtMHfJlsUQWbI=; c=relaxed/simple; d=groups.io; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240830; t=1736276699; v=1; x=1736535898; b=vwUBEkaKWiDMwQarXe/BzC92zoDJdYqpFEvKBmhIhApRgKk484KoiqRDnNoOna18VrDmkeoa kbexIp79MRi+jERhydomOA3B5wuPPLHN1NytQhkCWyxRIbgcEpylElaJSWF7ofVG9+So2BQw29r eTG4tjs+ogrFbKesGL7AQN2OthURtD1BmoIZtZboKpf3Uwb8ikZFr+mNj9NBGaDzyKNr6JkoXC4 7gtbM6brWEc57fa+GrNWEiK7mrGiK5tnX87TdZJdewc3B/r8oaFALoXpOYIR76I/iP5uWrkUVVj e8sMJknOFfhbWYhWZS1ByhRe6cT0xtwTKLag3wHgZQKuA== X-Received: by 127.0.0.2 with SMTP id Q0NMYY7687511x3ay9CHBgiA; Tue, 07 Jan 2025 11:04:58 -0800 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.397.1736276697722440136 for ; Tue, 07 Jan 2025 11:04:57 -0800 X-Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 507C0kov018430 for ; Tue, 7 Jan 2025 19:04:57 GMT X-Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4413w992dn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 07 Jan 2025 19:04:56 +0000 (GMT) X-Received: by mail-yb1-f198.google.com with SMTP id 3f1490d57ef6-e399d4ef55cso34447447276.2 for ; Tue, 07 Jan 2025 11:04:56 -0800 (PST) X-Gm-Message-State: OkO8iRYkVv6AYv54C7XAMVchx7686176AA= X-Gm-Gg: ASbGncsjq35eOPMLn3iVCtBvpp/oYOEDluWqMSqb5AAsWVMM9//b0nhtNIY1glwMx5t UQloeXLHUIscOZZ4nEeUCd3kYzmPJbd0cqmJg10rRVxLN9rPbVWAA/9lFHMzrknHo5/eTVA== X-Received: by 2002:a05:6902:c0f:b0:e54:9e52:19b with SMTP id 3f1490d57ef6-e54edf39659mr82058276.13.1736276695966; Tue, 07 Jan 2025 11:04:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IEn/XrfKennTpEIXi7EaPWiZiPOo5y9cGq+GDgop69C1L7v1jQgRPLphdx+wL4MJKlz2d2lhiVXkf9qRhtrUXY= X-Received: by 2002:a05:6902:c0f:b0:e54:9e52:19b with SMTP id 3f1490d57ef6-e54edf39659mr82035276.13.1736276695544; Tue, 07 Jan 2025 11:04:55 -0800 (PST) MIME-Version: 1.0 From: "Leif Lindholm via groups.io" Date: Tue, 7 Jan 2025 19:04:44 +0000 X-Gm-Features: AbW1kvZ8JlRBtA2El6gFfu2cCxDhSlufVYft38tUHfjWRJapAkRPfGsq4GXHAvw Message-ID: Subject: [edk2-devel] Expansion of ARCH in .dsc files To: devel@edk2.groups.io Cc: Ajan Zhong , Ard Biesheuvel , "Kinney, Michael D" X-Proofpoint-ORIG-GUID: YoKz6eGrVhKvHU0MrKYO8JI7NUJQ8onC X-Proofpoint-GUID: YoKz6eGrVhKvHU0MrKYO8JI7NUJQ8onC Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 07 Jan 2025 11:04:57 -0800 Resent-From: leif.lindholm@oss.qualcomm.com Reply-To: devel@edk2.groups.io,leif.lindholm@oss.qualcomm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=vwUBEkaK; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io So... I originally tripped over my misunderstanding of when writing https://github.com/tianocore/edk2/pull/6262 to get around something I wanted to test in UefiPayloadPkg. Now Ajan has run into at least an adjacent problem when trying to rework https://github.com/tianocore/edk2/pull/6545 based on feedback I among others provided. Now, the thing I had misunderstood before is that when build is called with multiple -a options, the ARCH variable will expand to a space-separated list of *all* the specified architectures. A lot of Arm/AArch64 modules assume this variable only ever contains a single architecture. The thing is, I don't think this is clearly documented in the .dsc specification at all. And it is frequently used as a shorthand in there in a form that would only work if build was called with a single -a. Now, this also means that there are nearly no correct users of ARCH in edk2 or edk2-platforms. Because "the list of all architectures being built simultaneously" simply isn't very useful information build-time. There are two correct uses in edk2, in EmulatorPkg.dsc and in UefiPayloadPkg.dsc, using '!if "IA32" in "$ARCH"', which as far as I can tell is the only possible way to use the variable correctly. Slightly amusingly, EmulatorPkg.dsc also contains an incorrect use. I guess the behaviour is a direct result of how the build command is architected. I guess the one question I have is - is this the intended behaviour? Ard: I think we need to update some of our .dsc files... Ajan: one somewhat hacky workaround I can think of to separate the output images is to hardcode the output image name in arch-specific Defines sections, like so: diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index 0bd8d85cab03..f07f2b91764e 100644 --- a/ArmVirtPkg/ArmVirtQemu.dsc +++ b/ArmVirtPkg/ArmVirtQemu.dsc @@ -12,12 +12,17 @@ # Defines Section - statements that will be processed to create a Makefile. # ################################################################################ +[Defines.ARM] + OUTPUT_DIRECTORY = Build/ArmVirtQemu-ARM + +[Defines.AARCH64] + OUTPUT_DIRECTORY = Build/ArmVirtQemu-AARCH64 + [Defines] PLATFORM_NAME = ArmVirtQemu PLATFORM_GUID = 37d7e986-f7e9-45c2-8067-e371421a626c PLATFORM_VERSION = 0.1 DSC_SPECIFICATION = 0x00010005 - OUTPUT_DIRECTORY = Build/ArmVirtQemu-$(ARCH) SUPPORTED_ARCHITECTURES = AARCH64|ARM BUILD_TARGETS = DEBUG|RELEASE|NOOPT SKUID_IDENTIFIER = DEFAULT -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120967): https://edk2.groups.io/g/devel/message/120967 Mute This Topic: https://groups.io/mt/110483263/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-