public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Change from "BaseTools/LzmaCompress: Fix possible uninitialized variable" patch was reverted
@ 2022-01-05 19:18 Denis Nikitin
  2022-01-06  0:46 ` Wu, Hao A
  0 siblings, 1 reply; 3+ messages in thread
From: Denis Nikitin @ 2022-01-05 19:18 UTC (permalink / raw)
  To: hao.a.wu; +Cc: liming.gao, yonghong.zhu, devel, kramasub

Hi Hao,

While updating edk2 in Chrome OS we noticed that the change in your
patch https://edk2.groups.io/g/devel/message/19270 was reverted in
commit:
5ec5a236d1 BaseTools Lzma: Update LZMA SDK version to 18.05.

If you think the fix is critical I think it should be merged in
https://www.7-zip.org/sdk.html.

Thanks,
Denis

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: Change from "BaseTools/LzmaCompress: Fix possible uninitialized variable" patch was reverted
  2022-01-05 19:18 Change from "BaseTools/LzmaCompress: Fix possible uninitialized variable" patch was reverted Denis Nikitin
@ 2022-01-06  0:46 ` Wu, Hao A
  2022-01-06  7:20   ` Denis Nikitin
  0 siblings, 1 reply; 3+ messages in thread
From: Wu, Hao A @ 2022-01-06  0:46 UTC (permalink / raw)
  To: Denis Nikitin, Gao, Liming
  Cc: yonghong.zhu@intel.com, devel@edk2.groups.io,
	Ramasubramanian, Karthik

Hello Denis,

As far as I can recall, the fix you mentioned is a change that to please the static analysis tool.
My opinion is that it not a critical fix.

Best Regards,
Hao Wu

> -----Original Message-----
> From: Denis Nikitin <denik@chromium.org>
> Sent: Thursday, January 6, 2022 3:19 AM
> To: Wu, Hao A <hao.a.wu@intel.com>
> Cc: liming.gao@intel.com; yonghong.zhu@intel.com; devel@edk2.groups.io;
> Ramasubramanian, Karthik <kramasub@google.com>
> Subject: Change from "BaseTools/LzmaCompress: Fix possible uninitialized
> variable" patch was reverted
> 
> Hi Hao,
> 
> While updating edk2 in Chrome OS we noticed that the change in your patch
> https://edk2.groups.io/g/devel/message/19270 was reverted in
> commit:
> 5ec5a236d1 BaseTools Lzma: Update LZMA SDK version to 18.05.
> 
> If you think the fix is critical I think it should be merged in https://www.7-
> zip.org/sdk.html.
> 
> Thanks,
> Denis

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: Change from "BaseTools/LzmaCompress: Fix possible uninitialized variable" patch was reverted
  2022-01-06  0:46 ` Wu, Hao A
@ 2022-01-06  7:20   ` Denis Nikitin
  0 siblings, 0 replies; 3+ messages in thread
From: Denis Nikitin @ 2022-01-06  7:20 UTC (permalink / raw)
  To: Wu, Hao A; +Cc: devel@edk2.groups.io, Ramasubramanian, Karthik

Thanks for confirmation. I agree that the warning doesn't look severe.

- Denis

On Wed, Jan 5, 2022 at 4:46 PM Wu, Hao A <hao.a.wu@intel.com> wrote:
>
> Hello Denis,
>
> As far as I can recall, the fix you mentioned is a change that to please the static analysis tool.
> My opinion is that it not a critical fix.
>
> Best Regards,
> Hao Wu
>
> > -----Original Message-----
> > From: Denis Nikitin <denik@chromium.org>
> > Sent: Thursday, January 6, 2022 3:19 AM
> > To: Wu, Hao A <hao.a.wu@intel.com>
> > Cc: liming.gao@intel.com; yonghong.zhu@intel.com; devel@edk2.groups.io;
> > Ramasubramanian, Karthik <kramasub@google.com>
> > Subject: Change from "BaseTools/LzmaCompress: Fix possible uninitialized
> > variable" patch was reverted
> >
> > Hi Hao,
> >
> > While updating edk2 in Chrome OS we noticed that the change in your patch
> > https://edk2.groups.io/g/devel/message/19270 was reverted in
> > commit:
> > 5ec5a236d1 BaseTools Lzma: Update LZMA SDK version to 18.05.
> >
> > If you think the fix is critical I think it should be merged in https://www.7-
> > zip.org/sdk.html.
> >
> > Thanks,
> > Denis

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-06  7:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-05 19:18 Change from "BaseTools/LzmaCompress: Fix possible uninitialized variable" patch was reverted Denis Nikitin
2022-01-06  0:46 ` Wu, Hao A
2022-01-06  7:20   ` Denis Nikitin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox