From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52])
 by mx.groups.io with SMTP id smtpd.web08.5802.1641453614675716582
 for <devel@edk2.groups.io>;
 Wed, 05 Jan 2022 23:20:15 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@chromium.org header.s=google header.b=GTkYAkUh;
 spf=pass (domain: chromium.org, ip: 209.85.208.52, mailfrom: denik@chromium.org)
Received: by mail-ed1-f52.google.com with SMTP id j21so6009015edt.9
        for <devel@edk2.groups.io>; Wed, 05 Jan 2022 23:20:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=chromium.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=BgmCd2ggoKxQ0EWMqRdWk6+JMxcgI0in3K+DBeqqscc=;
        b=GTkYAkUhaxQPJ2tPswKwsk4gYcIPkb471rvViKPyXx7RFDcZNYInO1AeSzVA0zub0d
         A3svb7+OU5HantGYPHjtJ4Awp0pZrdGDd5A0wg5Oh6hxcEd0ksy+GZ+5/aVzjnxKA5M+
         6X84ZT6MY4NfyXYoO1+C1iVn16ysMX7eoA6zY=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=BgmCd2ggoKxQ0EWMqRdWk6+JMxcgI0in3K+DBeqqscc=;
        b=ipExy0mkpnthK75a04DCu7Tm6apNvWEXi3ICEE0CaH53nY7r9OjdkZju8SOC9A1FNo
         qo4Unb7RNdpwFhDs4OLGS+Gj2J9MU1EOBYKZ9l14e1+giFZIb/VRtKALF3RPmHLk1AeR
         gFMItF6oaLrsLBYREi7uCSQGupOry5k3xaiK6pnHWbmGEkBrNaWqGW1bfcEvJzQHY/Fh
         jm3I1m30Zuv2zLm4t5lvY2XZWxArYCWlx7weTSSxWDnmrBaVuRYmdrDu1I+ysEcIQP8g
         q/6t1aDAMY1Njll9nusgEFxsxWxVQ4qDEyqB4pae4FV+D+KFO+XsB4YYVk2erxEGMkYO
         pIqQ==
X-Gm-Message-State: AOAM532iExAZhgbm5EsgCVOFjityf9cZqhrjLI848LqwBVdBqpBxRJHV
	QSV61u7FhUau29sb3diQcWB6Pwak6/v/CNBmwO650w==
X-Google-Smtp-Source: ABdhPJzexcU3VAXLNapPmJspGTsylG5hxGehlZVlG6rhCiLqlCBUVn/al4Qe/4/CYvZZOtpwvHgNxPUrjKvl6TJUr1A=
X-Received: by 2002:a05:6402:147:: with SMTP id s7mr55830980edu.8.1641453613077;
 Wed, 05 Jan 2022 23:20:13 -0800 (PST)
MIME-Version: 1.0
References: <CADDJ8CXgARjNUi0kzbvy4n4FO7vCS_RrDJqbOS8A42779zajaQ@mail.gmail.com>
 <DM6PR11MB40253439F77E465EFAAADEF8CA4C9@DM6PR11MB4025.namprd11.prod.outlook.com>
In-Reply-To: <DM6PR11MB40253439F77E465EFAAADEF8CA4C9@DM6PR11MB4025.namprd11.prod.outlook.com>
From: Denis Nikitin <denik@chromium.org>
Date: Wed, 5 Jan 2022 23:20:01 -0800
Message-ID: <CADDJ8CXUW62BmANcSODAD-pKBasYszpAa9BMCXvkRoxjqne6Dw@mail.gmail.com>
Subject: Re: Change from "BaseTools/LzmaCompress: Fix possible uninitialized variable" patch was reverted
To: "Wu, Hao A" <hao.a.wu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Ramasubramanian, Karthik" <kramasub@google.com>
Content-Type: text/plain; charset="UTF-8"

Thanks for confirmation. I agree that the warning doesn't look severe.

- Denis

On Wed, Jan 5, 2022 at 4:46 PM Wu, Hao A <hao.a.wu@intel.com> wrote:
>
> Hello Denis,
>
> As far as I can recall, the fix you mentioned is a change that to please the static analysis tool.
> My opinion is that it not a critical fix.
>
> Best Regards,
> Hao Wu
>
> > -----Original Message-----
> > From: Denis Nikitin <denik@chromium.org>
> > Sent: Thursday, January 6, 2022 3:19 AM
> > To: Wu, Hao A <hao.a.wu@intel.com>
> > Cc: liming.gao@intel.com; yonghong.zhu@intel.com; devel@edk2.groups.io;
> > Ramasubramanian, Karthik <kramasub@google.com>
> > Subject: Change from "BaseTools/LzmaCompress: Fix possible uninitialized
> > variable" patch was reverted
> >
> > Hi Hao,
> >
> > While updating edk2 in Chrome OS we noticed that the change in your patch
> > https://edk2.groups.io/g/devel/message/19270 was reverted in
> > commit:
> > 5ec5a236d1 BaseTools Lzma: Update LZMA SDK version to 18.05.
> >
> > If you think the fix is critical I think it should be merged in https://www.7-
> > zip.org/sdk.html.
> >
> > Thanks,
> > Denis