From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by mx.groups.io with SMTP id smtpd.web11.24180.1653281905737742318 for ; Sun, 22 May 2022 21:58:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Ic6VzHFv; spf=pass (domain: linaro.org, ip: 209.85.128.182, mailfrom: masahisa.kojima@linaro.org) Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-2ff53d86abbso115911147b3.8 for ; Sun, 22 May 2022 21:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5G231jHy6D2qWo5yE1IGQ/zL/4zh0b04jhtSuex1gKg=; b=Ic6VzHFvJ0BHEK6XMYq2s7CmUxQSHSgTQ1YcdyyiyUTQnj0aHPhBxXfUrHzIDtFaIM as/akTsO9ff6HM8lCeeHAoGeuhQPYZRWbMqLgfKPKsWJAVyboKhbDzjD0GW7C13ZQ+xA Taxcjj+uIVIyXrvFAMawXfVuuNDvOGOvwxVcvHo5i0s9HroIFwHz7NXtZ42McVZtlnBU mwdSW9wNxgg17CYh/evBdG0NXlJ4W7qqfszruffWv3SRDeVOQi2ZWWGHRRpgRB8dcD+v UCtTLjcvs7ciFc2fwy7yjOO44lFrZOXCA+V6PtgxjnCTGAS/VNSMoc5uOqlgb4OfxESv mqQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5G231jHy6D2qWo5yE1IGQ/zL/4zh0b04jhtSuex1gKg=; b=Fwqsk+JZze9MJmdpBNHVx1D205nD0ZJmDne9GziwnrzghMEKsTrPO6aM9aYpTwpRql OWQP0fiYs62g7byVuqnfkGoWPpzclN7It00jYI4Lpe5UrvstoV81Q6CO1PNWFc09XhlM VuW3Th9CoAscAPjvPpuSVVrizs/KeuDYwKnAGnpK5DtRmhZdnSgqT7MRmMfgmiH1r/iI UyfgL8chPDMV/87xGXQXQRTYRTDQzVnQp92Z+ksQpCEdtdpFG0kv9/wt10txEIBo/RW5 axq/3u52Wh/db1Op3uKKmxOdCote2Ywriyhusq9bx5lV8j9UTGytvZp/Xyh6aJ43Bwpr 5AQA== X-Gm-Message-State: AOAM530SX/uaoO3+BnaD19BDhbuVcE0Em6100VEImjfg38RmtNk+JKqV ib+Ga6n4C9T/6zEjfe2FggEvtXGjALoRHaNw6RWf5Q== X-Google-Smtp-Source: ABdhPJzmy6nbkYTzOReHR0VTnS7ZE1lrrSzIrvdvvEOitIhBFHRTD+OIZZTbqM9+5LPYTPXtVMGIFeWhuL8KE4SZymg= X-Received: by 2002:a81:324b:0:b0:2ff:a2cc:38a0 with SMTP id y72-20020a81324b000000b002ffa2cc38a0mr11421821ywy.9.1653281904872; Sun, 22 May 2022 21:58:24 -0700 (PDT) MIME-Version: 1.0 References: <163911902995.561661.9429300579159746333.stgit@localhost> <163911907249.561661.11382999726925773930.stgit@localhost> In-Reply-To: <163911907249.561661.11382999726925773930.stgit@localhost> From: "Masahisa Kojima" Date: Mon, 23 May 2022 13:58:13 +0900 Message-ID: Subject: Re: [PATCH v3 5/6] [edk2-platforms] Silicon/SynQuacer: add DBG2 ACPI table To: Leif Lindholm , Ard Biesheuvel Cc: devel@edk2.groups.io, Kazuhiko Sakamoto Content-Type: text/plain; charset="UTF-8" Hi Leif, Ard, A gentle ping on this on behalf of Masami, since he left Linaro. Thanks, Masahisa Kojima On Fri, 10 Dec 2021 at 15:51, Masami Hiramatsu wrote: > > Add DBG2 table to ACPI tables. The COM1 uart port will be used > for OS debug, and it is 16550 compatible. > > Signed-off-by: Masami Hiramatsu > --- > Changes in v2: > - Move Dbg2.aslc before Dsdt.asl to keep the list alphabetically sorted. > - Use EFI_ACPI_6_3_SYSTEM_MEMORY and EFI_ACPI_6_3_BYTE for initialization. > --- > .../Socionext/SynQuacer/AcpiTables/AcpiTables.inf | 1 > Silicon/Socionext/SynQuacer/AcpiTables/Dbg2.aslc | 70 ++++++++++++++++++++ > 2 files changed, 71 insertions(+) > create mode 100644 Silicon/Socionext/SynQuacer/AcpiTables/Dbg2.aslc > > diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf b/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf > index 886777a0fa..e77d7a3056 100644 > --- a/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf > +++ b/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf > @@ -19,6 +19,7 @@ > [Sources] > AcpiTables.h > AcpiSsdtRootPci.asl > + Dbg2.aslc > Dsdt.asl > Fadt.aslc > Gtdt.aslc > diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dbg2.aslc b/Silicon/Socionext/SynQuacer/AcpiTables/Dbg2.aslc > new file mode 100644 > index 0000000000..89c9dbd998 > --- /dev/null > +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dbg2.aslc > @@ -0,0 +1,70 @@ > +/** @file > +* Debug Port Table (DBG2) > +* > +* Copyright (c) 2020,2021 Linaro Ltd. All rights reserved. > +* > +* SPDX-License-Identifier: BSD-2-Clause-Patent > +* > +**/ > +#include > +#include > +#include > +#include > +#include > + > +#include "AcpiTables.h" > + > +#pragma pack(1) > + > +#define SYNQUACER_UART1_STR { '\\', '_', 'S', 'B', '.', 'C', 'O', 'M', '1', 0x00 } > +#define SQ_GAS32(Address) { EFI_ACPI_6_3_SYSTEM_MEMORY, 32, 0, EFI_ACPI_6_3_BYTE, Address } > + > +typedef struct { > + EFI_ACPI_DBG2_DEBUG_DEVICE_INFORMATION_STRUCT Dbg2Device; > + EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE BaseAddressRegister; > + UINT32 AddressSize; > + UINT8 NameSpaceString[10]; > +} DBG2_DEBUG_DEVICE_INFORMATION; > + > +typedef struct { > + EFI_ACPI_DEBUG_PORT_2_DESCRIPTION_TABLE Description; > + DBG2_DEBUG_DEVICE_INFORMATION Dbg2DeviceInfo; > +} DBG2_TABLE; > + > + > +STATIC DBG2_TABLE Dbg2 = { > + { > + __ACPI_HEADER ( > + EFI_ACPI_6_3_DEBUG_PORT_2_TABLE_SIGNATURE, > + DBG2_TABLE, > + EFI_ACPI_DBG2_DEBUG_DEVICE_INFORMATION_STRUCT_REVISION > + ), > + OFFSET_OF (DBG2_TABLE, Dbg2DeviceInfo), > + 1 /* NumberOfDebugPorts */ > + }, > + { > + { > + EFI_ACPI_DBG2_DEBUG_DEVICE_INFORMATION_STRUCT_REVISION, > + sizeof (DBG2_DEBUG_DEVICE_INFORMATION), > + 1, /* NumberofGenericAddressRegisters */ > + 10, /* NameSpaceStringLength */ > + OFFSET_OF (DBG2_DEBUG_DEVICE_INFORMATION, NameSpaceString), > + 0, /* OemDataLength */ > + 0, /* OemDataOffset */ > + EFI_ACPI_DBG2_PORT_TYPE_SERIAL, > + EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS, > + {EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE}, > + OFFSET_OF (DBG2_DEBUG_DEVICE_INFORMATION, BaseAddressRegister), > + OFFSET_OF (DBG2_DEBUG_DEVICE_INFORMATION, AddressSize) > + }, > + SQ_GAS32 (SYNQUACER_UART1_BASE), /* BaseAddressRegister */ > + SYNQUACER_UART1_SIZE, /* AddressSize */ > + SYNQUACER_UART1_STR, /* NameSpaceString */ > + } > +}; > + > +#pragma pack() > + > +// Reference the table being generated to prevent the optimizer from removing > +// the data structure from the executable > +VOID* CONST ReferenceAcpiTable = &Dbg2; >