From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by mx.groups.io with SMTP id smtpd.web11.5391.1657788226863533463 for ; Thu, 14 Jul 2022 01:43:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=hDAjQWRx; spf=pass (domain: linaro.org, ip: 209.85.219.178, mailfrom: masahisa.kojima@linaro.org) Received: by mail-yb1-f178.google.com with SMTP id f73so2028682yba.10 for ; Thu, 14 Jul 2022 01:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hUwVAfI+RjceXS8h/JL2KkDfa7VxnFo9l5RIwrM8k5I=; b=hDAjQWRxzTRIsyxzFJyanQQWl8WCbwl3kJ+GKn9F7bvEbrkwtcm4tpfetqe+FaGSRf bkie0/Dad/H7PjGgoHZe299unjJjKr37B6weZ1Q5ydtRKJALqlgyK3fnmW+yvJickgNQ GmAZZQBmk5lzVOSrliIWB/Fioz6JMlgJTpqeA8AD/+g5Cef+N3uU4pKDlLH5hwTygWbI rxOwwLFD54+8VpePDcqDrXjvNCIiSujXuDoH02DVeyVpVx63RSjsgz2FLAPHf6OgJVbd tUNXBl1YfNp1wAQfH+BRCgeRm907e+YcrP/rws3XsWDyzHDX6oRX4+U//4/p+qqPpINH 372w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hUwVAfI+RjceXS8h/JL2KkDfa7VxnFo9l5RIwrM8k5I=; b=FtAznuykKed2n+aX7xlUbROSExCFPQcJ+0YkW7v3RybjbP2nal9v0Lf70QWL+H0OOb FCIYrOSNOp3YAmV6UPOk4rGWRqy8vFdkDa2Qe6OVIexsLPZMOmng0vDc2PqPbcl3Drq2 nXTZhdG3vxwSnyGbYaB3Ne/L8+HTW6eycjuObAajgMxy9ZVPc/eMUamRQ/ZouTgrroNZ 8u0tMayggKv0/jWYNZiOnE6Sr3yIDIeXFmFgE0Ub5W75KxPAnLUeGdTbYS02WmAUfYI8 DIp+g1d2ccrpYWsxJqI4NvA6VNn7k9SkhKbK9U00Xfx9uSbvzhsVkXTOG/qPsz8gVQt1 RFxQ== X-Gm-Message-State: AJIora9dKf4Tpja9v89ysKKhRwuy+Ozh5pISrJpZ5xvIMD8tUVG9F43c lXAJZpWo1eECJHDuzJE8xjZZC3d8be/23gsiX2/zrd1mMTDG5QnF X-Google-Smtp-Source: AGRyM1uxJgVb2ms/pIKM4aIm4Ad+PYFxPEzPuSd5RAXvnVu1j0zTbKJ8boi/nJpb9CGRJPfyaGcy8lrSLB/e+mTBoww= X-Received: by 2002:a25:1d06:0:b0:66e:2ab2:b888 with SMTP id d6-20020a251d06000000b0066e2ab2b888mr7824562ybd.337.1657788225802; Thu, 14 Jul 2022 01:43:45 -0700 (PDT) MIME-Version: 1.0 References: <20220712144047.3080-1-sami.mujawar@arm.com> <0d1690bd-2893-6595-e214-409bed94e613@arm.com> <00221d7a-fd0f-fa9f-6ff3-ccd477740dd5@arm.com> In-Reply-To: <00221d7a-fd0f-fa9f-6ff3-ccd477740dd5@arm.com> From: "Masahisa Kojima" Date: Thu, 14 Jul 2022 17:43:34 +0900 Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro To: devel@edk2.groups.io, sami.mujawar@arm.com Cc: pierre.gondois@arm.com, Leif Lindholm , Ard Biesheuvel , Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, gaoliming@byosoft.com.cn, jeremy.linton@arm.com, thomas.abraham@arm.com, Chandni.Cherukuri@arm.com, nhi@os.amperecomputing.com, vunguyen@os.amperecomputing.com, thang@os.amperecomputing.com, chuong@os.amperecomputing.com, xiepeng@phytium.com.cn, jialing@phytium.com.cn, shuyiqi@phytium.com.cn, nd@arm.com Content-Type: text/plain; charset="UTF-8" Hi Sami, On Thu, 14 Jul 2022 at 17:01, Sami Mujawar wrote: > > Hi Masahisa, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 14/07/2022 07:38 am, Masahisa Kojima wrote: > > Hi Sami, > > > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > also requires the VariableFlashInfoLib library. > > I have checked that the build error is fixed with the following modification. > > > > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > @@ -111,7 +111,7 @@ [LibraryClasses] > > > > NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf > > NorFlashPlatformLib|Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacerLib.inf > > - > > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > [SAMI] I think this change should have been part of the series at > https://edk2.groups.io/g/devel/message/89156. However, I will include > this change im my series. Thank you very much for including the modification in your series. Regards, Masahisa Kojima > > The platforms in edk2-platforms repository are frequently broken by > changes in edk2 repository. I believe this is due to the lack of > edk2-platforms CI and we really need to fix that. > > [/SAMI] > > > Thanks, > > Masahisa Kojima > > > > On Wed, 13 Jul 2022 at 22:19, PierreGondois wrote: > >> Hi Sami, > >> I think > >> Silicon/NXP/NxpQoriqLs.dsc.inc > >> also requires the VariableFlashInfoLib library. Otherwise: > >> > >> Reviewed-by: Pierre Gondois > >> > >> > >> On 7/12/22 16:40, Sami Mujawar wrote: > >>> This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0 > >>> macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the > >>> feedback received. It also includes an additional patch that fixes > >>> the build break in CelloBoard due to missing VariablePolicyHelperLib > >>> dependency. > >>> > >>> The v2 patch series fixes the build break in Ampere/Jade and > >>> Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency > >>> and also updates the IORT revision macro. > >>> > >>> The IORT Rev E.d specification updates the IORT table revision > >>> to 5. Following this the IORT table revision macro > >>> EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has > >>> been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore, > >>> this series updates the following platforms to reflect this > >>> renaming: > >>> - FVP > >>> - Morello FVP > >>> - SGI > >>> - AMD/Styx > >>> - Socionext/SynQuacer > >>> - RaspberryPi > >>> - N1SDP > >>> - Ampere/Jade > >>> - Pythium/FT2000-4 > >>> > >>> Note: This patch series is dependent on the edk2 patch series: > >>> "[PATCH v5 0/8] IORT Rev E.d specification updates" > >>> (https://edk2.groups.io/g/devel/message/91264), which must > >>> be merged in edk2 before this patch series can be integrated. > >>> > >>> The changes can be seen at: > >>> https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v3 > >>> > >>> Sami Mujawar (12): > >>> Platform/ARM: FVP: Update for IORT revision macro renaming > >>> Platform/ARM: Morello: Update for IORT revision macro renaming > >>> Platform/ARM: SGI: Update for IORT revision macro renaming > >>> Silicon/AMD/Styx: Update for IORT revision macro renaming > >>> Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming > >>> Platform/RaspberryPi: Update for IORT revision macro renaming > >>> Platform/ARM: N1SDP: Update for IORT revision macro renaming > >>> Silicon/Ampere: Add VariableFlashInfoLib > >>> Platform/Ampere: JadePkg: Update for IORT revision macro renaming > >>> Silicon/Phytium: Add VariableFlashInfoLib > >>> Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming > >>> Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib > >>> > >>> Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c | 2 +- > >>> Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +- > >>> Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +- > >>> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +- > >>> Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +- > >>> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 + > >>> Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +- > >>> Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +- > >>> Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 + > >>> Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 2 +- > >>> Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 + > >>> Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +- > >>> 12 files changed, 12 insertions(+), 9 deletions(-) > >>> > >> > >> > >> > >> > > > > >