Re: [PATCH] Silicon/NXP/Pcf8563RealTimeClockLib: add rtc device initialization

[Masahisa Kojima <masahisa.kojima@linaro.org>]

On Tue, 19 Jun 2018 at 00:51, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On 18 June 2018 at 16:29, Masahisa Kojima <masahisa.kojima@linaro.org> wrote:
> > Hi Ard,
> >
> > Thank you for comment.
> >
> >> Wouldn't it be better to return EFI_DEVICE_ERROR in this case?
> >
> > It is first option I come up with to fix this issue.
> > But edk2/ShellPkg/Library/UefiShellLevel2CommandsLib/TimeDate.c::CheckAndSetTime()
> > performs GetTime()->update with user specified time->SetTime(),
> > If GetTime() failes, SetTime() never called and user can not set time.
> >  # It really depends on the RTC device, we failed to set time in 70% devices.
> >
> > Another place to perform this dummy time/date setting is inside of
> > LibRtcInitialize().
> > Current error occurs in setting time, and I prefer to add this process
> > in GetTime().
> >
>
> I think we should fix the shell command instead. Setting the time
> should be possible even if getting the time file, precisely for
> situations like this one.

OK, I agree with you.