From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by mx.groups.io with SMTP id smtpd.web12.4710.1657780709478583376 for ; Wed, 13 Jul 2022 23:38:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=w9yggAsM; spf=pass (domain: linaro.org, ip: 209.85.128.178, mailfrom: masahisa.kojima@linaro.org) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-31caffa4a45so7635437b3.3 for ; Wed, 13 Jul 2022 23:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PEObqQC9YA2G0MGJtFPG0DBJuar0U4JnNJNatne2G5E=; b=w9yggAsM32DS/WhORr8FVHaabFuefClVMMGmPprsmUIt6ftpiRO4V7ynne+q6wgzW1 1gBc9PmaVE8wqBL85q1Ty33x+NpRGSbulL/Bgsso2G5Ou5gV0Fyz+C8+BPQDuHMAvUq3 egc09Fytg4JYg75eUOIhXga3PZiSLD6BhckhwKDcSqePZ96r9Om0VMvV7CSBCVUtAQ9v qQIQOrmVaF2tMGHSDyx2Z0eDjKgGWRrnfLg8zDHOwyUzUOLpKvjgWiaovjMAZ4U6jbD1 hvwxN+o6u02fqOpbPIcd24s8tKCGlpLutppBke07BGo3Wke+vexB/+aFY0a68Heb9RjI LAMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PEObqQC9YA2G0MGJtFPG0DBJuar0U4JnNJNatne2G5E=; b=LX/wqqNYr5EDIhxYXpCbLViwVJqy/3yWE4BhU7tnqPBdMFZNX5UMvtluz85JENVX4o EUv2FkVWbxaa6G9Qlgw/lxu5PkWOiJenptIe7skC4FMaA76Pi0i4gEsO/hgdFxrGtJh5 iP8h9wcDDmFmpW35MtT2FUU/WBp+QRsatMQ9ml4trodaNfxhm9Tlh4fM6I6Hs7+XwFRZ TYf+Da5GlXARYQTR/I4RHRT0mKKKzge+gfpjIV0r4MchzSsSsjGayFu5h45Io7sHca2M 3vlATVjGgJqMpop8UkJ5VWOT/iVQ4+vo2mImqQEju/Dj08H3ggxV7CIuKs6OXXe7Cna6 HKfw== X-Gm-Message-State: AJIora+rdeyyaTsHfSq4Q20L3opPR1c428hwz4BDqnSs+ZWW999SEGc6 WLzvqV8ISXQtUeZggRYUTQHZEiOw6D2GlTWVUsIafGt/M3Z85g== X-Google-Smtp-Source: AGRyM1v/03LPwpb0g+Tc8HXYCgo4KOigrZPr5AhB2hJiqUBDDWvnsmx1E59jEqWyViJbcB4+4+lTbfKpe6zDZhR5IJw= X-Received: by 2002:a81:5d89:0:b0:31c:9743:5519 with SMTP id r131-20020a815d89000000b0031c97435519mr8330221ywb.368.1657780708502; Wed, 13 Jul 2022 23:38:28 -0700 (PDT) MIME-Version: 1.0 References: <20220712144047.3080-1-sami.mujawar@arm.com> <0d1690bd-2893-6595-e214-409bed94e613@arm.com> In-Reply-To: <0d1690bd-2893-6595-e214-409bed94e613@arm.com> From: "Masahisa Kojima" Date: Thu, 14 Jul 2022 15:38:17 +0900 Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro To: devel@edk2.groups.io, pierre.gondois@arm.com, Sami Mujawar Cc: ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, gaoliming@byosoft.com.cn, jeremy.linton@arm.com, thomas.abraham@arm.com, Chandni.Cherukuri@arm.com, nhi@os.amperecomputing.com, vunguyen@os.amperecomputing.com, thang@os.amperecomputing.com, chuong@os.amperecomputing.com, xiepeng@phytium.com.cn, jialing@phytium.com.cn, shuyiqi@phytium.com.cn, nd@arm.com Content-Type: text/plain; charset="UTF-8" Hi Sami, Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc also requires the VariableFlashInfoLib library. I have checked that the build error is fixed with the following modification. --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc @@ -111,7 +111,7 @@ [LibraryClasses] NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf NorFlashPlatformLib|Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacerLib.inf - + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf Thanks, Masahisa Kojima On Wed, 13 Jul 2022 at 22:19, PierreGondois wrote: > > Hi Sami, > I think > Silicon/NXP/NxpQoriqLs.dsc.inc > also requires the VariableFlashInfoLib library. Otherwise: > > Reviewed-by: Pierre Gondois > > > On 7/12/22 16:40, Sami Mujawar wrote: > > This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0 > > macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the > > feedback received. It also includes an additional patch that fixes > > the build break in CelloBoard due to missing VariablePolicyHelperLib > > dependency. > > > > The v2 patch series fixes the build break in Ampere/Jade and > > Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency > > and also updates the IORT revision macro. > > > > The IORT Rev E.d specification updates the IORT table revision > > to 5. Following this the IORT table revision macro > > EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has > > been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore, > > this series updates the following platforms to reflect this > > renaming: > > - FVP > > - Morello FVP > > - SGI > > - AMD/Styx > > - Socionext/SynQuacer > > - RaspberryPi > > - N1SDP > > - Ampere/Jade > > - Pythium/FT2000-4 > > > > Note: This patch series is dependent on the edk2 patch series: > > "[PATCH v5 0/8] IORT Rev E.d specification updates" > > (https://edk2.groups.io/g/devel/message/91264), which must > > be merged in edk2 before this patch series can be integrated. > > > > The changes can be seen at: > > https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v3 > > > > Sami Mujawar (12): > > Platform/ARM: FVP: Update for IORT revision macro renaming > > Platform/ARM: Morello: Update for IORT revision macro renaming > > Platform/ARM: SGI: Update for IORT revision macro renaming > > Silicon/AMD/Styx: Update for IORT revision macro renaming > > Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming > > Platform/RaspberryPi: Update for IORT revision macro renaming > > Platform/ARM: N1SDP: Update for IORT revision macro renaming > > Silicon/Ampere: Add VariableFlashInfoLib > > Platform/Ampere: JadePkg: Update for IORT revision macro renaming > > Silicon/Phytium: Add VariableFlashInfoLib > > Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming > > Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib > > > > Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c | 2 +- > > Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +- > > Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +- > > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +- > > Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +- > > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 + > > Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +- > > Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +- > > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 + > > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 2 +- > > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 + > > Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +- > > 12 files changed, 12 insertions(+), 9 deletions(-) > > > > > > >