From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by mx.groups.io with SMTP id smtpd.web12.8028.1614689140525466488 for ; Tue, 02 Mar 2021 04:45:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=UTrcHcuT; spf=pass (domain: linaro.org, ip: 209.85.208.173, mailfrom: masahisa.kojima@linaro.org) Received: by mail-lj1-f173.google.com with SMTP id e2so16563466ljo.7 for ; Tue, 02 Mar 2021 04:45:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Wdm5AmPxLRfa2/0TZ+gtBdn5dGr1h80IFsGKYgvu6Qw=; b=UTrcHcuT2FuwJiESykcw5oexRqNfjeWhyfRvEUPdDt5wcvBiDr53mIQOfy0BxIZYWH DRCW8HgfeVMdEpVfchsbIpzQh95RJj/eLOOY6LlIQir8aXiIfh9MsXmi7vgavUg1fV4G s4JpAjhVEX2PjW0TXAacI/LDZdsAaPs6kamvhEvBJA9micVznY8dnOWFJgmIKrOehDkN LTp9YQ4AuZfK8sjylu9VpnGnqyuMlXW1CdHijXeqW/sxr7wMsx1f0V/BPtu3RKlRwh3e /beqFvNBbveQIO3yjGVrLeeLhXo/SSoDvdio4XOlvFRH+kppH/UpIDEoV95kxUhqhLRa 2mvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wdm5AmPxLRfa2/0TZ+gtBdn5dGr1h80IFsGKYgvu6Qw=; b=t32o7rWPaRyDCgrbDB1GQwATYUYi2Pck6uc2o6Mb8DSDvYs5RM/w57cx9dbzXij/Un ectlDW4P/RPfBKKerVjpxOGTvYgXeWQ8t88+GP5TMoqwKwOG4WyWjJXTnVEihz697e3f NBdvB5197PoI3pOVkYbMaZJS0WdymHESVgRDm1pIAYY/oiAWfycCHtXAQxBKR4jOMu8Q ymMWSLH3a3WhQfqyrElo/3kC1QUgmaZHkv0vZYg2CQzLxXJQjcbuMvPMCqH4RndfkK2f pVQ9K/LjCohMW2YLlANC4CnHx3D4TFlekbFgmhdr5A4++Nw5Ve9ekTwmoAPe0pJsiSVv JzJQ== X-Gm-Message-State: AOAM53295Iv4/b1PK4JSAJwTHBXZ6vUzvB+qAQ63QsGBTaG23ASvPbr4 EaHNLoN1vZ9azTBqeDwECM8UVhOXbkO+hev7JLTG1Q== X-Google-Smtp-Source: ABdhPJzONErocQTM6UBI9xgygiMFG+6LJh/aYtS2MMC9Nh1R3w1lMgZJiW5EEy6obcmDBWqWnhlEZCPdEyU+d5YzaXY= X-Received: by 2002:a2e:b52a:: with SMTP id z10mr11529706ljm.320.1614689138461; Tue, 02 Mar 2021 04:45:38 -0800 (PST) MIME-Version: 1.0 References: <20210301051952.29091-1-masahisa.kojima@linaro.org> <20210301051952.29091-2-masahisa.kojima@linaro.org> <20210301170507.GT1664@vanye> In-Reply-To: <20210301170507.GT1664@vanye> From: "Masahisa Kojima" Date: Tue, 2 Mar 2021 21:45:26 +0900 Message-ID: Subject: Re: [PATCH edk2-platforms v2 1/4] SbsaQemu: Build infrastructure for StandaloneMm image To: Leif Lindholm Cc: edk2-devel-groups-io , Ard Biesheuvel , Graeme Gregory , Radoslaw Biernacki , Shashi Mallela Content-Type: text/plain; charset="UTF-8" Hi Leif, Thank you for you comments. On Tue, 2 Mar 2021 at 02:05, Leif Lindholm wrote: > > On Mon, Mar 01, 2021 at 14:19:49 +0900, Masahisa Kojima wrote: > > Add the build infrastructure for compilation of StandaloneMm image. > > > > Signed-off-by: Masahisa Kojima > > --- > > .../Qemu/SbsaQemu/SbsaQemuStandaloneMm.dsc | 132 ++++++++++++++++++ > > Please use --stat=1000 --stat-graph-width=20 when generating patches. Sorry I forgot to add these options, will be included in the next version. > > > Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 6 +- > > It is not immediately obvious to me why the pre-existing > SbsaQemuStandaloneMm.dsc needs to change. Is this something that can > be clarified in commit message? I probably does not understand your comment correctly, but SbsaQemuStandaloneMm.dsc is newly created file with this commit. Thanks, Masahisa > > Best Regards, > > Leif > > > .../Qemu/SbsaQemu/SbsaQemuStandaloneMm.fdf | 93 ++++++++++++ > > 3 files changed, 228 insertions(+), 3 deletions(-) > > create mode 100644 Platform/Qemu/SbsaQemu/SbsaQemuStandaloneMm.dsc > > create mode 100644 Platform/Qemu/SbsaQemu/SbsaQemuStandaloneMm.fdf > > > > diff --git a/Platform/Qemu/SbsaQemu/SbsaQemuStandaloneMm.dsc b/Platform/Qemu/SbsaQemu/SbsaQemuStandaloneMm.dsc > > new file mode 100644 > > index 000000000000..87f5ee351eaa > > --- /dev/null > > +++ b/Platform/Qemu/SbsaQemu/SbsaQemuStandaloneMm.dsc > > @@ -0,0 +1,132 @@ > > +# > > +# Copyright (c) 2020, Linaro Limited. All rights reserved. > > +# > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > +# > > + > > +################################################################################ > > +# > > +# Defines Section - statements that will be processed to create a Makefile. > > +# > > +################################################################################ > > +[Defines] > > + PLATFORM_NAME = SbsaQemuStandaloneMm > > + PLATFORM_GUID = A64CC0F5-7ACD-4975-BBE7-7EF6739C8668 > > + PLATFORM_VERSION = 1.0 > > + DSC_SPECIFICATION = 0x00010011 > > + OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME) > > + SUPPORTED_ARCHITECTURES = AARCH64 > > + BUILD_TARGETS = DEBUG|RELEASE|NOOPT > > + SKUID_IDENTIFIER = DEFAULT > > + FLASH_DEFINITION = Platform/Qemu/SbsaQemu/SbsaQemuStandaloneMm.fdf > > + DEFINE DEBUG_MESSAGE = TRUE > > + > > + # LzmaF86 > > + DEFINE COMPRESSION_TOOL_GUID = D42AE6BD-1352-4bfb-909A-CA72A6EAE889 > > + > > +################################################################################ > > +# > > +# Library Class section - list of all Library Classes needed by this Platform. > > +# > > +################################################################################ > > +[LibraryClasses] > > + # > > + # Basic > > + # > > + BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > > + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > > + DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > + DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > > + ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf > > + FvLib|StandaloneMmPkg/Library/FvLib/FvLib.inf > > + HobLib|StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf > > + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > > + MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf > > + MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf > > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > + PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > > + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > > + ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf > > + > > + # > > + # Entry point > > + # > > + StandaloneMmDriverEntryPoint|MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf > > + > > + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > > + StandaloneMmMmuLib|ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf > > + ArmSvcLib|ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf > > + CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf > > + PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf > > + > > + # ARM PL011 UART Driver > > + PL011UartClockLib|ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.inf > > + PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf > > + SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf > > + > > + StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf > > + > > + # > > + # It is not possible to prevent the ARM compiler for generic intrinsic functions. > > + # This library provides the instrinsic functions generate by a given compiler. > > + # And NULL mean link this library into all ARM images. > > + # > > + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > + > > +[LibraryClasses.common.MM_STANDALONE] > > + HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf > > + MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.inf > > + MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAllocationLib/StandaloneMmMemoryAllocationLib.inf > > + > > +################################################################################ > > +# > > +# Pcd Section - list of all EDK II PCD Entries defined by this Platform > > +# > > +################################################################################ > > +[PcdsFixedAtBuild] > > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x800000CF > > + gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xff > > + gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x0f > > + > > + ## PL011 - Serial Terminal > > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x60040000 > > + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200 > > + > > + gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x2 > > + > > +################################################################################################### > > +# > > +# Components Section - list of the modules and components that will be processed by compilation > > +# tools and the EDK II tools to generate PE32/PE32+/Coff image files. > > +# > > +# Note: The EDK II DSC file is not used to specify how compiled binary images get placed > > +# into firmware volume images. This section is just a list of modules to compile from > > +# source into UEFI-compliant binaries. > > +# It is the FDF file that contains information on combining binary files into firmware > > +# volume images, whose concept is beyond UEFI and is described in PI specification. > > +# Binary modules do not need to be listed in this section, as they should be > > +# specified in the FDF file. For example: Shell binary (Shell_Full.efi), FAT binary (Fat.efi), > > +# Logo (Logo.bmp), and etc. > > +# There may also be modules listed in this section that are not required in the FDF file, > > +# When a module listed here is excluded from FDF file, then UEFI-compliant binary will be > > +# generated for it, but the binary will not be put into any firmware volume. > > +# > > +################################################################################################### > > +[Components.common] > > + # > > + # MM Core > > + # > > + StandaloneMmPkg/Core/StandaloneMmCore.inf > > + StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > > + > > +################################################################################################### > > +# > > +# BuildOptions Section - Define the module specific tool chain flags that should be used as > > +# the default flags for a module. These flags are appended to any > > +# standard flags that are defined by the build process. They can be > > +# applied for any modules or only those modules with the specific > > +# module style (EDK or EDKII) specified in [Components] section. > > +# > > +################################################################################################### > > +[BuildOptions.AARCH64] > > + GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp > > diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf > > index c35e3ed44054..b61ae1891233 100644 > > --- a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf > > +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf > > @@ -21,10 +21,10 @@ > > > > [FD.SBSA_FLASH0] > > BaseAddress = 0x00000000 > > -Size = 0x00200000 > > +Size = 0x00400000 > > ErasePolarity = 1 > > BlockSize = 0x00001000 > > -NumBlocks = 0x200 > > +NumBlocks = 0x400 > > > > ################################################################################ > > # > > @@ -47,7 +47,7 @@ [FD.SBSA_FLASH0] > > FILE = Platform/Qemu/Sbsa/bl1.bin > > > > # and FIP (BL2 + BL31) > > -0x00008000|0x00020000 > > +0x00008000|0x00300000 > > FILE = Platform/Qemu/Sbsa/fip.bin > > > > ################################################################################ > > diff --git a/Platform/Qemu/SbsaQemu/SbsaQemuStandaloneMm.fdf b/Platform/Qemu/SbsaQemu/SbsaQemuStandaloneMm.fdf > > new file mode 100644 > > index 000000000000..a1acefcfb0a7 > > --- /dev/null > > +++ b/Platform/Qemu/SbsaQemu/SbsaQemuStandaloneMm.fdf > > @@ -0,0 +1,93 @@ > > +# > > +# Copyright (c) 2020, Linaro Limited. All rights reserved. > > +# > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > +# > > + > > +################################################################################ > > +# > > +# FD Section > > +# The [FD] Section is made up of the definition statements and a > > +# description of what goes into the Flash Device Image. Each FD section > > +# defines one flash "device" image. A flash device image may be one of > > +# the following: Removable media bootable image (like a boot floppy > > +# image,) an Option ROM image (that would be "flashed" into an add-in > > +# card,) a System "Flash" image (that would be burned into a system's > > +# flash) or an Update ("Capsule") image that will be used to update and > > +# existing system flash. > > +# > > +################################################################################ > > + > > +[FD.STANDALONE_MM] > > +BaseAddress = 0x20001000|gArmTokenSpaceGuid.PcdFdBaseAddress > > +Size = 0x00e00000|gArmTokenSpaceGuid.PcdFdSize # The size in bytes of the device (14MiB). > > +ErasePolarity = 1 > > + > > +BlockSize = 0x00001000 > > +NumBlocks = 0x0e00 > > + > > +0x00000000|0x00280000 > > +gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > > +FV = FVMAIN_COMPACT > > + > > +[FV.FVMAIN_COMPACT] > > +FvAlignment = 16 > > +ERASE_POLARITY = 1 > > +MEMORY_MAPPED = TRUE > > +STICKY_WRITE = TRUE > > +LOCK_CAP = TRUE > > +LOCK_STATUS = TRUE > > +WRITE_DISABLED_CAP = TRUE > > +WRITE_ENABLED_CAP = TRUE > > +WRITE_STATUS = TRUE > > +WRITE_LOCK_CAP = TRUE > > +WRITE_LOCK_STATUS = TRUE > > +READ_DISABLED_CAP = TRUE > > +READ_ENABLED_CAP = TRUE > > +READ_STATUS = TRUE > > +READ_LOCK_CAP = TRUE > > +READ_LOCK_STATUS = TRUE > > + > > + INF StandaloneMmPkg/Core/StandaloneMmCore.inf > > + INF StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > > + > > +################################################################################ > > +# > > +# Rules are use with the [FV] section's module INF type to define > > +# how an FFS file is created for a given INF file. The following Rule are the default > > +# rules for the different module type. User can add the customized rules to define the > > +# content of the FFS file. > > +# > > +################################################################################ > > + > > + > > +############################################################################ > > +# Example of a DXE_DRIVER FFS file with a Checksum encapsulation section # > > +############################################################################ > > +# > > +#[Rule.Common.DXE_DRIVER] > > +# FILE DRIVER = $(NAMED_GUID) { > > +# DXE_DEPEX DXE_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > > +# COMPRESS PI_STD { > > +# GUIDED { > > +# PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > > +# UI STRING="$(MODULE_NAME)" Optional > > +# VERSION STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER) > > +# } > > +# } > > +# } > > +# > > +############################################################################ > > + > > +[Rule.Common.MM_CORE_STANDALONE] > > + FILE SEC = $(NAMED_GUID) RELOCS_STRIPPED FIXED { > > + PE32 PE32 Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi > > + } > > + > > +[Rule.Common.MM_STANDALONE] > > + FILE MM_STANDALONE = $(NAMED_GUID) { > > + SMM_DEPEX SMM_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > > + PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > > + UI STRING="$(MODULE_NAME)" Optional > > + VERSION STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER) > > + } > > -- > > 2.17.1 > >