From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=chandni.cherukuri@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id C81CB20968910 for ; Sun, 17 Jun 2018 22:43:26 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D86115B2 for ; Sun, 17 Jun 2018 22:43:26 -0700 (PDT) Received: from mail-oi0-f54.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 564E43F7DB for ; Sun, 17 Jun 2018 22:43:26 -0700 (PDT) Received: by mail-oi0-f54.google.com with SMTP id h79-v6so13732155oig.13 for ; Sun, 17 Jun 2018 22:43:26 -0700 (PDT) X-Gm-Message-State: APt69E2ffrvQaV3Ym28aUwK+Ry/ibmKpBLzT6ivu8ZNrbV3waLl9flqD FAm9YN6/fwnqd+9RF9ZvE0I1bSm3oq7FirknLWE= X-Google-Smtp-Source: ADUXVKKNIs0FUF7kJAl0IvKdr1qDzpiCk2T5Yt2Rtqq0CMCmHN3E/0xdcGZaZLBNt4RTC6DM5oE7OgqGCACVtUTBRD4= X-Received: by 2002:aca:4f92:: with SMTP id d140-v6mr6567161oib.169.1529300605589; Sun, 17 Jun 2018 22:43:25 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:e2c:0:0:0:0:0 with HTTP; Sun, 17 Jun 2018 22:43:25 -0700 (PDT) In-Reply-To: <20180615124033.lf7jp67jmr2xkhml@bivouac.eciton.net> References: <1529064002-18779-1-git-send-email-chandni.cherukuri@arm.com> <20180615124033.lf7jp67jmr2xkhml@bivouac.eciton.net> From: chandni cherukuri Date: Mon, 18 Jun 2018 11:13:25 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Leif Lindholm Cc: Chandni Cherukuri , edk2-devel@lists.01.org, Ard Biesheuvel Subject: Re: [PATCH edk2-platforms v2 0/2] ARM Dynamic Configuration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 05:43:27 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, Jun 15, 2018 at 6:10 PM, Leif Lindholm wrote: > On Fri, Jun 15, 2018 at 05:30:00PM +0530, Chandni Cherukuri wrote: >> On SGI platforms, the trusted firmware executes prior to the SEC >> phase. It supplies to the SEC phase, a pointer to a HW CONFIG fdt >> in the x1 which contains platform specific information such as part >> number and config number of the SGI platform. >> >> The HW CONFIG FDT would look as, >> /dts-v1/; >> / { >> /* compatible string */ >> compatible = "arm,sgi-isys3"; >> >> /* platform ID node */ >> system-id { >> platform-id = <0x03000783>; >> } >> }; >> >> In the very first step of the assembly code which executes in SEC phase >> the fdt pointer is stored in a global variable from the register. A PPI >> is created during the SEC phase which stores the global variable. >> >> During PEI phase, a Platform ID PEIM is installed which accessess the PPI >> and retrieves the platform information using FDT helper functions and a >> PlatformId HOB is created and populated with the information. >> >> During DXE phase the drivers can access the Platform ID HOB to get the >> platform information and perform platform specific functions based on the >> platform. > > It's helpful for subsequent revisions to keep a revision history in > cover letter. > > Changes since v1: > - ... > - ... > - ... > > Kept around and added to for subsequent revisions. > > However, you've addressed all of my comments on v1, so for my part - > for the series: > Reviewed-by: Leif Lindholm > > But we want to hear back from Ard as well. > > / > Leif Thanks Leif for reviewing the patches. Have addressed the comments from Ard and submitted v3 patchset and included "Changes since v1:" in the cover letter. > >> Chandni Cherukuri (2): >> Platform/ARM/Sgi: Install a Platform ID HOB >> Platform/ARM/Sgi: Pick ACPI tables to install based on platform ID >> >> Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 33 +++++- >> Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 2 + >> Platform/ARM/SgiPkg/Include/Ppi/SgiPlatformId.h | 23 ++++ >> Platform/ARM/SgiPkg/Include/SgiPlatform.h | 13 +++ >> Platform/ARM/SgiPkg/Library/PlatformLib/AArch64/Helper.S | 13 ++- >> Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c | 10 ++ >> Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf | 3 + >> Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPei.inf | 40 +++++++ >> Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 112 ++++++++++++++++++++ >> Platform/ARM/SgiPkg/SgiPlatform.dec | 5 + >> Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 + >> Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 + >> 12 files changed, 247 insertions(+), 9 deletions(-) >> create mode 100644 Platform/ARM/SgiPkg/Include/Ppi/SgiPlatformId.h >> create mode 100644 Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPei.inf >> create mode 100644 Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c >> >> -- >> 2.7.4 >> >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel