From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=chandni.cherukuri@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 01C31207E4E0B for ; Mon, 18 Jun 2018 03:51:26 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CAE2F80D for ; Mon, 18 Jun 2018 03:51:26 -0700 (PDT) Received: from mail-ot0-f182.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B26D83F25D for ; Mon, 18 Jun 2018 03:51:26 -0700 (PDT) Received: by mail-ot0-f182.google.com with SMTP id a5-v6so17922232otf.12 for ; Mon, 18 Jun 2018 03:51:26 -0700 (PDT) X-Gm-Message-State: APt69E3zRZC5G7TOkpv7r2KEiCeFIV8/dyNetZ1KiNqZDwVTO5Roob1L g2g5SDtbBJMy6mXACR5PY1LmZ5SEshxUEaLIwQ8= X-Google-Smtp-Source: ADUXVKI7HYIYW62gbxQ9nW/vJu2XomuPI37C9Ua6zmTjRqMCTOeSA8Xnc45PhDY0BxrKV9yfgi946DH4dNtF4A6AgOE= X-Received: by 2002:a9d:1bcb:: with SMTP id v11-v6mr6989967otv.344.1529319086101; Mon, 18 Jun 2018 03:51:26 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:e2c:0:0:0:0:0 with HTTP; Mon, 18 Jun 2018 03:51:25 -0700 (PDT) In-Reply-To: References: <1529299741-30054-1-git-send-email-chandni.cherukuri@arm.com> From: chandni cherukuri Date: Mon, 18 Jun 2018 16:21:25 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Ard Biesheuvel Cc: Chandni Cherukuri , "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH edk2-platforms v3 0/2] Platform/ARM/Sgi: Enable Dynamic Configuration feature X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 10:51:27 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, Jun 18, 2018 at 3:14 PM, Ard Biesheuvel wrote: > On 18 June 2018 at 07:28, Chandni Cherukuri wrote: >> Changes since v2: >> - Addressed comments from Ard >> - Depex on gHwConfigDtInfoPpiGuid >> - Use address of DT instead of pointer to the address of DT >> >> Changes since v1: >> - Addressed comments from Ard and Leif >> - move definition of HwConfigDtBlob to PlatformLib.c >> - use adr instead of ldr assembly instruction >> - declare PPI in a PPI specific header file >> - invert if conditional expression >> - remove changes unrelated to the patch >> - rename PEI files as per the standard >> >> On SGI platforms, the trusted firmware executes prior to the SEC >> phase. It supplies to the SEC phase, a pointer to a HW CONFIG fdt >> in the x1 which contains platform specific information such as part >> number and config number of the SGI platform. >> >> The HW CONFIG FDT would look as, >> /dts-v1/; >> / { >> /* compatible string */ >> compatible = "arm,sgi-isys3"; >> >> /* platform ID node */ >> system-id { >> platform-id = <0x03000783>; >> } >> }; >> >> In the very first step of the assembly code which executes in SEC phase >> the fdt pointer is stored in a global variable from the register. A PPI >> is created during the SEC phase which stores the global variable. >> >> During PEI phase, a Platform ID PEIM is installed which accessess the PPI >> and retrieves the platform information using FDT helper functions and a >> PlatformId HOB is created and populated with the information. >> >> During DXE phase the drivers can access the Platform ID HOB to get the >> platform information and perform platform specific functions based on the >> platform. >> >> Chandni Cherukuri (2): >> Platform/ARM/Sgi: Install a Platform ID HOB >> Platform/ARM/Sgi: Pick ACPI tables to install based on platform ID >> > > Reviewed-by: Ard Biesheuvel > > Pushed as f65939a9d98b..e93b4c776420 > > I did notice that there is a typo in the identifier 'gSgi575AcpiTablesiFileGuid' > Could you please send a patch to fix up all occurrences? > > Thanks, > Ard. > Thanks Ard for reviewing the patches. The typo has been fixed and a patch has been sent for your review. Thanks, Chandni > >> Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 30 +++++- >> Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 2 + >> Platform/ARM/SgiPkg/Include/Ppi/SgiPlatformId.h | 23 ++++ >> Platform/ARM/SgiPkg/Include/SgiPlatform.h | 13 +++ >> Platform/ARM/SgiPkg/Library/PlatformLib/AArch64/Helper.S | 13 ++- >> Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c | 10 ++ >> Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf | 3 + >> Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPei.inf | 40 +++++++ >> Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 112 ++++++++++++++++++++ >> Platform/ARM/SgiPkg/SgiPlatform.dec | 5 + >> Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 + >> Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 + >> 12 files changed, 245 insertions(+), 8 deletions(-) >> create mode 100644 Platform/ARM/SgiPkg/Include/Ppi/SgiPlatformId.h >> create mode 100644 Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPei.inf >> create mode 100644 Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c >> >> -- >> 2.7.4 >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel