Hi Sughosh,

I have completed reviewing this patch series.

Please add some description in the commit message for the following patches. Otherwise patch 3 & 8 look good to me.
[PATCH v1 08/12] StandaloneMmPkg: Use FF-A header file in Standalone MM Arm MMU library
[PATCH v1 03/12] StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry point

Regards,

Sami Mujawar

-----Original Message-----
From: Sughosh Ganu <sughosh.ganu@linaro.org>
Sent: 21 October 2020 12:32 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; Jiewen Yao <jiewen.yao@intel.com>
Subject: [PATCH v1 00/12] Add support for using FF-A calls

Achin Gupta (8):
  ArmPkg/IndustryStandard: Add barebones FF-A header
  ArmPkg/ArmSvcLib: Return x4-x7 in output parameters
  StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry
    point
  StandaloneMmPkg: Add option to use FF-A calls for getting SPM version
  StandaloneMmPkg: Add option to use FF-A calls for communication with
    SPM
  StandaloneMmPkg: Use FF-A header file in Standalone MM Arm MMU library
  ArmPkg/StandaloneMmMmuLib: Add option to use FF-A calls to get memory
    region's permissions
  ArmPkg/StandaloneMmMmuLib: Add option to use FF-A calls to set memory
    region's permissions

Ilias Apalodimas (2):
  MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase
    to Pcd
  StandaloneMmPkg: Allow sending FFA Direct Request message to
    StandaloneMm

Sughosh Ganu (1):
  ArmPkg: Introduce support for PcdFfaEnable

Sughossh Ganu (1):
  StandaloneMmPkg: Add the SPM version for FF-A

 ArmPkg/ArmPkg.dec                             |   3 +
 .../ArmMmuStandaloneMmLib.inf                 |   3 +
 .../RuntimeDxe/VariableStandaloneMm.inf       |   6 +-
 .../StandaloneMmCoreEntryPoint.inf            |   3 +
 ArmPkg/Include/IndustryStandard/ArmFfaSvc.h   |  16 +++
 .../AArch64/ArmMmuStandaloneMmLib.c           |  53 +++++++--
 .../StandaloneMmCpu/AArch64/EventHandle.c     |   4 +-
 .../AArch64/StandaloneMmCoreEntryPoint.c      | 103 ++++++++++++++----
 ArmPkg/Library/ArmSvcLib/AArch64/ArmSvc.S     |   2 +
 9 files changed, 155 insertions(+), 38 deletions(-)
 create mode 100644 ArmPkg/Include/IndustryStandard/ArmFfaSvc.h

--
2.17.1