From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by mx.groups.io with SMTP id smtpd.web09.49156.1606204142720283744 for ; Mon, 23 Nov 2020 23:49:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Ct9wsIWs; spf=pass (domain: linaro.org, ip: 209.85.166.50, mailfrom: sughosh.ganu@linaro.org) Received: by mail-io1-f50.google.com with SMTP id t8so20916215iov.8 for ; Mon, 23 Nov 2020 23:49:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3YhC6k9PCQDItPXJzdpkG4pTqIBhA+yqwm5j1dlfkXU=; b=Ct9wsIWs6aqGIwe1tjozST5F1Pgy/jPyoKqZl6L5XSIUT6MutPJnJRIbb1B2xGRT27 5YSwDP/1p2Y0KesIOTJimMFXvXBKOcxUzgv/PgLgV4WfYtYf8TZJ9jdNyHX8jE7zQGA7 14M4OzYDXSgKV6Sdsn6whYRkYZ8WN6gq3HKoqTfY5By9fofweHbtbmH2Bxoaqe8hoSdD +TL0XuSpxiACD1xsOolf/QsWdRBosAW/4Mw3qwCiD+YGa8fR8uIhsN3tOZnoupFrho0I zb1Cn2FAjTi8pMo1h4HsYC2NdgTwDtbLgI+ZyYff2XO7kAsSrPiyCv81FY4kr7G/gS8H vyqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3YhC6k9PCQDItPXJzdpkG4pTqIBhA+yqwm5j1dlfkXU=; b=rpI5vDfoAwnjTxzezT0ZpC9bS3fLc+cIZsPHxwck7crku0b5QZ379Cx2mrBq1pXPl0 EMbtNyDruob1OwxT6P/5OoFgoGq4/B5QDHFuHquJ+c0zzjdQnPAqdW2P4jVoz1iIBzV2 0BWAO7Nftr4HLkC9i1kDMFINLpal27q5vGipFNh3YsPpUtZXptdOW4vXt1fQI4bj3fYC ypAN0ZSrdoZnSh7D+EckVDkmhS6dKBvo1nSNz7LVMzXnarjuUfKnyGEbiqfJLM6q1dsC w7fne2Yn2GivQA9CNURcqXUEm9QjjK836rqVHwrVlh/IU6T2BA5NR/Ygfag5DW0gksdm iopQ== X-Gm-Message-State: AOAM531aOA1njpxz4T10JJFXfVtusXQgdAtf54yyE+o1XqWHAuKOk8P+ Fg7FqavWfbXvvayvCyz1V5bF1EALNAbqAtOPy7ALvw== X-Google-Smtp-Source: ABdhPJwN0u7PjMrSRyrynwr7OtMbZLsYhpPYYqe1lWOYukDeOWq8qaLxEAbIduuRMZHUZcRm0epw2dh+jr1aLEu7gF8= X-Received: by 2002:a6b:b3d6:: with SMTP id c205mr3113564iof.68.1606204142121; Mon, 23 Nov 2020 23:49:02 -0800 (PST) MIME-Version: 1.0 References: <20201021113233.25548-1-sughosh.ganu@linaro.org> In-Reply-To: From: "Sughosh Ganu" Date: Tue, 24 Nov 2020 13:18:51 +0530 Message-ID: Subject: Re: [PATCH v1 00/12] Add support for using FF-A calls To: Sami Mujawar Cc: "devel@edk2.groups.io" , Ard Biesheuvel , Jiewen Yao , nd Content-Type: multipart/alternative; boundary="00000000000054087005b4d58b0f" --00000000000054087005b4d58b0f Content-Type: text/plain; charset="UTF-8" hi Sami, On Mon, 23 Nov 2020 at 20:03, Sami Mujawar wrote: > Hi Sughosh, > > I have completed reviewing this patch series. > > Please add some description in the commit message for the following > patches. Otherwise patch 3 & 8 look good to me. > [PATCH v1 08/12] StandaloneMmPkg: Use FF-A header file in Standalone MM > Arm MMU library > [PATCH v1 03/12] StandaloneMmPkg: Use FF-A header file in Standalone MM > Core entry point > Thanks a lot for reviewing the patches. I will incorporate your review comments on all the patches, and send a V2. -sughosh > > Regards, > > Sami Mujawar > > -----Original Message----- > From: Sughosh Ganu > Sent: 21 October 2020 12:32 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Sami Mujawar < > Sami.Mujawar@arm.com>; Jiewen Yao > Subject: [PATCH v1 00/12] Add support for using FF-A calls > > Achin Gupta (8): > ArmPkg/IndustryStandard: Add barebones FF-A header > ArmPkg/ArmSvcLib: Return x4-x7 in output parameters > StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry > point > StandaloneMmPkg: Add option to use FF-A calls for getting SPM version > StandaloneMmPkg: Add option to use FF-A calls for communication with > SPM > StandaloneMmPkg: Use FF-A header file in Standalone MM Arm MMU library > ArmPkg/StandaloneMmMmuLib: Add option to use FF-A calls to get memory > region's permissions > ArmPkg/StandaloneMmMmuLib: Add option to use FF-A calls to set memory > region's permissions > > Ilias Apalodimas (2): > MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase > to Pcd > StandaloneMmPkg: Allow sending FFA Direct Request message to > StandaloneMm > > Sughosh Ganu (1): > ArmPkg: Introduce support for PcdFfaEnable > > Sughossh Ganu (1): > StandaloneMmPkg: Add the SPM version for FF-A > > ArmPkg/ArmPkg.dec | 3 + > .../ArmMmuStandaloneMmLib.inf | 3 + > .../RuntimeDxe/VariableStandaloneMm.inf | 6 +- > .../StandaloneMmCoreEntryPoint.inf | 3 + > ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 16 +++ > .../AArch64/ArmMmuStandaloneMmLib.c | 53 +++++++-- > .../StandaloneMmCpu/AArch64/EventHandle.c | 4 +- > .../AArch64/StandaloneMmCoreEntryPoint.c | 103 ++++++++++++++---- > ArmPkg/Library/ArmSvcLib/AArch64/ArmSvc.S | 2 + > 9 files changed, 155 insertions(+), 38 deletions(-) > create mode 100644 ArmPkg/Include/IndustryStandard/ArmFfaSvc.h > > -- > 2.17.1 > > > --00000000000054087005b4d58b0f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
hi Sami,

On Mon, 23 Nov 2020 at 20:03, Sami Mujawar &l= t;Sami.Mujawar@arm.com> wrot= e:
Hi Sughosh,
I have completed reviewing this patch series.

Please add some description in the commit message for the following patches= . Otherwise patch 3 & 8 look good to me.
[PATCH v1 08/12] StandaloneMmPkg: Use FF-A header file in Standalone MM Arm= MMU library
[PATCH v1 03/12] StandaloneMmPkg: Use FF-A header file in Standalone MM Cor= e entry point

Thanks a lot for reviewin= g the patches. I will incorporate your review comments on all the patches, = and send a V2.

-sughosh
=C2=A0

Regards,

Sami Mujawar

-----Original Message-----
From: Sughosh Ganu <sughosh.ganu@linaro.org>
Sent: 21 October 2020 12:32 PM
To: devel@edk2.gr= oups.io
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; Jiewe= n Yao <jiewen.= yao@intel.com>
Subject: [PATCH v1 00/12] Add support for using FF-A calls

Achin Gupta (8):
=C2=A0 ArmPkg/IndustryStandard: Add barebones FF-A header
=C2=A0 ArmPkg/ArmSvcLib: Return x4-x7 in output parameters
=C2=A0 StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry =C2=A0 =C2=A0 point
=C2=A0 StandaloneMmPkg: Add option to use FF-A calls for getting SPM versio= n
=C2=A0 StandaloneMmPkg: Add option to use FF-A calls for communication with=
=C2=A0 =C2=A0 SPM
=C2=A0 StandaloneMmPkg: Use FF-A header file in Standalone MM Arm MMU libra= ry
=C2=A0 ArmPkg/StandaloneMmMmuLib: Add option to use FF-A calls to get memor= y
=C2=A0 =C2=A0 region's permissions
=C2=A0 ArmPkg/StandaloneMmMmuLib: Add option to use FF-A calls to set memor= y
=C2=A0 =C2=A0 region's permissions

Ilias Apalodimas (2):
=C2=A0 MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase=
=C2=A0 =C2=A0 to Pcd
=C2=A0 StandaloneMmPkg: Allow sending FFA Direct Request message to
=C2=A0 =C2=A0 StandaloneMm

Sughosh Ganu (1):
=C2=A0 ArmPkg: Introduce support for PcdFfaEnable

Sughossh Ganu (1):
=C2=A0 StandaloneMmPkg: Add the SPM version for FF-A

=C2=A0ArmPkg/ArmPkg.dec=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A03 +
=C2=A0.../ArmMmuStandaloneMmLib.inf=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A03 +
=C2=A0.../RuntimeDxe/VariableStandaloneMm.inf=C2=A0 =C2=A0 =C2=A0 =C2=A0|= =C2=A0 =C2=A06 +-
=C2=A0.../StandaloneMmCoreEntryPoint.inf=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 |=C2=A0 =C2=A03 +
=C2=A0ArmPkg/Include/IndustryStandard/ArmFfaSvc.h=C2=A0 =C2=A0|=C2=A0 16 ++= +
=C2=A0.../AArch64/ArmMmuStandaloneMmLib.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0|=C2=A0 53 +++++++--
=C2=A0.../StandaloneMmCpu/AArch64/EventHandle.c=C2=A0 =C2=A0 =C2=A0|=C2=A0 = =C2=A04 +-
=C2=A0.../AArch64/StandaloneMmCoreEntryPoint.c=C2=A0 =C2=A0 =C2=A0 | 103 ++= ++++++++++++----
=C2=A0ArmPkg/Library/ArmSvcLib/AArch64/ArmSvc.S=C2=A0 =C2=A0 =C2=A0|=C2=A0 = =C2=A02 +
=C2=A09 files changed, 155 insertions(+), 38 deletions(-)
=C2=A0create mode 100644 ArmPkg/Include/IndustryStandard/ArmFfaSvc.h

--
2.17.1


--00000000000054087005b4d58b0f--