From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by mx.groups.io with SMTP id smtpd.web11.36011.1614007169501367672 for ; Mon, 22 Feb 2021 07:19:29 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=YV4dY5fk; spf=pass (domain: linaro.org, ip: 209.85.166.51, mailfrom: sughosh.ganu@linaro.org) Received: by mail-io1-f51.google.com with SMTP id d15so5368100ioe.4 for ; Mon, 22 Feb 2021 07:19:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1vMNi6yOadLVUotbdJJqgpzxqj2JaAEw+BzZYSdYqls=; b=YV4dY5fkNEixnAj9qfjymGFr2ny2JnjTUd1a7/+56GEybLQKjsQzzIFEOmXKJiAEdA 57BIaUaqhHRdQewCUO46a6nlKQPfZJUJHtpmI0ZopMtjJ+USYuf+o+WV3ArpkZNiHKk8 o3Hus5B0nDxgtPZToeloBsg3rfrfzHoRL3COE7BMscEm/gdHnHvgGXJn1Kw7TaFIhE9z xsmC5ye4wh2aFIfCdSv4delnnFImLCS2XKfkWEyhTsLC08i/sNhAkDJN9rlEQyal9nDR 4rdjtcsgAoMhxebZ5vvJ9P2fa4MWW/U17LEGgc8UGvuhe+mysZ96ZLEBeV5GhM8h45Dk L11g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1vMNi6yOadLVUotbdJJqgpzxqj2JaAEw+BzZYSdYqls=; b=bl1BFzo5e3Xjb2yUSwUtlNXbv5btu3LOkaqwYxTZJJhPcmHBbQ7Tc/DLrL9gSZOv+X MdSmjRnbsz/BqTQoWwrqjQrMGVbuWT29wOhwf+9hs94hfPwGhzfQpBShvq0QCxKQb0HW GkGGTIYq46+f0Hn7YN9duBHPN+myVKGhtckzmarcAwaBfht1hm4XMbMepMTZFejBj0Au sj3G+eoEako1BDjCrnxx+5Hfap62LYh00OP0No9BZY44kUy9URKiI4g4G4ofkc/v137D bf5QIGjAG6KqFlXGUXz2VLUB3fiZghg5VVPhJGuHLAOKT0qEqFGKPROpEz1c7+gs3EqC Jxzg== X-Gm-Message-State: AOAM530nJe6M03EwSaOY5vfG2HyEfMbAq/c92Q1pmggGVJttZbmjt7G3 inenV19a1S3BLOcDq3uucBI+GTycN2nenvpvVgOKZA== X-Google-Smtp-Source: ABdhPJyVQSlhC0xiEex3BfCXJhGwqB4SS8SZ/BVJKx4PHhBZUZKQ5WjWtEo6dBa2GfImeNN/GFE1qPMa7Di9iaDeX1w= X-Received: by 2002:a05:6638:eca:: with SMTP id q10mr13869374jas.116.1614007168678; Mon, 22 Feb 2021 07:19:28 -0800 (PST) MIME-Version: 1.0 References: <20210219063607.27920-1-sughosh.ganu@linaro.org> In-Reply-To: From: "Sughosh Ganu" Date: Mon, 22 Feb 2021 20:49:17 +0530 Message-ID: Subject: Re: [PATCH v5 00/14] Add support for using FF-A calls To: Ard Biesheuvel , Sami Mujawar Cc: devel@edk2.groups.io, Ilias Apalodimas , Laszlo Ersek , Leif Lindholm , michael.d.kinney@intel.com, Jiewen Yao , Achin Gupta Content-Type: multipart/alternative; boundary="000000000000f454a205bbee5384" --000000000000f454a205bbee5384 Content-Type: text/plain; charset="UTF-8" hi Sami, On Mon, 22 Feb 2021 at 19:40, Ard Biesheuvel wrote: > On Fri, 19 Feb 2021 at 07:36, Sughosh Ganu > wrote: > > > > The following patch series adds support for using the Firmware > > Framework(FF-A) as a transport mechanism for requesting services from > > the Secure Partition Manager(SPM). This is done through a Pcd which > > can be used to enable the FF-A mechanism or to use the earlier used > > SVC calls. > > > > The patches have been pushed to my github repository[1] > > > > Ran the CI tests through the github draft pull request, and all the CI > > test pass. Ran the PatchCheck script, with no errors. > > > > Changes since V4: > > * Define all variable Pcd's under the [Pcd] section instead of > > [FixedPcd], as suggested by Liming Gao > > > > Changes since V3: > > * Put the PcdFfaEnable under the PcdsFeatureFlag.AARCH64 section to > > avoid build breakage for the X64 StandaloneMm builds. > > * Put the macro definitions for the SPM major and minor versions in a > > separate patch, as suggested by Sami. > > * Separated out the declaration of the SPM major and minor version > > macros in the earlier patch as was suggested by Sami. > > * Put the macro definitions for the SPM major and minor versions with > > FF-A support in a separate patch, as suggested by Sami. > > * Declare the PcdFfaEnable Pcd Feature flag under FeaturePcd.AARCH64 > > to avoid build break for the X64 build of StandaloneMm. > > * Change the patch header to have the ArmPkg prefix instead of > > StandaloneMmMmuLib as suggested by Sami. > > > > Changes since V2: > > * Added a STATIC storage class specifier for mSpmMajorVer and > > mSpmMinorVer variables > > * Added a STATIC storage class specifier for mSpmMajorVerFfa and > > mSpmMinorVerFfa variables > > * Add braces for if/else statements > > * Add a check for EFI_NOT_FOUND as a possible return value from > > LocateStandaloneMmCorePeCoffData in _ModuleEntryPoint function > > * Check for the return value in Arg0 after the Direct Request call to > > handle errors returned > > * Put a comment to reflect the fact that FFA_INTERRUPT and FFA_SUCCESS > > response won't be expected in return to a Direct Request call to get > > the memory attributes > > * Check for the return value in Arg0 after the Direct Request call to > > handle errors returned > > * Put a comment to reflect the fact that FFA_INTERRUPT and FFA_SUCCESS > > response won't be expected in return to a Direct Request call to set > > the memory attributes > > > > Changes since V1: > > Handled review comments from Sami Mujawar > > > > [1] - > https://github.com/sughoshg/edk2/tree/implement_ffa_svc_optional_v5 > > > > > > Achin Gupta (7): > > ArmPkg/IndustryStandard: Add barebones FF-A header > > ArmPkg/ArmSvcLib: Return x4-x7 in output parameters > > StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry > > point > > StandaloneMmPkg: Add option to use FF-A calls for communication with > > SPM > > ArmPkg: Use FF-A header file in Standalone MM Arm MMU library > > ArmPkg: Allow FF-A calls to get memory region's attributes > > ArmPkg: Allow FF-A calls to set memory region's attributes > > > > Ilias Apalodimas (2): > > MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase > > to Pcd > > StandaloneMmPkg: Allow sending FFA Direct Request message to > > StandaloneMm > > > > Sughosh Ganu (5): > > ArmPkg: Introduce support for PcdFfaEnable > > ArmPkg: Add macros for SPM version > > StandaloneMmPkg: Use macros for SPM version check > > ArmPkg: Add macros for SPM version with FF-A support enabled > > StandaloneMmPkg: Add option to use FF-A calls for getting SPM version > > > > Unfortunately, I won't be able to do a detailed review of this series, > but I have discussed these patches before with Sami off-list, and > based on that and on my earlier review of v3: > > Acked-by: Ard Biesheuvel > > for the series, where necessary. > Can you please merge this patch series for the stable tag edk2-stable202102. I have created a bugzilla ticket for this feature addition[1]. Please let me know if anything else is needed. Thanks. -sughosh [1] - https://bugzilla.tianocore.org/show_bug.cgi?id=3230 --000000000000f454a205bbee5384 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
hi Sami,

On Mon, 22 Feb 2021 at 19:40, Ard Biesheuvel = <ardb@kernel.org> wrote:
On Fri, 19 Feb 2021 a= t 07:36, Sughosh Ganu <sughosh.ganu@linaro.org> wrote:
>
> The following patch series adds support for using the Firmware
> Framework(FF-A) as a transport mechanism for requesting services from<= br> > the Secure Partition Manager(SPM). This is done through a Pcd which > can be used to enable the FF-A mechanism or to use the earlier used > SVC calls.
>
> The patches have been pushed to my github repository[1]
>
> Ran the CI tests through the github draft pull request, and all the CI=
> test pass. Ran the PatchCheck script, with no errors.
>
> Changes since V4:
> * Define all variable Pcd's under the [Pcd] section instead of
>=C2=A0 =C2=A0[FixedPcd], as suggested by Liming Gao
>
> Changes since V3:
> * Put the PcdFfaEnable under the PcdsFeatureFlag.AARCH64 section to >=C2=A0 =C2=A0avoid build breakage for the X64 StandaloneMm builds.
> * Put the macro definitions for the SPM major and minor versions in a<= br> >=C2=A0 =C2=A0separate patch, as suggested by Sami.
> * Separated out the declaration of the SPM major and minor version
>=C2=A0 =C2=A0macros in the earlier patch as was suggested by Sami.
> * Put the macro definitions for the SPM major and minor versions with<= br> >=C2=A0 =C2=A0FF-A support in a separate patch, as suggested by Sami. > * Declare the PcdFfaEnable Pcd Feature flag under FeaturePcd.AARCH64 >=C2=A0 =C2=A0to avoid build break for the X64 build of StandaloneMm. > * Change the patch header to have the ArmPkg prefix instead of
>=C2=A0 =C2=A0StandaloneMmMmuLib as suggested by Sami.
>
> Changes since V2:
> * Added a STATIC storage class specifier for mSpmMajorVer and
>=C2=A0 =C2=A0mSpmMinorVer variables
> * Added a STATIC storage class specifier for mSpmMajorVerFfa and
>=C2=A0 =C2=A0mSpmMinorVerFfa variables
> * Add braces for if/else statements
> * Add a check for EFI_NOT_FOUND as a possible return value from
>=C2=A0 =C2=A0LocateStandaloneMmCorePeCoffData in _ModuleEntryPoint func= tion
> * Check for the return value in Arg0 after the Direct Request call to<= br> >=C2=A0 =C2=A0handle errors returned
> * Put a comment to reflect the fact that FFA_INTERRUPT and FFA_SUCCESS=
>=C2=A0 =C2=A0response won't be expected in return to a Direct Reque= st call to get
>=C2=A0 =C2=A0the memory attributes
> * Check for the return value in Arg0 after the Direct Request call to<= br> >=C2=A0 =C2=A0handle errors returned
> * Put a comment to reflect the fact that FFA_INTERRUPT and FFA_SUCCESS=
>=C2=A0 =C2=A0response won't be expected in return to a Direct Reque= st call to set
>=C2=A0 =C2=A0the memory attributes
>
> Changes since V1:
> Handled review comments from Sami Mujawar
>
> [1] - https://github.com/sug= hoshg/edk2/tree/implement_ffa_svc_optional_v5
>
>
> Achin Gupta (7):
>=C2=A0 =C2=A0ArmPkg/IndustryStandard: Add barebones FF-A header
>=C2=A0 =C2=A0ArmPkg/ArmSvcLib: Return x4-x7 in output parameters
>=C2=A0 =C2=A0StandaloneMmPkg: Use FF-A header file in Standalone MM Cor= e entry
>=C2=A0 =C2=A0 =C2=A0point
>=C2=A0 =C2=A0StandaloneMmPkg: Add option to use FF-A calls for communic= ation with
>=C2=A0 =C2=A0 =C2=A0SPM
>=C2=A0 =C2=A0ArmPkg: Use FF-A header file in Standalone MM Arm MMU libr= ary
>=C2=A0 =C2=A0ArmPkg: Allow FF-A calls to get memory region's attrib= utes
>=C2=A0 =C2=A0ArmPkg: Allow FF-A calls to set memory region's attrib= utes
>
> Ilias Apalodimas (2):
>=C2=A0 =C2=A0MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVa= riableBase
>=C2=A0 =C2=A0 =C2=A0to Pcd
>=C2=A0 =C2=A0StandaloneMmPkg: Allow sending FFA Direct Request message = to
>=C2=A0 =C2=A0 =C2=A0StandaloneMm
>
> Sughosh Ganu (5):
>=C2=A0 =C2=A0ArmPkg: Introduce support for PcdFfaEnable
>=C2=A0 =C2=A0ArmPkg: Add macros for SPM version
>=C2=A0 =C2=A0StandaloneMmPkg: Use macros for SPM version check
>=C2=A0 =C2=A0ArmPkg: Add macros for SPM version with FF-A support enabl= ed
>=C2=A0 =C2=A0StandaloneMmPkg: Add option to use FF-A calls for getting = SPM version
>

Unfortunately, I won't be able to do a detailed review of this series,<= br> but I have discussed these patches before with Sami off-list, and
based on that and on my earlier review of v3:

Acked-by: Ard Biesheuvel <ardb@kernel.org>

for the series, where necessary.

Can yo= u please merge this patch series for the stable tag edk2-stable202102. I ha= ve created a bugzilla ticket for this feature addition[1]. Please let me kn= ow if anything else is needed. Thanks.

--000000000000f454a205bbee5384--