hi Sami,

On Thu, 5 Nov 2020 at 16:04, Sami Mujawar <Sami.Mujawar@arm.com> wrote:

> Hi Sughosh,
>
> Thank you for this patch.
>
> Please see my response inline marked [SAMI].
>

Thanks for your review comments. I will incorporate the comments in the v2
series. Will wait for a few more days for any other review comments on the
patch series.

-sughosh


>
> Regards,
>
> Sami Mujawar
>
> -----Original Message-----
> From: Sughosh Ganu <sughosh.ganu@linaro.org>
> Sent: 21 October 2020 12:32 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Sami Mujawar <
> Sami.Mujawar@arm.com>; Jiewen Yao <jiewen.yao@intel.com>; Achin Gupta <
> Achin.Gupta@arm.com>
> Subject: [PATCH v1 01/12] ArmPkg/IndustryStandard: Add barebones FF-A
> header
>
> From: Achin Gupta <achin.gupta@arm.com>
>
> This patch adds a rudimentary header file with defines for FF-A ABIs
> that will be used as the transport between S-EL0 and the SPM
>
> Signed-off-by: Achin Gupta <achin.gupta@arm.com>
> ---
>  ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h
> b/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h
> new file mode 100644
> index 0000000000..a8914085de
> --- /dev/null
> +++ b/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h
> @@ -0,0 +1,16 @@
> +/** @file
> [SAMI] Please add file description, see section 5.2.3.1 of EDKII coding
> standard specification (
> https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/52_spacing
> )
> [/SAMI]
> +*
> +*  Copyright (c) 2020, ARM Limited. All rights reserved.
> +*
> +*  SPDX-License-Identifier: BSD-2-Clause-Patent
> [SAMI] Add reference to the specification, see section 5.2.3.5 of EDKII
> coding standard specification.
> [/SAMI]
> +*
> +**/
> +
> +#ifndef __ARM_FFA_SVC_H__
> +#define __ARM_FFA_SVC_H__
> [SAMI] Make include guard compliant with EDKII coding standard, see
> section 5.3.5 (
> https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/53_include_files
> )
> [/SAMI]
> +
> +#define ARM_SVC_ID_FFA_VERSION_AARCH32                  0x84000063
> +#define ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ_AARCH64      0xC400006F
> +#define ARM_SVC_ID_FFA_MSG_SEND_DIRECT_RESP_AARCH64     0xC4000070
> +
> +#endif
> --
> 2.17.1
>
>