From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by mx.groups.io with SMTP id smtpd.web08.9208.1604653659790853968 for ; Fri, 06 Nov 2020 01:07:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=MYjiI4+w; spf=pass (domain: linaro.org, ip: 209.85.166.193, mailfrom: sughosh.ganu@linaro.org) Received: by mail-il1-f193.google.com with SMTP id q1so464117ilt.6 for ; Fri, 06 Nov 2020 01:07:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HL/gAmpyy4v/KeqbmKTAN5RHLP9dYwKRW0SobKaZnQM=; b=MYjiI4+wcDI0HK8cq22Ia0deoeGgQKoqsgwvs62quzV5bqy+5YNGYFj3G6ODOqYxhJ L/BH8KWwWPlW3EpdHgfRShOBUuyTjHKEOO94ObssV28ZsYxXUL3gQhQO290Coggl0ymk dyXAfNiPqPgphM9ko5xOiw5nQ2krY8K0Qn9xTDq3GCAuMDmFFk2TCRE9mpMvIEBQMIx2 G/bwqKfLv9V5CXPxpN0nSb0btjXeKRsm7JXXeoZYxMQYPUd0OR28K+ptcX22c+c3fI7r lXGJpG/dYV2uchlTbWdV7bIN8MxbO2mjA1wyNdL8VaJ1rY6dKTKVlx4XzW1IiflDLTL9 a8Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HL/gAmpyy4v/KeqbmKTAN5RHLP9dYwKRW0SobKaZnQM=; b=nIMS48G6jDynzV5jUdliZVmQmiM8eGYJPoUEwaiRN/PQ1xsG+kX4MpPt4C6sdx9dy0 yAa4w/qszkAbbn3frXIIGx3fvTC/4La6wpnNIAGS+ma3tm6xUHHcspINckVr3PJBQWDt v2DgXiAHgSl72yqkOJkfGJKStxb+YCP5fDlHN8yaAilotYNIwxtQx5Y1uBdJTeiaomUC pz6s/lVb4c7bmUqXAxgmSlALU4UNamJzsibEebHmn/MWPjNwv9LC/HPAyLawQNwv1KMG Ksd516U3PuORCbQNqdb2jTi5j/jLmcJ9K7qn7RHFAPa0bH7iqGJikLqL4XcLXSaxmi2J iTgw== X-Gm-Message-State: AOAM53398BZ8leGhVTtTn9qFNHC7G3Fak1RSgZwh5RBoaZkrG8be9+2D gx9YQNs/aSXDz50GzxJxMoODHFX1ef5vTMevEDeQfQ== X-Google-Smtp-Source: ABdhPJypf/wKqizgSVp+jfndKYxbCuzkh4JEn0JQCaieoGw3fNtgfIoBuv4DrJqBHomjYrnQsIdyaPdbEFww19SXre4= X-Received: by 2002:a92:3408:: with SMTP id b8mr760603ila.78.1604653658998; Fri, 06 Nov 2020 01:07:38 -0800 (PST) MIME-Version: 1.0 References: <20201021113233.25548-1-sughosh.ganu@linaro.org> <20201021113233.25548-2-sughosh.ganu@linaro.org> In-Reply-To: From: "Sughosh Ganu" Date: Fri, 6 Nov 2020 14:36:52 +0530 Message-ID: Subject: Re: [PATCH v1 01/12] ArmPkg/IndustryStandard: Add barebones FF-A header To: Sami Mujawar Cc: "devel@edk2.groups.io" , Ard Biesheuvel , Jiewen Yao , Achin Gupta , nd Content-Type: multipart/alternative; boundary="000000000000552a4b05b36c8b0a" --000000000000552a4b05b36c8b0a Content-Type: text/plain; charset="UTF-8" hi Sami, On Thu, 5 Nov 2020 at 16:04, Sami Mujawar wrote: > Hi Sughosh, > > Thank you for this patch. > > Please see my response inline marked [SAMI]. > Thanks for your review comments. I will incorporate the comments in the v2 series. Will wait for a few more days for any other review comments on the patch series. -sughosh > > Regards, > > Sami Mujawar > > -----Original Message----- > From: Sughosh Ganu > Sent: 21 October 2020 12:32 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Sami Mujawar < > Sami.Mujawar@arm.com>; Jiewen Yao ; Achin Gupta < > Achin.Gupta@arm.com> > Subject: [PATCH v1 01/12] ArmPkg/IndustryStandard: Add barebones FF-A > header > > From: Achin Gupta > > This patch adds a rudimentary header file with defines for FF-A ABIs > that will be used as the transport between S-EL0 and the SPM > > Signed-off-by: Achin Gupta > --- > ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h > b/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h > new file mode 100644 > index 0000000000..a8914085de > --- /dev/null > +++ b/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h > @@ -0,0 +1,16 @@ > +/** @file > [SAMI] Please add file description, see section 5.2.3.1 of EDKII coding > standard specification ( > https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/52_spacing > ) > [/SAMI] > +* > +* Copyright (c) 2020, ARM Limited. All rights reserved. > +* > +* SPDX-License-Identifier: BSD-2-Clause-Patent > [SAMI] Add reference to the specification, see section 5.2.3.5 of EDKII > coding standard specification. > [/SAMI] > +* > +**/ > + > +#ifndef __ARM_FFA_SVC_H__ > +#define __ARM_FFA_SVC_H__ > [SAMI] Make include guard compliant with EDKII coding standard, see > section 5.3.5 ( > https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/53_include_files > ) > [/SAMI] > + > +#define ARM_SVC_ID_FFA_VERSION_AARCH32 0x84000063 > +#define ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ_AARCH64 0xC400006F > +#define ARM_SVC_ID_FFA_MSG_SEND_DIRECT_RESP_AARCH64 0xC4000070 > + > +#endif > -- > 2.17.1 > > --000000000000552a4b05b36c8b0a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
hi Sami,

On Thu, 5 Nov 2020 at 16:04, Sami Mujawar <= ;Sami.Mujawar@arm.com> wrote= :
Hi Sughosh,
Thank you for this patch.

Please see my response inline marked [SAMI].

Thanks for your review comments. I will incorporate the comments in t= he v2 series. Will wait for a few more days for any other review comments o= n the patch series.

-sughosh
=C2=A0

Regards,

Sami Mujawar

-----Original Message-----
From: Sughosh Ganu <sughosh.ganu@linaro.org>
Sent: 21 October 2020 12:32 PM
To: devel@edk2.gr= oups.io
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; Jiewe= n Yao <jiewen.= yao@intel.com>; Achin Gupta <Achin.Gupta@arm.com>
Subject: [PATCH v1 01/12] ArmPkg/IndustryStandard: Add barebones FF-A heade= r

From: Achin Gupta <achin.gupta@arm.com>

This patch adds a rudimentary header file with defines for FF-A ABIs
that will be used as the transport between S-EL0 and the SPM

Signed-off-by: Achin Gupta <achin.gupta@arm.com>
---
=C2=A0ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 16 ++++++++++++++++
=C2=A01 file changed, 16 insertions(+)

diff --git a/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h b/ArmPkg/Include/I= ndustryStandard/ArmFfaSvc.h
new file mode 100644
index 0000000000..a8914085de
--- /dev/null
+++ b/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h
@@ -0,0 +1,16 @@
+/** @file
[SAMI] Please add file description, see section 5.2.3.1 of EDKII coding sta= ndard specification (https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-speci= fication/5_source_files/52_spacing)
[/SAMI]
+*
+*=C2=A0 Copyright (c) 2020, ARM Limited. All rights reserved.
+*
+*=C2=A0 SPDX-License-Identifier: BSD-2-Clause-Patent
[SAMI] Add reference to the specification, see section 5.2.3.5 of EDKII cod= ing standard specification.
[/SAMI]
+*
+**/
+
+#ifndef __ARM_FFA_SVC_H__
+#define __ARM_FFA_SVC_H__
[SAMI] Make include guard compliant with EDKII coding standard, see section= 5.3.5 (https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specificatio= n/5_source_files/53_include_files)
[/SAMI]
+
+#define ARM_SVC_ID_FFA_VERSION_AARCH32=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 0x84000063
+#define ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ_AARCH64=C2=A0 =C2=A0 =C2=A0 0xC= 400006F
+#define ARM_SVC_ID_FFA_MSG_SEND_DIRECT_RESP_AARCH64=C2=A0 =C2=A0 =C2=A00xC= 4000070
+
+#endif
--
2.17.1

--000000000000552a4b05b36c8b0a--