From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.23063.1647234047275069454 for ; Sun, 13 Mar 2022 22:00:47 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: jagadeesh.ujja@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 362BA106F for ; Sun, 13 Mar 2022 22:00:46 -0700 (PDT) Received: from mail-qt1-f180.google.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23DE23FA1D for ; Sun, 13 Mar 2022 22:00:46 -0700 (PDT) Received: by mail-qt1-f180.google.com with SMTP id a14so12255565qtx.12 for ; Sun, 13 Mar 2022 22:00:46 -0700 (PDT) X-Gm-Message-State: AOAM531npFZns3Q+wEE2scjK3Rz4AsDABoF+OuOY1QhycYGlyBapurOE x19cQqJLfI+DN1S78dq3PtulEjkwrcXpB60RKb0= X-Google-Smtp-Source: ABdhPJwT5WWxK+qaOxIPWqbkbC4n5EBXHntQHZjmBBvxzbaYf7Qc51pCHQVx6UAvsF5MBI33EgfIbxgctxr5ikQs7SI= X-Received: by 2002:ac8:7f51:0:b0:2dd:3339:dfe5 with SMTP id g17-20020ac87f51000000b002dd3339dfe5mr17245488qtk.269.1647234045496; Sun, 13 Mar 2022 22:00:45 -0700 (PDT) MIME-Version: 1.0 References: <20220310173927.105596-1-sami.mujawar@arm.com> In-Reply-To: From: "Jagadeesh Ujja" Date: Mon, 14 Mar 2022 10:30:42 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix serial port namespace path in DBG2 To: devel@edk2.groups.io, Sami Mujawar Cc: Alexei.Fedorov@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, pierre.gondois@arm.com Content-Type: text/plain; charset="UTF-8" Hi Sami, The patch is tested and looks good to me: Tested-by: Jagadeesh Ujja On Fri, Mar 11, 2022 at 6:38 PM PierreGondois wrote: > > Hi Sami, > The patch looks good to me: > > Reviewed-by: Pierre Gondois > > On 3/10/22 18:39, Sami Mujawar wrote: > > According to the Debug Port Table 2 (DBG2) specification, > > February 17, 2021, the NamespaceString is a NULL terminated > > ASCII string that consists of a fully qualified reference > > to the object that represents the serial port device in the > > ACPI namespace. > > > > The DBG2 table generator did not populate the full device > > path for the serial port device, and this results in a FWTS > > test failure. > > > > Therefore, populate the full namespace device path for the > > serial port in DBG2 table. > > > > Signed-off-by: Sami Mujawar > > --- > > The changes can be seen at: > > https://github.com/samimujawar/edk2/tree/2105_dbg2_generator_namestring_issue_v1 > > > > DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c > > index 3d513dbd1fbe8c47d270a9e639b2797098201d91..f6dfb3d94c10980a0e7712ce9427648b69974061 100644 > > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c > > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c > > @@ -1,7 +1,7 @@ > > /** @file > > DBG2 Table Generator > > > > - Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
> > + Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -55,13 +55,17 @@ Requirements: > > */ > > #define NAME_STR_DBG_PORT0 "COM0" > > > > +/** A string representing the full path name of the debug port 0. > > +*/ > > +#define NAMESPACE_STR_DBG_PORT0 "\\_SB_.COM0" > > + > > /** An UID representing the debug port 0. > > */ > > #define UID_DBG_PORT0 0 > > > > /** The length of the namespace string. > > */ > > -#define DBG2_NAMESPACESTRING_FIELD_SIZE sizeof (NAME_STR_DBG_PORT0) > > +#define DBG2_NAMESPACESTRING_FIELD_SIZE sizeof (NAMESPACE_STR_DBG_PORT0) > > > > /** The PL011 UART address range length. > > */ > > @@ -166,7 +170,7 @@ DBG2_TABLE AcpiDbg2 = { > > 0, // {Template}: Serial Port Subtype > > 0, // {Template}: Serial Port Base Address > > PL011_UART_LENGTH, > > - NAME_STR_DBG_PORT0 > > + NAMESPACE_STR_DBG_PORT0 > > ) > > } > > }; > > > > >