From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=jagadeesh.ujja@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id A668F211DCD88 for ; Fri, 15 Mar 2019 01:19:21 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D2E4915BE for ; Fri, 15 Mar 2019 01:19:20 -0700 (PDT) Received: from mail-it1-f169.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B8C703F7BB for ; Fri, 15 Mar 2019 01:19:20 -0700 (PDT) Received: by mail-it1-f169.google.com with SMTP id o76so5808879ita.3 for ; Fri, 15 Mar 2019 01:19:20 -0700 (PDT) X-Gm-Message-State: APjAAAVEvuRIP/4i4OxbfcB+OuNQpNDeuAqNUNFh9GG7E8GNBZg//jPI RwJON8kqL7UldEXhgJKZXqY1yRrX2d/cLlGsXFI= X-Google-Smtp-Source: APXvYqxUppt5AEWhYZnR/mJxwWP2okKJYkoHP3KXeIIB9yuM570SHsLi0ee3f6sjpXNoogR5sO1+lvzEphOmMfY7PHY= X-Received: by 2002:a24:16d4:: with SMTP id a203mr1055227ita.52.1552637959924; Fri, 15 Mar 2019 01:19:19 -0700 (PDT) MIME-Version: 1.0 References: <1552406795-16588-1-git-send-email-jagadeesh.ujja@arm.com> In-Reply-To: <1552406795-16588-1-git-send-email-jagadeesh.ujja@arm.com> From: Jagadeesh Ujja Date: Fri, 15 Mar 2019 13:49:09 +0530 X-Gmail-Original-Message-ID: Message-ID: To: edk2-devel@lists.01.org, Leif Lindholm , Ard Biesheuvel Subject: Re: [PATCH edk2-platforms v2 0/3] Platform/ARM/SgiPkg: Implement StandaloneMm based secure boot X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 X-List-Received-Date: Fri, 15 Mar 2019 08:19:21 -0000 Content-Type: text/plain; charset="UTF-8" hi Ard/Leif Please let me know if you have any comments on this patch set thanks Jagadeesh On Tue, Mar On Tue, Mar 12, 2019 at 9:45 PM Jagadeesh Ujja wrote: > > Changes since v1: > - Addressed all the comments from Ard Biesheuvel. > > Integrating various pieces together so that the authenticated variable store > runs entirely in standalone MM context residing in a secure partition. > This primarily involves adding all required library and drivers to platform > specific .DSC and .FDF files. This creates separate Nor flash region which > is visible to only StandaoneMm drivers, this Nor Flash will co-exist along > with general Nor flash region. > > Jagadeesh Ujja (3): > Platform/ARM/Sgi: define nor2 flash controller memory map > Platform/ARM/Sgi: allow MM_STANDALONE modules to use > NorFlashPlatformLib > Platform/ARM/SgiPkg: add MM based UEFI secure boot support > > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 4 ++ > Platform/ARM/SgiPkg/Library/NorFlashLib/StandaloneMmNorFlashLib.c | 63 ++++++++++++++++++++ > Platform/ARM/SgiPkg/Library/NorFlashLib/StandaloneMmNorFlashLib.inf | 33 ++++++++++ > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 34 ++++++++++- > Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 5 ++ > Platform/ARM/SgiPkg/SgiPlatform.dsc | 18 +++++- > Platform/ARM/SgiPkg/SgiPlatform.fdf | 7 ++- > 7 files changed, 161 insertions(+), 3 deletions(-) > create mode 100644 Platform/ARM/SgiPkg/Library/NorFlashLib/StandaloneMmNorFlashLib.c > create mode 100644 Platform/ARM/SgiPkg/Library/NorFlashLib/StandaloneMmNorFlashLib.inf > > -- > 2.7.4 > > In-Reply-To: > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel