From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=jagadeesh.ujja@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id AB89C211ACEC5 for ; Wed, 2 Jan 2019 05:27:54 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9DB2B15BE for ; Wed, 2 Jan 2019 05:27:54 -0800 (PST) Received: from mail-it1-f179.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 825E23F90E for ; Wed, 2 Jan 2019 05:27:54 -0800 (PST) Received: by mail-it1-f179.google.com with SMTP id p197so38686733itp.0 for ; Wed, 02 Jan 2019 05:27:54 -0800 (PST) X-Gm-Message-State: AA+aEWYakRe5r27YyQTUBodyDgRmXU5yYvGz8Wjl+G5GVJhGvnGy4kzM Ci5QvIkrp1o+LzZVdMf0uJyc95JU8Pcql6ArBUI= X-Google-Smtp-Source: ALg8bN6/Rs2KhsltxjzrH0k6rr+pT/4KXS6eiYRjnjF2xELh1dufezQdFGveIGWDNwAr7XcwlysBTYskuTfeHMBAIrM= X-Received: by 2002:a05:660c:781:: with SMTP id h1mr22956350itk.52.1546435673727; Wed, 02 Jan 2019 05:27:53 -0800 (PST) MIME-Version: 1.0 References: <1544789607-11316-1-git-send-email-jagadeesh.ujja@arm.com> <1544789607-11316-11-git-send-email-jagadeesh.ujja@arm.com> In-Reply-To: From: Jagadeesh Ujja Date: Wed, 2 Jan 2019 18:57:42 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , "Zhang, Chao B" , "Gao, Liming" Subject: Re: [PATCH 10/13] MdeModulePkg/VarCheckLib: allow MM_STANDALONE drivers to use this library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2019 13:27:56 -0000 X-List-Received-Date: Wed, 02 Jan 2019 13:27:56 -0000 X-List-Received-Date: Wed, 02 Jan 2019 13:27:56 -0000 X-List-Received-Date: Wed, 02 Jan 2019 13:27:56 -0000 X-List-Received-Date: Wed, 02 Jan 2019 13:27:56 -0000 X-List-Received-Date: Wed, 02 Jan 2019 13:27:56 -0000 X-List-Received-Date: Wed, 02 Jan 2019 13:27:56 -0000 X-List-Received-Date: Wed, 02 Jan 2019 13:27:56 -0000 X-List-Received-Date: Wed, 02 Jan 2019 13:27:56 -0000 X-List-Received-Date: Wed, 02 Jan 2019 13:27:56 -0000 X-List-Received-Date: Wed, 02 Jan 2019 13:27:56 -0000 X-List-Received-Date: Wed, 02 Jan 2019 13:27:56 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ard, On Wed, Jan 2, 2019 at 6:35 PM Ard Biesheuvel w= rote: > > On Fri, 14 Dec 2018 at 13:14, Jagadeesh Ujja wro= te: > > > > =E2=80=9CVarCheckLib=E2=80=9D library can be used by MM_STANDALONE driv= ers as well. > > So add MM_STANDALONE as the module type this library supports. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Jagadeesh Ujja > > --- > > MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf b/MdeModu= lePkg/Library/VarCheckLib/VarCheckLib.inf > > index 099f83d..c8cf810 100644 > > --- a/MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > > +++ b/MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > > @@ -2,6 +2,7 @@ > > # Provides variable check services and database management. > > # > > # Copyright (c) 2015, Intel Corporation. All rights reserved.
> > +# Copyright (c) 2018, ARM Limited. All rights reserved.
> > # > > # This program and the accompanying materials > > # are licensed and made available under the terms and conditions > > @@ -21,12 +22,12 @@ > > FILE_GUID =3D 63E12D08-0C5D-47F8-95E4-09F89D750= 6C5 > > MODULE_TYPE =3D DXE_RUNTIME_DRIVER > > Please change the module type to 'BASE' as well. Note that this may > require you to add > > #include > > to some source or header files. > > With that > > Reviewed-by: Ard Biesheuvel > Sorry Just now I submitted patch set v2, will take care of this review comments in the next patchset Thanks Jagadeesh > > VERSION_STRING =3D 1.0 > > - LIBRARY_CLASS =3D VarCheckLib|DXE_RUNTIME_DRIVER DX= E_SMM_DRIVER > > + LIBRARY_CLASS =3D VarCheckLib|DXE_RUNTIME_DRIVER DX= E_SMM_DRIVER MM_STANDALONE > > > > # > > # The following information is for reference only and not required by = the build tools. > > # > > -# VALID_ARCHITECTURES =3D IA32 X64 > > +# VALID_ARCHITECTURES =3D IA32 X64 AARCH64 > > # > > > > [Sources] > > -- > > 2.7.4 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel