From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.101.70, mailfrom: jagadeesh.ujja@arm.com) Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by groups.io with SMTP; Mon, 29 Apr 2019 05:21:22 -0700 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B7F1AEBD for ; Mon, 29 Apr 2019 05:21:21 -0700 (PDT) Received: from mail-it1-f171.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9F6A33FA45 for ; Mon, 29 Apr 2019 05:21:21 -0700 (PDT) Received: by mail-it1-f171.google.com with SMTP id x132so15810504itf.2 for ; Mon, 29 Apr 2019 05:21:21 -0700 (PDT) X-Gm-Message-State: APjAAAVKAN0nG+e1N85TXF0rnYTY+xkNtTiyKFacM2+NuWZkSOvqoU6X kMoQZ0cpYMbtg5/m/tGw4G0APOBImI4E1BzMdkU= X-Google-Smtp-Source: APXvYqxdABUNR08Rm2uS68cfDzEpShaR9dvt9gDhdNdA9BG+qWxMW6qGNvSCGM8qbsmhCs8DWNoh4iaSwSHbtVSPdu8= X-Received: by 2002:a02:1a89:: with SMTP id 131mr4683151jai.78.1556540472844; Mon, 29 Apr 2019 05:21:12 -0700 (PDT) MIME-Version: 1.0 References: <1554210602-2957-1-git-send-email-jagadeesh.ujja@arm.com> <20190429075816.y4gyeyqt4kp7lffk@bivouac.eciton.net> <20190429085207.tmt3wr36vepu7d5p@bivouac.eciton.net> In-Reply-To: <20190429085207.tmt3wr36vepu7d5p@bivouac.eciton.net> From: "Jagadeesh Ujja" Date: Mon, 29 Apr 2019 17:51:01 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2] [PATCH v2 edk2-platforms] Platform/ARM/Drivers: Add Nor Flash Driver To: devel@edk2.groups.io, Leif Lindholm Cc: Ard Biesheuvel , Thomas Panakamattam Abraham Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable hi Ard/Leif On Mon, Apr 29, 2019 at 2:22 PM Leif Lindholm w= rote: > > On Mon, Apr 29, 2019 at 10:17:17AM +0200, Ard Biesheuvel wrote: > > > I mean, the actually relevant bit is basically > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/t= ree/drivers/mtd/afs.c, > > > isn't it? > > > > > > +Thomas. > > > > AIUI, these things are entirely separate. Exposing NOR flash via block > > I/O and disk I/O permits the standard partition driver and FAT > > filesystem driver to bind to it, so that you can have a standard FAT > > ESP on NOR flash. I don't this is related at all to the BootMonFs > > stuff > > If so, that's even sillier. If it has any business remaining > supported, that should be a separate driver consuming NorFlashDxe. > > And if ARM feels their platforms need it, they can write that driver. > > So how about we don't move it and just nuke the BlockIo/DiskIo bits? > > / > Leif > I am little bit confused here, please confirm I have to copy =E2=80=9CArmPlatformPkg/Drivers/NorFlashDxe=E2=80=9D to edk2-platforms/Platform/ARM/Drivers first and then rip out the block i/o and disk i/o parts to get StandaloneNorFlash driver? And retain =E2=80=9CArmPlatformPkg/Drivers/NorFlashDxe=E2=80=9D as it is ? thanks Jagadeesh >=20 >