public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Mikolaj Lisik" <lisik@google.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io, pedro.falcato@gmail.com,
	 Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	 "Yao, Jiewen" <jiewen.yao@intel.com>,
	Min Xu <min.m.xu@intel.com>,
	 Tom Lendacky <thomas.lendacky@amd.com>,
	michael.roth@amd.com
Subject: Re: [edk2-devel] [PATCH] OvmfPkg: Create additional PML4 entries for large SEV-SNP VMs
Date: Tue, 24 Jan 2023 17:53:09 -0800	[thread overview]
Message-ID: <CADtC8PWaT8oWBaiJiFNj_BSBdVLkd_pYPqEfBMs7KSZzdW5kOg@mail.gmail.com> (raw)
In-Reply-To: <20230116103919.ff73h2lotmovl77u@sirius.home.kraxel.org>

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

Hi,

> > (now that I check, all of this insane behavior seems to have been
> > inherited from MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c. Sorry
> > for the rant.)
>
> We have UefiCpuPkg/Library/CpuPageTableLib meanwhile.
>
> So switch the code over to use that instead, and reduce the number
> of VirtualMemory.c copies floating around in the tree?

As much sense as this makes to me I would stick to using the structure for
this patch. It's simply a bug fix to an existing code path.

I'm of course open to the discussion of making larger changes in the
codebase in a separate series.

Thanks!
Mikolaj

[-- Attachment #2: Type: text/html, Size: 1015 bytes --]

  reply	other threads:[~2023-01-25  1:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13  0:57 [PATCH] OvmfPkg: Create additional PML4 entries for large SEV-SNP VMs lisik
2023-01-14  2:35 ` [edk2-devel] " Pedro Falcato
2023-01-16 10:39   ` Gerd Hoffmann
2023-01-25  1:53     ` Mikolaj Lisik [this message]
2023-01-25  1:44   ` Mikolaj Lisik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADtC8PWaT8oWBaiJiFNj_BSBdVLkd_pYPqEfBMs7KSZzdW5kOg@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox