From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by mx.groups.io with SMTP id smtpd.web10.35281.1674611602454422326 for ; Tue, 24 Jan 2023 17:53:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@google.com header.s=20210112 header.b=YJ82h189; spf=pass (domain: google.com, ip: 209.85.218.47, mailfrom: lisik@google.com) Received: by mail-ej1-f47.google.com with SMTP id ss4so43729791ejb.11 for ; Tue, 24 Jan 2023 17:53:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gkF0N1WaCKJ8eU8YBAXomkc7Rbse3MmgsCq9TeTjUiA=; b=YJ82h189Az72+FQwOV6kpog4YjnI7D3KfybJj+X36UnkzclTQQVu3KsjQVqLkzOufK 9Rnc/iMcEfABGrbYSgvfyuFegm8gFU+lqsC19J0pXm5T3gE9oHKeS+219FGU4qTK/SZT YU4svUwV8iBunL7bSB7iv0ZBI9RecQqbwlskYSiOltIg7gs5iRy87F0M6WLiLNoA5E+2 Adu9zFNmKbBAhc62h9u81QRJxyQdaj4+XLz1IFE9OuFBuIqpYtUblJr2TYHi3vyGckRN watb6DaQeABeRRlvCi20XU5W3JW7ERjMIjaDc94Dw+XkDEZeSTSfnvNwKWCxIoLZ78uz 2VzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gkF0N1WaCKJ8eU8YBAXomkc7Rbse3MmgsCq9TeTjUiA=; b=vZVC/qrF1+1/GsMfCYl7r8AWsDgaAucPNq73QKwXraUAyvUPXelTgV+Y+h3oK/ZPo/ xMvaz5OXkPaToWk2vzXpwjbPxTWiuu/4d3HeGUZJje98qTTPfcLbRQWTXXd8ve5yiEFM Vlil7Xicso8PsAoAvo068wuvHUa5Rs3bb8XHCxe98gw6ia91NBl7JpY/DfwmRTogKZtZ RLrm4VnasgCUgt6eei7vWbI3rnaldw9+zAI1M0XZwOCZNsn7jrx2+15hvF0gsTZmNXVg Kr/lr5wrM8zqq8id1u8bc7eenTS8jZZ7OQ1O1RV5iwB9MM/pRVjgwP1RiE8sDMDLjsMS zQyQ== X-Gm-Message-State: AFqh2kqbUAkb5hB9yK4mqxa2qJFb+Zf0a1y4IkE+iR37/l66DljhwcUb LgtvIWUitgKUnyewnix+ObRkL7vkc4r8wrzt6Qjjpw== X-Google-Smtp-Source: AMrXdXvrGlFBzFChVA3N9D6vF8vFMtx/AOGexAJqo6FfaZCcBYN54UzK4QsEUzuyjE0wGICHF3VJhpYdOuAIzNwoUOo= X-Received: by 2002:a17:906:1448:b0:781:f54c:1947 with SMTP id q8-20020a170906144800b00781f54c1947mr4541709ejc.69.1674611600831; Tue, 24 Jan 2023 17:53:20 -0800 (PST) MIME-Version: 1.0 References: <5e1916c6669ee2a918a2c22b7698e96f7dbf5488.1673568149.git.lisik@google.com> <20230116103919.ff73h2lotmovl77u@sirius.home.kraxel.org> In-Reply-To: <20230116103919.ff73h2lotmovl77u@sirius.home.kraxel.org> From: "Mikolaj Lisik" Date: Tue, 24 Jan 2023 17:53:09 -0800 Message-ID: Subject: Re: [edk2-devel] [PATCH] OvmfPkg: Create additional PML4 entries for large SEV-SNP VMs To: Gerd Hoffmann Cc: devel@edk2.groups.io, pedro.falcato@gmail.com, Erdem Aktas , James Bottomley , "Yao, Jiewen" , Min Xu , Tom Lendacky , michael.roth@amd.com Content-Type: multipart/alternative; boundary="0000000000009b083405f30ce5d6" --0000000000009b083405f30ce5d6 Content-Type: text/plain; charset="UTF-8" Hi, > > (now that I check, all of this insane behavior seems to have been > > inherited from MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c. Sorry > > for the rant.) > > We have UefiCpuPkg/Library/CpuPageTableLib meanwhile. > > So switch the code over to use that instead, and reduce the number > of VirtualMemory.c copies floating around in the tree? As much sense as this makes to me I would stick to using the structure for this patch. It's simply a bug fix to an existing code path. I'm of course open to the discussion of making larger changes in the codebase in a separate series. Thanks! Mikolaj --0000000000009b083405f30ce5d6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

> > (now tha= t I check, all of this insane behavior seems to have been
> > inhe= rited from MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c. Sorry
> = > for the rant.)
>
> We have UefiCpuPkg/Library/CpuPageTable= Lib meanwhile.
>
> So switch the code over to use that instead,= and reduce the number
> of VirtualMemory.c copies floating around in= the tree?

As much sense as this makes to me I would stick to using = the structure for this patch. It's simply a bug fix to an existing code= path.=C2=A0

I'm of course open to the discussion of making large= r changes in the codebase in a separate series.

Thanks!<= /div>
Mikolaj
--0000000000009b083405f30ce5d6--