From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by mx.groups.io with SMTP id smtpd.web08.6703.1613731402136359413 for ; Fri, 19 Feb 2021 02:43:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@puresoftware.com header.s=google header.b=U1nTjoVk; spf=pass (domain: puresoftware.com, ip: 209.85.167.176, mailfrom: vikas.singh@puresoftware.com) Received: by mail-oi1-f176.google.com with SMTP id y199so5382979oia.4 for ; Fri, 19 Feb 2021 02:43:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=puresoftware.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ljOuiZG5Ws015LuoIuWq0Uum5B0m5FgwK1iAnf3KKEM=; b=U1nTjoVkoPoK1LNZBVvhU9fr7cjCyH3AUjzG8f58cxb1cwDn6b0m9KhF80Si8WPsG4 gbrqlQeMo9H+A8w1SikedZro7Ovv14wjfytY5WNPXvx3VpKQYrJ2PVgLRld1en3cwK6G Pi7tWrYyH3RYfSoqRXeHgnW195MVpOaUit3O8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ljOuiZG5Ws015LuoIuWq0Uum5B0m5FgwK1iAnf3KKEM=; b=X9yEqCgM98TEBfraRQQ7i6cEPe5sE7FHnN4C6n1w/a44rWD+ZGkKwntCJ4eLewW4W9 AThU1+fKx5FQHSer5BSxRxRrJhsAKfQFDMgMsujTYFNYhxt6J/eQQGvQxq8N0X4t77B/ bT8mSsxvfzPXLK8WRsgpvn12/+OWNuYMp9GDiByQl2BarJu3aT9rSCYnNYPLmetMsZIu NRc9e5k47sseIs3TqgBlxXo9cbFXXVUh2baJMIdXovu8Vr1A2W1XaH21Mb0Nhu7bl5UY foW7fFcFRvz67oLW8varFrc8Vfx3RAAbsJMxS6WFiESsSzXpqJ/XLZkvmJ9H8YL8wq02 cEFg== X-Gm-Message-State: AOAM53262b01bQKidvdoL2Sm9GmttB7vFfDDYCsGxYDq3x8pbwaOek9Y 1InbO5rqAA913kLld0OQZczdGxlMkOQbG0du4Z2HVA== X-Google-Smtp-Source: ABdhPJwC0vwUAEUt+9CPr/YB1T/TiA/CwcDT8zEalV3jTLty3ILsBZL/r2SSfwBFMb0qyzm92vdN3cS4o/FoQtOhXPU= X-Received: by 2002:aca:4fca:: with SMTP id d193mr6203570oib.135.1613731401336; Fri, 19 Feb 2021 02:43:21 -0800 (PST) MIME-Version: 1.0 References: <1611729899-23741-1-git-send-email-vikas.singh@puresoftware.com> <20210215131829.GB1664@vanye> In-Reply-To: From: "Vikas Singh" Date: Fri, 19 Feb 2021 16:12:56 +0530 Message-ID: Subject: Re: [PATCH v2 0/2] Dynamic ACPI framework for fsl layerscape platforms To: Leif Lindholm Cc: Sami Mujawar , devel@edk2.groups.io, meenakshi.aggarwal@nxp.com, Paul Yang , Augustine Philips , samer.el-haj-mahmoud@arm.com, Varun Sethi , Arokia Samy , Kuldip Dwivedi , ard.biesheuvel@arm.com, Vikas Singh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 16, 2021 at 5:29 PM Vikas Singh wrote: > > On Mon, Feb 15, 2021 at 6:48 PM Leif Lindholm wrote: > > > > Hi Vikas, > > > > Apologies for very slow review. > > > > However, this set doesn't build for me. > > It fails with > > > > In file included from /work/git/edk2-platforms/Platform/NXP/Configurati= onManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c:26: > > /work/git/edk2-platforms/Platform/NXP/ConfigurationManagerPkg/Configura= tionManagerDxe/ConfigurationManager.h:17:10: fatal error: Platform.h: No su= ch file or directory > > #include > > ^~~~~~~~~~~~ > > > > Since the location of ConfigurationManagerPkg suggests the intent to > > use this for additional platforms in the future, this cannot be > > resolved by referencing LX2160aRdbPkg.dec from > > ConfigurationManagerDxe.inf. > > > > I would suggest doing like the ARM VExpressPkg and add: > > [BuildOptions] > > GCC:*_*_AARCH64_PLATFORM_FLAGS =3D=3D -I$(WORKSPACE)/Platform/NXP/LX2= 160aRdbPkg/Include > > to LX2160aRdbPkg.dsc. > > > > Thank you leif for your review comments and suggesting the way out. > I will do the necessary changes (suggested by you) and drop the build > script idea at this moment. > > I will share the updated V3 series asap. > > Thnx!! > VS > Hi Leif, I have shared the modified V3 series the day before yesterday. Let me know if you see further improvements on it. This is for your info. Thnx !! VS > > Also, I'm seeing a build failure in edk2 DynamicTablesPkg when > > building with NOOPT: > > /work/git/edk2/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlName= Space.c: In function =E2=80=98AmlEnumeratePathCallback=E2=80=99: > > /work/git/edk2/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlName= Space.c:1081:31: error: variable =E2=80=98CurrNodePath=E2=80=99 set but not= used [-Werror=3Dunused-but-set-variable] > > CHAR8 * CurrNodePath; > > ^~~~~~~~~~~~ > > /work/git/edk2/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlName= Space.c:1078:31: error: variable =E2=80=98SearchedPath=E2=80=99 set but not= used [-Werror=3Dunused-but-set-variable] > > CHAR8 * SearchedPath; > > ^~~~~~~~~~~~ > > > > Sami - can you have a look at that? > > > > I'll follow up with a couple of minor comments on the patches. > > > > Best Regards, > > > > Leif > > > > On Wed, Jan 27, 2021 at 12:14:57 +0530, Vikas Singh wrote: > > > This patch series sets the foundation of Dynamic ACPI framework for a= ll > > > fsl layerscape platforms. In order to achieve: > > > - Configurable firmware builds. > > > - Unify firmware build for similar platforms. > > > - Minimize/eliminate human induced errors. > > > - Validate and generate firmware that complies with relevant specif= ications. > > > this change set will introduce following changes in below defined ord= er under > > > edk2-platforms/NXP for LX2160ARDB platform. > > > > > > (1) Introduced edk2-platforms/NXP/ConfigurationManager > > > It creates the platform repositories dynamically during build time > > > and initializes with platform specific information and serves all req= uestes > > > coming from OEM/standard firmware table generators. Configuration Man= ager(CM) > > > will be common for all fsl platforms. > > > > > > (2) Introduced edk2-platforms/NXP/LX2160ARDB/Include/Platform.h > > > It has all the declarations and the definitions specified for the pla= tforms. > > > These definitions will be inturn consumed by Configuration Manager. > > > Additionally the placement of this header under "Include" dir will ma= ke these > > > macro's availale to other translation units of the platform built. > > > > > > (3) Introduced edk2-platforms/NXP/LX2160ARDB/AcpiTablesInclude > > > This is a placeholder for - OEM specific firmware acpi table generato= rs. > > > This also includes IP specific - DSDT/SSDT generators for the OEM's p= latform. > > > Currently Dsdt.asl is a place holder having only platform's clock rel= ated dsdt > > > properties for LX2160ARDB but it is intended to extend this "Dsdt.asl= " to hold > > > other table as well in next patch series. > > > > > > (4) Introduced a new "DYNAMIC_ACPI_ENABLE" flag to control DACPI fram= ework. > > > Currently this flag is used for LX2160ARDB and by default it is enabl= ed. > > > This flag can also extend to other fsl layerscape platforms in future= . > > > Changes can be referred under: > > > - LX2160ARDb.dsc > > > - LX2160ARDB.fdf > > > > > > (5) Introduced a "build.sh" script under edk2-platforms/NXP/ to autom= ate builds. > > > And also mandatorily need to support Dynamic ACPI framework for all f= sl platforms. > > > It exports build environment variables and also invokes "Env.sh". > > > > > > Vikas Singh (2): > > > Platform/NXP: Add Dynamic Acpi for layerscape platforms > > > Platform/NXP: Add OEM specific DSDT generator > > > > > > .../ConfigurationManagerDxe/ConfigurationManager.c | 843 +++++++++++= ++++++++++ > > > .../ConfigurationManagerDxe/ConfigurationManager.h | 153 ++++ > > > .../ConfigurationManagerDxe.inf | 52 ++ > > > .../ConfigurationManagerPkg.dec | 23 + > > > .../Include/PlatformAcpiTableGenerator.h | 20 + > > > Platform/NXP/Env.sh | 67 ++ > > > .../LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl | 40 + > > > .../LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl | 15 + > > > .../AcpiTablesInclude/PlatformAcpiDsdtLib.inf | 39 + > > > .../PlatformAcpiDsdtLib/RawDsdtGenerator.c | 146 ++++ > > > .../AcpiTablesInclude/PlatformAcpiLib.h | 24 + > > > Platform/NXP/LX2160aRdbPkg/Include/Platform.h | 246 ++++++ > > > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dec | 4 + > > > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 29 + > > > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 12 + > > > Platform/NXP/Readme.md | 35 +- > > > Platform/NXP/build.sh | 115 +++ > > > Silicon/NXP/LX2160A/LX2160A.dsc.inc | 9 + > > > 18 files changed, 1871 insertions(+), 1 deletion(-) > > > create mode 100644 Platform/NXP/ConfigurationManagerPkg/Configuratio= nManagerDxe/ConfigurationManager.c > > > create mode 100644 Platform/NXP/ConfigurationManagerPkg/Configuratio= nManagerDxe/ConfigurationManager.h > > > create mode 100644 Platform/NXP/ConfigurationManagerPkg/Configuratio= nManagerDxe/ConfigurationManagerDxe.inf > > > create mode 100644 Platform/NXP/ConfigurationManagerPkg/Configuratio= nManagerPkg.dec > > > create mode 100644 Platform/NXP/ConfigurationManagerPkg/Include/Plat= formAcpiTableGenerator.h > > > create mode 100755 Platform/NXP/Env.sh > > > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt= /Clk.asl > > > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt= /Dsdt.asl > > > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Plat= formAcpiDsdtLib.inf > > > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Plat= formAcpiDsdtLib/RawDsdtGenerator.c > > > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Plat= formAcpiLib.h > > > create mode 100644 Platform/NXP/LX2160aRdbPkg/Include/Platform.h > > > create mode 100755 Platform/NXP/build.sh > > > > > > -- > > > 2.7.4 > > >