Re: [edk2-devel] [PATCH v1 2/2] Platform/NXP: Add OEM specific DSDT generator

["Vikas Singh" <vikas.singh@puresoftware.com>]

On Tue, Jan 26, 2021 at 3:11 AM Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> Hi Vikas,
>
> On Mon, Jan 18, 2021 at 09:06 AM, Vikas Singh wrote:
>
> + // Add the dsdt aml code here, Currently NULL place holder.
> + *Table = (EFI_ACPI_DESCRIPTION_HEADER *)&dsdt_aml_code;
>
> Do you intend to process the DSDT data in this generator? If that is not the case, and you want to just collate the DSDT information, then an OEM specific RAW generator is not needed.
> You could try implementing a library that implements a function to return 'dsdt_aml_code'.  The Configuration Manager can then invoke this function from InitializePlatformRepository().
>

Sami, the idea here is to make Configuration Manager totally free from
any dependencies from any generator (standard or oem specific) because
this CM is generic and common for all FSL platforms. This kind of
framework is intentional to introduce OEM specific DSDT generators
keeping in mind that these generators can handle - DSDT fixups, ssdt
handling and any other modification which is platform specific in
nature.
I agree with your suggestion but more or less the current
implementation looks similar to your thought of "keeping an lib and CM
can get symbols using some function calls".
However our intention is to keep CM as an independent entity and
expect platforms to add/remove anything which is platforms. By doing
so every platform can have its own DSDT generator because DSDT
properties are very much private to a platform.

Let me know if you have any other improvement suggestions, and will be
happy to go along.

> Regards,
>
> Sami Mujawar