From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) by mx.groups.io with SMTP id smtpd.web09.8492.1611640452776177450 for ; Mon, 25 Jan 2021 21:54:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@puresoftware.com header.s=google header.b=LwX3HnOC; spf=pass (domain: puresoftware.com, ip: 209.85.161.47, mailfrom: vikas.singh@puresoftware.com) Received: by mail-oo1-f47.google.com with SMTP id n127so3853059ooa.13 for ; Mon, 25 Jan 2021 21:54:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=puresoftware.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WohGENoJWostmYN+Q2aZs6jSKSFK8D3OJpEt+R3jA8I=; b=LwX3HnOCZ86NcX9RBKUX8vJtsGWaoUd6cm/+dS5zd+j6tINdMd2Ye7eR8Cm0gLFcic mRGtdO6UtMbiRXVAAVTNWasCGMnQ64c2YtBgtt7/seVyXPpJ5mvfZ3HB+J7Kk0sBt5PW fVpaYItCB/z2ipFGuYZweUyo0/tDX85c1qdMQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WohGENoJWostmYN+Q2aZs6jSKSFK8D3OJpEt+R3jA8I=; b=fT5SUPEHyqvcQyCiEy+Fb1fTRGKTpMNE0a5Ds0DxeX8XABGLP5oRv4hO31Hpw9JxVa gHa/25gc3K5ar7FvUmJe4HcpKmpkd6D6fHbx7APUNrLMBL4rUfErbg8WKqPO4X1yZPGx h6btfR+GqYCp6S3wPRPDvs32gYC2d0heFj38NwEec9aSMB/MzzO0Snf6NCKaLJnUfMly U5M7Roi69rqSbcjKCB5RHFF0X13nGwZ7Vfuvji5gXrkc6OWWnjEPYTowkEAlcKsGJOBg cgUE7XoMCmzFAfelwWTgjHEgClzQL+mUCCekSz3wPzBquhQCkXYqmHF6DOtSG7sjUs3g hqUA== X-Gm-Message-State: AOAM531ZWkfFcINLkz91lK7dasSygYsk1FyDxJV3ExoYleDIQtjvyc3k 26kzk9zvIbZ8o9TSiVRrMhr/XcbDiGTgA80geow/JO3u/mg5iA== X-Google-Smtp-Source: ABdhPJx0Abne5Sw7osIkdOS8kIgyZIKHZLotTgYvTZNAZUw2UbU0BZ2ltAcIOSSkoh8LIojLdwZyKPgZC1KWw637abI= X-Received: by 2002:a4a:3052:: with SMTP id z18mr2866480ooz.34.1611640452099; Mon, 25 Jan 2021 21:54:12 -0800 (PST) MIME-Version: 1.0 References: <1610969261-24134-3-git-send-email-vikas.singh@puresoftware.com> <317.1611610873694713323@groups.io> In-Reply-To: <317.1611610873694713323@groups.io> From: "Vikas Singh" Date: Tue, 26 Jan 2021 11:23:45 +0530 Message-ID: Subject: Re: [edk2-devel] [PATCH v1 2/2] Platform/NXP: Add OEM specific DSDT generator To: Sami Mujawar Cc: devel@edk2.groups.io Content-Type: text/plain; charset="UTF-8" On Tue, Jan 26, 2021 at 3:11 AM Sami Mujawar wrote: > > Hi Vikas, > > On Mon, Jan 18, 2021 at 09:06 AM, Vikas Singh wrote: > > + // Add the dsdt aml code here, Currently NULL place holder. > + *Table = (EFI_ACPI_DESCRIPTION_HEADER *)&dsdt_aml_code; > > Do you intend to process the DSDT data in this generator? If that is not the case, and you want to just collate the DSDT information, then an OEM specific RAW generator is not needed. > You could try implementing a library that implements a function to return 'dsdt_aml_code'. The Configuration Manager can then invoke this function from InitializePlatformRepository(). > Sami, the idea here is to make Configuration Manager totally free from any dependencies from any generator (standard or oem specific) because this CM is generic and common for all FSL platforms. This kind of framework is intentional to introduce OEM specific DSDT generators keeping in mind that these generators can handle - DSDT fixups, ssdt handling and any other modification which is platform specific in nature. I agree with your suggestion but more or less the current implementation looks similar to your thought of "keeping an lib and CM can get symbols using some function calls". However our intention is to keep CM as an independent entity and expect platforms to add/remove anything which is platforms. By doing so every platform can have its own DSDT generator because DSDT properties are very much private to a platform. Let me know if you have any other improvement suggestions, and will be happy to go along. > Regards, > > Sami Mujawar