From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182])
 by mx.groups.io with SMTP id smtpd.web08.8578.1624026500235499551
 for <devel@edk2.groups.io>;
 Fri, 18 Jun 2021 07:28:20 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@puresoftware.com header.s=google header.b=TDCUSEP6;
 spf=pass (domain: puresoftware.com, ip: 209.85.167.182, mailfrom: vikas.singh@puresoftware.com)
Received: by mail-oi1-f182.google.com with SMTP id s17so1978217oij.11
        for <devel@edk2.groups.io>; Fri, 18 Jun 2021 07:28:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=puresoftware.com; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=7yc3Cp31SY/YnWnSbXHULjhSSVk/Vqs0KMg6xCvJ6BE=;
        b=TDCUSEP6gtwdKfmWyRmB0RTNnTBm1zmLM37A1YgGDTVUf1qrsw3XIpx7/Qyd6tKpE7
         2gFAgbJgr9pjL3xcYcq4s0hbKH0FaYWi1GfoZpm8+04gZNGV5IvbgCf3uvVjw/+hrt7u
         8CFEWhJZ3c/t1L2dfJ8gOBP2SkQS5PZcdCwTA=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=7yc3Cp31SY/YnWnSbXHULjhSSVk/Vqs0KMg6xCvJ6BE=;
        b=NuPgNVHjgczslRl0TaLo4S/mshH13BbN0VLZoVj81l2YSqSwHzwzYsgV9Tyc0uHK+U
         iy/p1KwylMuYMMuHKMfm4XdKpoC2nADK3OMe1kpmz0LG5bDHquZbmTnoKAKiKeCPr78W
         T6aaegWzj7oduiZvq66q+sQ1IznOia3RQWQvvwBJsnMiEs6CxFtiRQAFp4osmaIemQOK
         goGHYFBVzMFtdEvcYSS3vumXEhhTxpUBSjzIlKnYt0xbIa+Sf0BPWc4SSIRV2FhLZChN
         2F6jyB1cbll8JsiRb5KnwLfm9byW/gVjavVMpkrf6Tj/7pQ7ICmVOzT4veY59c0ujvgH
         qYdg==
X-Gm-Message-State: AOAM530jgtWxE+dD/NM2nvgg1MLLvIaBf1jnLFCTxloMebZ2Y5OwNE+N
	jlc+uydCxsrs4BXjgaGHpqB1hyFU/phvmvqaZyf1WQ==
X-Google-Smtp-Source: ABdhPJyoAfk4XPnokpLNTVb1yFX4rFFhu1enqWdFxiJ8RpxPpe1tY4gV9ycIxGLe9+P4NGQws8O7BmRzfT/L3rykz/Q=
X-Received: by 2002:aca:2804:: with SMTP id 4mr7313000oix.141.1624026499569;
 Fri, 18 Jun 2021 07:28:19 -0700 (PDT)
MIME-Version: 1.0
References: <20210611155200.15535-1-vikas.singh@puresoftware.com>
 <20210611155200.15535-3-vikas.singh@puresoftware.com> <20210614205931.it7nmbsqltxyuytd@leviathan>
In-Reply-To: <20210614205931.it7nmbsqltxyuytd@leviathan>
From: "Vikas Singh" <vikas.singh@puresoftware.com>
Date: Fri, 18 Jun 2021 19:57:53 +0530
Message-ID: <CADvVLtX3umZRswLxSz=0p=rFVpJnPrYUbqweDYXN9JJJ-Azi4g@mail.gmail.com>
Subject: Re: [PATCH V1 2/4] Silicon/NXP: Add support of SVR handling for LS1046FRWY
To: Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io, Sami Mujawar <sami.mujawar@arm.com>, meenakshi.aggarwal@nxp.com, 
	Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>, Varun Sethi <v.sethi@nxp.com>, 
	Arokia Samy <arokia.samy@puresoftware.com>, 
	Kuldip Dwivedi <kuldip.dwivedi@puresoftware.com>, ard.biesheuvel@arm.com, 
	Vikas Singh <vikas.singh@nxp.com>, Sunny Wang <Sunny.Wang@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, Jun 15, 2021 at 2:29 AM Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Fri, Jun 11, 2021 at 21:21:58 +0530, Vikas Singh wrote:
> > This change set intend to add a generic method to get
>
> Does it intend to add, or does it add?
>
> /
>     Leif
>

Leif, this patch adds a generic method to get the SVR details for LS1046A SoC.
I will do the suggested changes in subject and body of the commit.

I will share the updated V2 series shortly.

> > access to SoC's Silicon Version Register (SVR) and its
> > handling for LS1046aFrwy platform.
> >
> > Signed-off-by: Vikas Singh <vikas.singh@puresoftware.com>
> > ---
> >  Silicon/NXP/LS1046A/Library/SocLib/SocLib.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/Silicon/NXP/LS1046A/Library/SocLib/SocLib.c b/Silicon/NXP/LS1046A/Library/SocLib/SocLib.c
> > index 8fa6a7dd00..003f5bd82f 100644
> > --- a/Silicon/NXP/LS1046A/Library/SocLib/SocLib.c
> > +++ b/Silicon/NXP/LS1046A/Library/SocLib/SocLib.c
> > @@ -2,6 +2,7 @@
> >    SoC specific Library containg functions to initialize various SoC components
> >
> >    Copyright 2017-2020 NXP
> > +  Copyright 2021 Puresoftware Ltd
> >
> >    SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > @@ -64,6 +65,21 @@ SocGetClock (
> >    return ReturnValue;
> >  }
> >
> > +/**
> > +  Function to get SoC's System Version Register(SVR)
> > + **/
> > +UINT32
> > +SocGetSvr (
> > +  VOID
> > +  )
> > +{
> > +  LS1046A_DEVICE_CONFIG  *Dcfg;
> > +
> > +  Dcfg = (LS1046A_DEVICE_CONFIG  *)LS1046A_DCFG_ADDRESS;
> > +
> > +  return DcfgRead32 ((UINTN)&Dcfg->Svr);
> > +}
> > +
> >  /**
> >     Function to select pins depending upon pcd using supplemental
> >     configuration unit(SCFG) extended RCW controlled pinmux control
> > --
> > 2.25.1
> >