From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by mx.groups.io with SMTP id smtpd.web12.79.1610770110839559744 for ; Fri, 15 Jan 2021 20:08:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@puresoftware.com header.s=google header.b=VIO3HYWm; spf=pass (domain: puresoftware.com, ip: 209.85.167.179, mailfrom: vikas.singh@puresoftware.com) Received: by mail-oi1-f179.google.com with SMTP id 9so11835349oiq.3 for ; Fri, 15 Jan 2021 20:08:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=puresoftware.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jzSl1vWhig7sJef4b9+2B9feeYdatjOlu6VMlf9VptM=; b=VIO3HYWmuo02UKkHq00eW3kfBPcD4Vu/4OTcRUEvfkdScILBAhowrS89/KqzYwddYG W9Sa4ALGDSaYex+087jxqfoRLzj+QQWBTVvXnMVldtbRCAIoNGRoRtXDPx5vT6o9qYU7 PZDn+f/xWL5r94KhOH2jAkCByDoeJftXlZKzo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jzSl1vWhig7sJef4b9+2B9feeYdatjOlu6VMlf9VptM=; b=LTqqDMGy41jhuFPq5uVqy3dRa861apkPKJg1bDNwBWy9QZCRLi0npT8WcQRvFvzxVm 4Wz/ekTPfrYg3KysL1HN8yfXhjSxPbdmYpDXzkRWoCcZQbEIOc8u5e3lAJ3k3YS0fYV4 Ju7nr1xhdnbkgK/N8Pc0SwSFLBRA/GEmbOWhoOqqr4pgLDdUU4UqlhMwWyJrqbX6K7cs W4TckpPFN9s+wy18wrIXj+ICRQa+ev8/JC+o94QdGHN1UeJoOZ4rXmyNy680FH0pi/uV nN3+S7PRYjIKyO6UnNXh6PQ8HuEngFYXTQaHUQDDDXUhOnY0DmqsL/vXqZq024IXe0Sm mvSg== X-Gm-Message-State: AOAM530+hHQQ0BSQIQBqXw4qEtu7jf38FIO4RvpX7tpsdKmzgm/cGCQ9 kjrGiivmYomOYaetL0MeCi/HUFOJNM+2BbCRF1At/Q== X-Google-Smtp-Source: ABdhPJwWgbx2mkYOlRyAdyJsRQ0pOc3s+S60Pjdi0aKYdwQ/A0UhUO6yup+wWHPa6dS9QjugcZdCNQNaPrUp7niYOu4= X-Received: by 2002:aca:4f47:: with SMTP id d68mr7902920oib.135.1610770110113; Fri, 15 Jan 2021 20:08:30 -0800 (PST) MIME-Version: 1.0 References: <1609226758-19867-1-git-send-email-vikas.singh@puresoftware.com> <20210110023043.GJ1664@vanye> In-Reply-To: <20210110023043.GJ1664@vanye> From: Vikas Singh Date: Sat, 16 Jan 2021 09:38:03 +0530 Message-ID: Subject: Re: [PATCH v0] Dynamic ACPI framework for fsl layerscape platforms To: Leif Lindholm Cc: devel@edk2.groups.io, Sami Mujawar , meenakshi.aggarwal@nxp.com, Paul Yang , Augustine Philips , samer.el-haj-mahmoud@arm.com, Varun Sethi , Arokia Samy , Kuldip Dwivedi , ard.biesheuvel@arm.com, Vikas Singh Content-Type: text/plain; charset="UTF-8" On Sun, Jan 10, 2021 at 8:00 AM Leif Lindholm wrote: > > We usually start from v1 :) > > However, there is something weird with this set (like the missing 0/1, > 1/1 in the subject lines)- please make sure you follow the > instructions from > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers > when generating patches. Sure leif, I will send a new patch series starting with v1 early next week sometime. > > / > Leif > > On Tue, Dec 29, 2020 at 12:55:57 +0530, Vikas Singh wrote: > > This patch series sets the foundation of Dynamic ACPI framework > > for fsl layerscape platforms. > > In order to achieve : > > - Configurable firmware builds. > > - Unify firmware build for similar platforms. > > - Minimize/eliminate human induced errors. > > - Ability to validate, and generate firmware that complies with > > relevant specifications > > this change set introduced following changes in below defined order > > under edk2-platforms/NXP for LX2160ARDB. > > > > (1) Introduced edk2-platforms/NXP/ConfigurationManager > > It creates the platform repositories dynamically during build time and > > initializes with platform specific information and serves all requestes > > from OEM/standard firmware table generators. > > This Configuration Manager will be common for all fsl platforms. > > > > (2) Introduced edk2-platforms/NXP/LX2160ARDB/Include/Platform.h > > It has all the declarations & definitions specified for the platforms. > > These macros will be consumed by Configuration Manager. > > Additionally the placement of this header under "Include" dir will make > > these macro's availale to other translation units of the platform built. > > > > (3) Introduced edk2-platforms/NXP/LX2160ARDB/AcpiTablesInclude > > This is a placeholder for - OEM specific firmware acpi table generators. > > This also holds IP specific - DSDT/SSDT generators for the OEM's platform. > > Currently Dsdt.asl is a place holder having only platform's clock related > > dsdt properties for LX2160ARDB but it is intended to extend this Dsdt.asl > > to hold other table as well in next patch series. > > > > (4) Introduced a new "DYNAMIC_ACPI_ENABLE" flag to control DACPI framework for > > LX2160ARDB platform. > > By default it is enabled and can extend to other fsl platforms in future. > > Changes can be referred under : > > - LX2160ARDb.dsc > > - LX2160ARDB.fdf > > > > (5) Introduced a "build.sh" script under edk2-platforms/NXP/ to automate the > > fsl platforms build system. And also mandatorily need to support Dynamic > > ACPI framework for fsl platforms. It exports build environment variables > > and also invokes "Env.cshrc". > > > > Vikas Singh (1): > > Platform/NXP: Add Dynamic Acpi for layerscape platforms > > > > .../ConfigurationManager/ConfigurationManager.dec | 24 + > > .../ConfigurationManager.dsc.inc | 21 + > > .../ConfigurationManagerDxe/ConfigurationManager.c | 709 +++++++++++++++++++++ > > .../ConfigurationManagerDxe/ConfigurationManager.h | 229 +++++++ > > .../ConfigurationManagerDxe.inf | 52 ++ > > .../Include/PlatformAcpiTableGenerator.h | 20 + > > Platform/NXP/Env.cshrc | 73 +++ > > .../LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl | 40 ++ > > .../LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl | 15 + > > .../AcpiTablesInclude/PlatformAcpiDsdtLib.inf | 39 ++ > > .../PlatformAcpiDsdtLib/RawDsdtGenerator.c | 146 +++++ > > .../AcpiTablesInclude/PlatformAcpiLib.h | 24 + > > Platform/NXP/LX2160aRdbPkg/Include/Platform.h | 244 +++++++ > > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dec | 6 +- > > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 30 + > > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 12 + > > Platform/NXP/build.sh | 121 ++++ > > 17 files changed, 1804 insertions(+), 1 deletion(-) > > create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManager.dec > > create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManager.dsc.inc > > create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > > create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h > > create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > > create mode 100644 Platform/NXP/ConfigurationManager/Include/PlatformAcpiTableGenerator.h > > create mode 100755 Platform/NXP/Env.cshrc > > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl > > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl > > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf > > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib/RawDsdtGenerator.c > > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiLib.h > > create mode 100644 Platform/NXP/LX2160aRdbPkg/Include/Platform.h > > create mode 100755 Platform/NXP/build.sh > > > > -- > > 2.7.4 > >