From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by mx.groups.io with SMTP id smtpd.web12.2351.1612941142764234397 for ; Tue, 09 Feb 2021 23:12:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@puresoftware.com header.s=google header.b=npMdjIAc; spf=pass (domain: puresoftware.com, ip: 209.85.167.174, mailfrom: vikas.singh@puresoftware.com) Received: by mail-oi1-f174.google.com with SMTP id h6so992156oie.5 for ; Tue, 09 Feb 2021 23:12:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=puresoftware.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P2YVLuNPfMKmZq6uF3j44APlCh+Z4G+VPsqYnAHd0P8=; b=npMdjIAcRNY5XSsRVz9K7v157vOozh4T16jN8nXc8coT+6x3OQdpr6DzTP4R+ql+Gq jxqjEq6/WDHo+UVTMV0RbuQWzJjf4VmRPNeeD/FLDtJSPi5IU3Sds74AiNzOUt43prd4 ruN82JmemqARb2sVDnua3dKu3x2t07pmiviXQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P2YVLuNPfMKmZq6uF3j44APlCh+Z4G+VPsqYnAHd0P8=; b=XfNmdADWr/FT8uTl7i2bgpsYeuNXR31bd+3KLJ/5K4laKVA/MeMeLlL2G3+wrEuxeK ZlqnbmYRTgvCd91QJZQbUUPdyUsfgtEo9W9HrTFnUzx/VsB/i6SLMtmKZfRIRqrubXwS U/xQEaI2qMDsqkIxeqSov8ImBRbCb49lp2HfwPIeokolzQTXtgO7KfWIFExTItYz3Kkk hhrc2gwDsSBt1Wg0LdRM/ytmzypEQNZuFpyGLquOgXkBSsJv+Pj9TfXsGBtTCpM1vABN jyUvaEXzA4XFC9kv3XRZqsyfPs/ikMRU4D+W3Hk+qQFA15F8mWCJIJ/7NtRjrtroyVjY 5PRg== X-Gm-Message-State: AOAM533MJ92VhVONuIKa6lTghsN6FOuUP+PxfaJceL1ogB9qVoFL219h 3e9pziGDfKUBdM2yqO2mPAkEC4wiZyg4kxfbfD1VYg== X-Google-Smtp-Source: ABdhPJx65RcdeRCVQGEwOZ/qW6guMPt0QPyUBJooFbm6qisPAraSAeA5Kigmdl5vg0aleVe1ILhhVRP4yqnwf8NLddc= X-Received: by 2002:a54:478c:: with SMTP id o12mr1136644oic.28.1612941142120; Tue, 09 Feb 2021 23:12:22 -0800 (PST) MIME-Version: 1.0 References: <1609226758-19867-1-git-send-email-vikas.singh@puresoftware.com> <1609226758-19867-2-git-send-email-vikas.singh@puresoftware.com> <20210110032612.GK1664@vanye> <20210118165530.GX1664@vanye> <20210126111946.GN1664@vanye> In-Reply-To: From: "Vikas Singh" Date: Wed, 10 Feb 2021 12:42:00 +0530 Message-ID: Subject: Re: [PATCH v0] Platform/NXP: Add Dynamic Acpi for layerscape platforms To: Leif Lindholm Cc: devel@edk2.groups.io, Sami Mujawar , meenakshi.aggarwal@nxp.com, Paul Yang , Augustine Philips , samer.el-haj-mahmoud@arm.com, Varun Sethi , Arokia Samy , Kuldip Dwivedi , ard.biesheuvel@arm.com, Vikas Singh Content-Type: text/plain; charset="UTF-8" On Wed, Jan 27, 2021 at 12:21 PM Vikas Singh wrote: > > On Tue, Jan 26, 2021 at 4:49 PM Leif Lindholm wrote: > > > > Hi Vikas, > > > > On Tue, Jan 19, 2021 at 10:11:43 +0530, Vikas Singh wrote: > > > > > > > +/** A helper macro for returning configuration manager objects > > > > > > > +*/ > > > > > > > +#define HANDLE_CM_OBJECT(ObjId, CmObjectId, Object, ObjectCount) \ > > > > > > > + case ObjId: { \ > > > > > > > + CmObject->ObjectId = CmObjectId; \ > > > > > > > + CmObject->Size = sizeof (Object); \ > > > > > > > + CmObject->Data = (VOID*)&Object; \ > > > > > > > + CmObject->Count = ObjectCount; \ > > > > > > > + DEBUG (( \ > > > > > > > + DEBUG_INFO, \ > > > > > > > + #CmObjectId ": Ptr = 0x%p, Size = %d, Count = %d\n", \ > > > > > > > + CmObject->Data, \ > > > > > > > + CmObject->Size, \ > > > > > > > + CmObject->Count \ > > > > > > > + )); \ > > > > > > > + break; \ > > > > > > > + } > > > > > > > > > > > > This is code obfuscation. Please don't invent your own programming > > > > > > languages. In C, the case, the start bracket, the break and the end > > > > > > bracket always go inline. > > > > > > The rest would be better as a static helper function than a macro. > > > > > > > > > > > Leif, changes are in accordance with : > > > > > https://raw.githubusercontent.com/tianocore-docs/Docs/master/Specifications/CCS_2_1_Draft.pdf > > > > > > > > Do you mean 5.5.2.1: > > > > Functional macros are generally discouraged. > > > > ? > > > > > > Leif + Sami, I was referring section 5.7.3.7, since you commented on > > > switch case & break statement. > > > However keeping section 5.5.2.1 in consideration, I have done few > > > changes and shared updated V1 series. > > > Could you please have a look on it and revert, if in case you have any concerns. > > > > I have not seen any update? > > > > Please have a look at Sami's updates to the ARM platform code, which I > > merged yeaterday. > > > > Best Regards, > > > > Leif > > > Leif , I have sent an updated V2 patch series today. FYI. > > Thnx. Hi Leif, Any Update on V2 patch series that I have shared to you at the end of Jan 2021. I did not receive any comments (if any). Thnx !! Vikas Singh