From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=moorthy.baskaravenkatraman-sambamoorthy@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 57CF5210E0F8E for ; Fri, 1 Jun 2018 05:34:33 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id j15-v6so2385706wme.0 for ; Fri, 01 Jun 2018 05:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=J9FL1eNwUK4JpmC9jvB3z7/JqcLC8SHHIta1UiJZXwI=; b=XZ/TCZuk+GP4cPXRq5+NEtaYOgQecHb3WDRxwlnLrXSfTLXyivt1zUpAAanqQJ2LKT O6E7kKFyv35o8DwHM07QmX+LBGAdU2+Q5kFbGeFZEUUXPsATY8nBJm02i1DyT0xkMykv TWVicmQRNFSfowu/vHm5HRqBLJpJwreNUVssY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=J9FL1eNwUK4JpmC9jvB3z7/JqcLC8SHHIta1UiJZXwI=; b=M/nFwT53N6VvvAjwmPlYyKIWqw4ePxrkcfYCLrTLbhKA2R3CaIMBfWMmVd4Pv+qaZG EXQ06TIU3jFcjLF3fFwQB72SeuQRtZzezjxMdC7yliy+o28CCpxKZw/FtAVkzGABQYk2 2txdYae/rd+8T+MsXoJWnjfV96rYuJ2JWjwhekvRi/VDUb8qqBUvAX1fvL5waVceSDt9 24/c4sjo8Kyf1tpv1mKIBloM8saQy8W2zOIpnxqsDdxwwIgJQzGNMuVySDXrbXvike+K JEYUnnZHJ0IRmCkXStYopgg3eFHBT2BN7e011ho+hnBW/wZkbKvnQ+E499xdZqox2bm5 pBEQ== X-Gm-Message-State: APt69E3S7ssLQYcVyAyZ5urivYe5CuzrpwUsNaeY5YxmPZgl83EzFHpy y8E3SlMA+3pZ2tip6csdrdI3OrH0e2OsMdy3xM6N+XZy X-Google-Smtp-Source: ADUXVKKweqMZpqPnAAhtQQ3kqfydRreRdLsym2hDnZtljqOWkpHhSNrp2cMrQ8HAfU4uDRud8iQ+gzRiSj3udJo0NBk= X-Received: by 2002:a1c:ea9b:: with SMTP id g27-v6mr2381377wmi.21.1527856471611; Fri, 01 Jun 2018 05:34:31 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:91c2:0:0:0:0:0 with HTTP; Fri, 1 Jun 2018 05:34:31 -0700 (PDT) In-Reply-To: References: From: Moorthy Baskaravenkatraman Sambamoorthy Date: Fri, 1 Jun 2018 18:04:31 +0530 Message-ID: To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Kalyan Kumar Nagabhirava X-Content-Filtered-By: Mailman/MimeDel 2.1.26 Subject: Re: [PATCH 1/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform * DevicePathLib library class added in DxeMain * NvVarStoreFormattedLib added in VariableRuntimeDxe * DevicePathLib and PcdLib library classes added in DevicePathExe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 12:34:33 -0000 Content-Type: text/plain; charset="UTF-8" Sorry for that. I have mistakenly followed the same template used for the last reviewed RDKPkg upstream. Let me remove that field and send for review again. Regards, Moorthy On 1 June 2018 at 17:45, Ard Biesheuvel wrote: > On 1 June 2018 at 14:14, Moorthy Baskaravenkatraman Sambamoorthy > wrote: > > Hi Ard, > > > > RDK package Secure boot and DRI application for QEMU platform were > > up-streamed by Kalyan under edk2-platforms. Now, I'm continuing the same > for > > further maintenance. > > > > That is fine. But that does *not* allow you to add my reviewed-by > under a patch that I have never seen in my life. > > > On 1 June 2018 at 17:34, Ard Biesheuvel > wrote: > >> > >> On 1 June 2018 at 13:03, Moorthy Baskaravenkatraman > >> wrote: > >> > Contributed-under: TianoCore Contribution Agreement 1.1 > >> > Signed-off-by: Moorthy Baskaravenkatraman > >> > > >> > Reviewed-by: Ard Biesheuvel > >> > >> Excuse me? I don't remember reviewing these changes. > >> > >> > --- > >> > Platform/Comcast/RDKQemu/RDKQemu.dsc | 8 +++++++- > >> > 1 file changed, 7 insertions(+), 1 deletion(-) > >> > > >> > diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc > >> > b/Platform/Comcast/RDKQemu/RDKQemu.dsc > >> > index 45feeec8764b..1301c5555efe 100644 > >> > --- a/Platform/Comcast/RDKQemu/RDKQemu.dsc > >> > +++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc > >> > @@ -251,6 +251,7 @@ [Components.common] > >> > MdeModulePkg/Core/Dxe/DxeMain.inf { > >> > > >> > > >> > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/ > DxeCrc32GuidedSectionExtractLib.inf > >> > + > >> > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > >> > } > >> > MdeModulePkg/Universal/PCD/Dxe/Pcd.inf { > >> > > >> > @@ -265,6 +266,7 @@ [Components.common] > >> > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > { > >> > > >> > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > >> > + > >> > NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/ > NvVarStoreFormattedLib.inf > >> > # don't use unaligned CopyMem () on the UEFI varstore NOR flash > >> > region > >> > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > >> > } > >> > @@ -326,7 +328,11 @@ [Components.common] > >> > # > >> > # Bds > >> > # > >> > - MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > >> > + MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf { > >> > + > >> > + > >> > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > >> > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > >> > + } > >> > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > >> > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > >> > > >> > MdeModulePkg/Universal/DriverHealthManagerDxe/ > DriverHealthManagerDxe.inf > >> > -- > >> > 2.17.0 > >> > > >> > _______________________________________________ > >> > edk2-devel mailing list > >> > edk2-devel@lists.01.org > >> > https://lists.01.org/mailman/listinfo/edk2-devel > > > > > > > > > > -- > > Regards, > > Moorthy > -- Regards, Moorthy