From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::335; helo=mail-wm1-x335.google.com; envelope-from=pgeorgi@google.com; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 17F83211575ED for ; Wed, 26 Sep 2018 08:59:12 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id r1-v6so15458330wmh.0 for ; Wed, 26 Sep 2018 08:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AzM8VM6ew2LaG7JgoYCIUo9QCltIPstIDMbWYx84eZ8=; b=fASTZ8RdTres4ulNnn4y6xtZm9mYS4UOk59YoWsklDeHWuiT0t1H1gyY03GkitdlLz hxamPMyAusIsWcrkCmw01qnzMSFoisDjAvCwp0AP1WtJe+YeL8K5bw7F4xhqEcWscdGd iOh6BMA2m10Kfu74IWCTbzBxtIRH8LUF6iEob/ihVY8HjmB5ckaAVR1vuydQ3bewH5v5 K5uosIWlmb7vdwlp3ZDhxaK3Sel0yza0uesKVkG5GtuN0tJ1MzUyXoe/49mBWkI/eqpP wJjyJacNxclXSPLrtbJzHL/ES6eoSewRifabnYW+Lxch26WozCHAk+CVc+XWPRuvlPaD KBUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AzM8VM6ew2LaG7JgoYCIUo9QCltIPstIDMbWYx84eZ8=; b=p0f6AcyadL7jEC2DiQ429er4+J/oQ/Ct6dyJ8TXLpq1uDQ+zb5FvwDa/S1Lq3CcePK M+pUDV3udRfnhe9mHER+pC3ZdvmFdoAXPPBoQrZZbUFcHcVbWVcpg4qUxH6H4cEuX00i UzNUADwS/R2GS4XG5ckZp/SnbsLfLPDvGvOSHH9AToBOUvjy4olJwiJUEyjS3r8PFt+P fQf0D0COsQgmha21VyQj3a2pDhIR6x07hGPcCk2FdofzfdUMrabw6GmPUEz95ZSkRyrq 6nJlq7uVcNAlRDQFiUnvk8k2CYhbQ9UYaJqhHYMiSowqOeIMPBP78JrjsP8bQ/dG3L3B EooA== X-Gm-Message-State: ABuFfoj3wGqMAhIYCAgCdrmYuIOgUDjBfTivB/K3/Yd2jEchlmqm5YcR kcfwrykr7UOfFmMRrl7FEvLLxm78/+8RQ8fieGUKIw== X-Google-Smtp-Source: ACcGV63ROtSF0ZlS/iTGOfGgClwMOOj8gaq7rynqat7BSrp4s7KvdgevxxuIpIh2F29Qewk9S693lRKwuknhAtG8A3k= X-Received: by 2002:a1c:820d:: with SMTP id e13-v6mr4980956wmd.91.1537977550655; Wed, 26 Sep 2018 08:59:10 -0700 (PDT) MIME-Version: 1.0 References: <20180918133203.192779-1-pgeorgi@google.com> <20180918133203.192779-3-pgeorgi@google.com> <5608C728-C8C9-4D20-8C4D-FEC4FA974BA6@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AD9948A@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AD9948A@shsmsx102.ccr.corp.intel.com> From: Patrick Georgi Date: Wed, 26 Sep 2018 17:58:58 +0200 Message-ID: To: jiewen.yao@intel.com Cc: "Desimone, Nathaniel L" , edk2-devel@lists.01.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH 3/3] IntelFsp2Pkg: Tell git to format SplitFspBin.py with native newlines X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 15:59:13 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I'm fine with discarding 1/3 and 3/3. 2/3 was already merged by Chasel Chui (commit 9062ab47870ea728307e32cdd939586a4ec67fc6), so from my point of view, that patch set is taken care of. Thanks, Patrick Am Mi., 26. Sep. 2018 um 05:13 Uhr schrieb Yao, Jiewen : > Hi Patrick > Do you agree that we only need merge 2/3 and discard 1/3 and 3/3? > > I will push 2/3 after get your confirmation. > > Thank you > Yao Jiewen > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Desimone, Nathaniel L > > Sent: Thursday, September 20, 2018 12:38 PM > > To: Patrick Georgi > > Cc: edk2-devel@lists.01.org > > Subject: Re: [edk2] [PATCH 3/3] IntelFsp2Pkg: Tell git to format > SplitFspBin.py > > with native newlines > > > > Hi Patrick, > > > > > If the autoconversion is not considered good enough, I'd propose > keeping > > out patch 1 of this series that adds the #! line and the executable bit= , > and > > instead expect people to always call the script with "python > > $path/SplitFspBin.py" to keep confusion at a minimum. > > > > There was quite a debate on this a few years ago. Without getting into > the > > details, the decision was made that people on Windows platforms would s= et > > core.autocrlf=3Dfalse and that source code would be stored in CR-LF for= mat. > > Per your recommendation, it sounds like we should only merge patch 2 > then. > > > > Thanks, > > Nate > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > --=20 Google Germany GmbH, ABC-Str. 19, 20354 Hamburg Registergericht und -nummer: Hamburg, HRB 86891, Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado