From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=pgeorgi@google.com; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4DA8A21AE30DB for ; Tue, 18 Sep 2018 08:53:43 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id j192-v6so3449585wmj.1 for ; Tue, 18 Sep 2018 08:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LUC2gkdonBcbkkQoyaRTpdzXTz4VGpn4plysIvnNSHU=; b=dNFA+EplAGQCl3hiJHT1mBsaOkD11fGLE4Gi1/nNnwYsANaiENafwlQn3l0SmUUMt6 tXPiGgHcz/Pj/C8GLfckhydjE4t+HjHMqgvEbFPyqpTZsQP3zqmX9/ToYhxA7rekCdV0 NEaKNGxX9ZlXUkCrkuZ7hDg2oKrvDbLw6BvFEM2xNjyoZ+uWqJNtRv2FyiY68B65HEJ8 b6HngeTY86b4VPzYQWIlm7xpHmWimA9KROofoK2RtkxMg/A3KkGb29K00LnXiQsYntq/ CAQe7HbMCCn3YBHtyZZ5bee7GSosonEFXRLohJb25Wxc2JSoDOoGCFDudI2ZI5bHF34p Rgaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LUC2gkdonBcbkkQoyaRTpdzXTz4VGpn4plysIvnNSHU=; b=otVlb3NpdsoMkIccyReoIV+F4ruLHol+DxyI9w1LyDcMocUjHgBWjTlyh8f+Hcub5g IeZC8o4NYTm3aeD+d5YQ9h0hyh6y/sE42QO1wDo8e3MN1U4XlQSOQAunEREFYU9nr5g9 1ObC/yYYBSA+0NlJcI+Bke047yF+xq7y+BTio653kIyXIoMtUW+wNG7EtqoGeXk4DYIe 0vDhlaeIfhqp0HT/F/bw+czNs3iNPEtlbHzjroMbuClQkigCePdOguOXV2S3QAqV7n1S JcPDbfN1RNGKk7vTpvSAl1TVTMRGV6oEGWdfVNVII42pqXlaWjZLvxzveLU3WI/cmTcQ ZNVw== X-Gm-Message-State: APzg51DbOEuRZ41kiTlN8kvO1QNGTYbcq0xCvAsYHhmPjJGrEElbr5VI tmyMAOY+nzEYbuvPdV6b4uFzXRQF4pvvbgtmSGhhEw== X-Google-Smtp-Source: ANB0VdaGy3Ly4O51eRRum0Hw97NjHi8GAb4DHfIVAryEDNoNcNBCyoQ8IRUWuYirFiDn8LhuVkj58SDkX1COUwJphSA= X-Received: by 2002:a1c:7305:: with SMTP id d5-v6mr16507174wmb.53.1537286021328; Tue, 18 Sep 2018 08:53:41 -0700 (PDT) MIME-Version: 1.0 References: <20180918133203.192779-1-pgeorgi@google.com> <20180918133203.192779-3-pgeorgi@google.com> <5608C728-C8C9-4D20-8C4D-FEC4FA974BA6@intel.com> In-Reply-To: <5608C728-C8C9-4D20-8C4D-FEC4FA974BA6@intel.com> From: Patrick Georgi Date: Tue, 18 Sep 2018 17:53:26 +0200 Message-ID: To: "Desimone, Nathaniel L" Cc: edk2-devel@lists.01.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH 3/3] IntelFsp2Pkg: Tell git to format SplitFspBin.py with native newlines X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 15:53:43 -0000 Content-Type: text/plain; charset="UTF-8" Am Di., 18. Sep. 2018 um 17:10 Uhr schrieb Desimone, Nathaniel L < nathaniel.l.desimone@intel.com>: > The EDK2 coding standard specifies that all files should be in CR-LF > format. Please see the following: > https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards-specification/content/5_source_files/#51-general-rules Thank you for the pointer! Is the .gitattributes file alone sufficient? > The conversion of the file is for the repo-internal representation (which defaults to LF given git's origin on unix-like systems). According to the docs, due to the "text" property it should still checkout with CRLF on CRLF platforms (as long as core.eol is kept at its default "native" value, otherwise core.eol and core.autocrlf will influence that decision). I don't have such a system around, so my ability to test is limited. The problem with having CRLF in the file on unixoids is that it elicits an error like the following when calling it directly: $ IntelFsp2Pkg/Tools/SplitFspBin.py /usr/bin/env: 'python\r': No such file or directory If the autoconversion is not considered good enough, I'd propose keeping out patch 1 of this series that adds the #! line and the executable bit, and instead expect people to always call the script with "python $path/SplitFspBin.py" to keep confusion at a minimum. Regards, Patrick