From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400c:c08::22f; helo=mail-ua0-x22f.google.com; envelope-from=julien.grall@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-ua0-x22f.google.com (mail-ua0-x22f.google.com [IPv6:2607:f8b0:400c:c08::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 18AA521FCA272 for ; Wed, 1 Nov 2017 05:43:00 -0700 (PDT) Received: by mail-ua0-x22f.google.com with SMTP id z4so1449435uaz.5 for ; Wed, 01 Nov 2017 05:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FD6Uwr7J9DdEqrzt3Ao3wmbrWBLPlPMLbgNK02DrULg=; b=QJ2dfdjgNiombFIMsZZiZBWgrHHAHhV6jUyjg9Yo5ym1tmByTP5/sBcXtyM6ngjxGX XjoScbviO+zp465i99oSsGTY8nViQa2LTJeMpSWFdaabCj/2Bt1Y88//B1+ynbFk9HgQ u5NeTXsoqp3RXm9Tg0ezakwpT1dAxIiiTc3SQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FD6Uwr7J9DdEqrzt3Ao3wmbrWBLPlPMLbgNK02DrULg=; b=SkvVO1r0WLhc8y6Nvo7rvc68w7oXA5hv2/YOSspgo3kB2krbl25VCN7nD0bd0Hlrce aG5RJZQPy81oI2mzANTOa4P/yMQMw7LCJpVXD0RECw8Kfh3O+HBdYj/knDB6k/T4Zx+l NBauxXtUeFqsdmp3imQg+86L5WN+qKy40U6ef09aw30dW0NmBxDIj41JowiG8xGOAF8g CTKAUFnvzndCeKq7AlUSmDUett0Lk7d3Unq6ThUlscVODNQW8vfHxUqzfWYbl+wK6+9D EicN0Pl2wbq1vu678vEhNx2w2IF91a2SzMki4QVXxbAaFRvjnMeZO6mk4woZRec98RLn 9B+g== X-Gm-Message-State: AMCzsaWFnK5pMdMY8atzAD//hYktjepPHfNmVXxXA8J4fb32L4XBN7kK 2jHr2icAd+CiICmUvcCbuOmc+IRSbLn/svNzNrCcLg== X-Google-Smtp-Source: ABhQp+R0PdmzzuAPVDRXuX7tPMpv5bSzcWpObPFUhA9HgnxITzZ4qGnqtkNTZB+Fg+utZHpo1Ukh8H2bpCrAWK5NYfA= X-Received: by 10.176.74.139 with SMTP id s11mr3940937uae.129.1509540412556; Wed, 01 Nov 2017 05:46:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.16.12 with HTTP; Wed, 1 Nov 2017 05:46:51 -0700 (PDT) In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B9AF405@shsmsx102.ccr.corp.intel.com> References: <7516a301-dfbb-5bd4-5e1e-ccd18c26db30@linaro.org> <74e0ac36-195f-9275-922e-e499a513569f@redhat.com> <32b3c432-7f17-c387-5334-a6826d6fa769@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B9AEB7F@shsmsx102.ccr.corp.intel.com> <68c947a5-34f9-f91e-3670-88182163a2f2@redhat.com> <5a867af3-0a19-b7b2-f656-55dde0df1a75@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B9AF405@shsmsx102.ccr.corp.intel.com> From: Julien Grall Date: Wed, 1 Nov 2017 12:46:51 +0000 Message-ID: To: "Zeng, Star" Cc: Laszlo Ersek , edk2-devel-01 , "heyi.guo@linaro.org" , "Ni, Ruiyu" , Anthony PERARD , Leif Lindholm , Ard Biesheuvel Subject: Re: Xen Console input very slow in recent UEFI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2017 12:43:01 -0000 Content-Type: text/plain; charset="UTF-8" Hi Zeng, On 30 October 2017 at 01:09, Zeng, Star wrote: > I do not think SerialDxe should handle EFI_INVALID_PARAMETER return value from SerialPortSetAttributes(). > If the EFI_INVALID_PARAMETER is because of Timeout value, the Timeout value definitely should not be updated. > If the EFI_INVALID_PARAMETER is because of other parameters, the status should be returned to the caller. Fair enough. Are you going to resend the change you suggest with a commit message? Cheers, -- Julien Grall