Done.

-Chema


On Mon, Jan 8, 2018 at 5:42 PM, Gao, Liming <liming.gao@intel.com> wrote:
> Chema:
>   Sorry for late response. I think the change is good. For windows and gcc, how about use the same error message for the unknown or unsupported arch?
>
> +else
> +$(error Bad HOST_ARCH)
> endif
>
> +!ELSE
> +!ERROR "Unknown HOST_ARCH variable"
>  !ENDIF
>
> Thanks
> Liming
>>-----Original Message-----
>>From: chemag@gmail.com [mailto:chemag@gmail.com] On Behalf Of Chema
>>Gonzalez
>>Sent: Friday, January 05, 2018 3:48 AM
>>To: Gao, Liming <liming.gao@intel.com>
>>Cc: edk2-devel@lists.01.org
>>Subject: Re: FW: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH in
>>C Makefile (#122)
>>
>>Added similar changes to `BaseTools/Source/C/Makefiles/header.makefile`.
>>
>>Thanks,
>>-Chema
>>
>>
>>On Fri, Dec 29, 2017 at 7:17 AM, Gao, Liming <liming.gao@intel.com> wrote:
>>> I suggest GNUmakefile also adds this condition to report error message if
>>HOST_ARCH is not set correctly.
>>>
>>>> -----Original Message-----
>>>> From: chemag@gmail.com [mailto:chemag@gmail.com] On Behalf Of
>>Chema Gonzalez
>>>> Sent: Friday, December 29, 2017 6:19 AM
>>>> To: edk2-devel@lists.01.org
>>>> Cc: Gao, Liming <liming.gao@intel.com>
>>>> Subject: Fwd: FW: [tianocore/edk2] BaseTools: Barf on unknown
>>HOST_ARCH in C Makefile (#122)
>>>>
>>>> Sure.
>>>>
>>>> Thanks,
>>>> -Chema
>>>>
>>>> ---------- Forwarded message ----------
>>>> From: Gao, Liming <liming.gao@intel.com>
>>>> Date: Wed, Dec 27, 2017 at 5:48 PM
>>>> Subject: FW: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH in
>>>> C Makefile (#122)
>>>> To: "chemag@gmail.com" <chemag@gmail.com>
>>>>
>>>>
>>>> Could you send patch to edk2-devel@lists.01.org?
>>>>
>>>>
>>>>
>>>> From: chemag [mailto:notifications@github.com]
>>>> Sent: Thursday, December 28, 2017 9:26 AM
>>>> To: tianocore/edk2 <edk2@noreply.github.com>
>>>> Cc: Subscribed <subscribed@noreply.github.com>
>>>> Subject: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH in C
>>>> Makefile (#122)
>>>>
>>>>
>>>>
>>>> I was getting HOST_ARCH set using the linux arch name ("x86_64"), which
>>>> is different from the MS one ("X64").
>>>>
>>>> It is not clear anyway we can proceed without valid build variables
>>>> (ARCH_INCLUDE, BIN_PATH, LIB_PATH, SYS_BIN_PATH, and
>>>> SYS_LIB_PATH).
>>>>
>>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>>> Signed-off-by: Chema Gonzalez chemag@gmail.com
>>>>
>>>> ________________________________
>>>>
>>>> You can view, comment on, or merge this pull request online at:
>>>>
>>>>   https://github.com/tianocore/edk2/pull/122
>>>>
>>>> Commit Summary
>>>>
>>>> BaseTools: Barf on unknown HOST_ARCH in C Makefile
>>>>
>>>> File Changes
>>>>
>>>> M BaseTools/Source/C/Makefiles/ms.common (6)
>>>>
>>>> Patch Links:
>>>>
>>>> https://github.com/tianocore/edk2/pull/122.patch
>>>> https://github.com/tianocore/edk2/pull/122.diff
>>>>
>>>> —
>>>> You are receiving this because you are subscribed to this thread.
>>>> Reply to this email directly, view it on GitHub, or mute the thread.