From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400d:c0d::230; helo=mail-qt0-x230.google.com; envelope-from=chemag@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-qt0-x230.google.com (mail-qt0-x230.google.com [IPv6:2607:f8b0:400d:c0d::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EA3C021E48F20 for ; Tue, 23 Jan 2018 17:12:18 -0800 (PST) Received: by mail-qt0-x230.google.com with SMTP id i1so6453753qtj.8 for ; Tue, 23 Jan 2018 17:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=q2Wyq1B/FkbmY3LwXXXypEPIW5gtqLlrBVx2jx/So+I=; b=aRkgoremSNVvt7BWoSfFgtAIS/ZLHNIDsn6aw7J9SggxrttxobLbxB98Pv1KPfoWAN Espxrsz/5qnZ+ZVBG6eEfOUBTX4orYM3eGflNT7SPkOpeMkxtaxPbamm+d+BiXj5SVaI ELOcab2Od8PUgQ52SW4kyhpcxdi9jWTHKwR4KWnteJwd/GNWkcSqNe5G3iX5vrgo/m6A 49yAnvg8wNmc8hS5J6NEIHPx4+6CL/NuUZRHNpAh4LpKLO1BhQiKffq+sWbUpY9E9EYk N2aYA7updbpI97AUC+2eMMza6JqfzmVSiwyNWdLK9p9jtMCQHYmEYH2PMk/GYtLASBAM itGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=q2Wyq1B/FkbmY3LwXXXypEPIW5gtqLlrBVx2jx/So+I=; b=CNCc2O9vvaBzZDmZquh6MybIy+nO6vdgbRnBIze6wmUpTor6mnX3YeGNaXFMztY2LF cg1zhWtDFg0YorLDPqqIKSo4d72ekhKMImS9w4DRN/VF0Fru8skvDud36vAE9UCEMpc0 EFATF8HUZwjwZFjCwpYt+QbNCxu4/Ka0ru9FSzvNblOUwaBFsys32nQbkxOA7GEZK3e3 XeKQDi7QIFU0IakgQGUacNy7BTp98X5ChylxvmOdECZ7ES/g3xF7whwQPL8FjjM3QyYA tK3pS+ohxwK594DnbSwERFppHtryZ/LWETg+31hJWd9gqtF57VcEpxg5Dh3jlgp3WZS2 33uw== X-Gm-Message-State: AKwxytfXhf08PLM3vH5aEAzNB0Jurm/EbCYPPFa9rIeIvN875xjSLx5J qwW9Tos+z1f+ZZR7/V6zRXh4FBaEeXrQ4TAgF+0= X-Google-Smtp-Source: AH8x225Aca/NClqDoHHd2X59q7LZVQTzptyXIh6STjaoS5ckj58gbkTzgvBnjVVYMVenWR4GZ2KZLc6IIs+sJnWF2bM= X-Received: by 10.55.186.134 with SMTP id k128mr6770649qkf.23.1516756665247; Tue, 23 Jan 2018 17:17:45 -0800 (PST) MIME-Version: 1.0 Sender: chemag@gmail.com Received: by 10.200.50.205 with HTTP; Tue, 23 Jan 2018 17:17:44 -0800 (PST) In-Reply-To: References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E199A2D@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E19B325@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1A08C0@SHSMSX104.ccr.corp.intel.com> From: Chema Gonzalez Date: Tue, 23 Jan 2018 17:17:44 -0800 X-Google-Sender-Auth: R00E2Pomfn3SFK4juNrcVLhHkvc Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" Subject: Re: FW: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH in C Makefile (#122) X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 01:12:19 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Liming, Any news on this patch? Thanks. -Chema On Mon, Jan 8, 2018 at 6:34 PM, Chema Gonzalez wrote: > Done. > > -Chema > > > On Mon, Jan 8, 2018 at 5:42 PM, Gao, Liming wrote: >> Chema: >> Sorry for late response. I think the change is good. For windows and g= cc, how about use the same error message for the unknown or unsupported arc= h? >> >> +else >> +$(error Bad HOST_ARCH) >> endif >> >> +!ELSE >> +!ERROR "Unknown HOST_ARCH variable" >> !ENDIF >> >> Thanks >> Liming >>>-----Original Message----- >>>From: chemag@gmail.com [mailto:chemag@gmail.com] On Behalf Of Chema >>>Gonzalez >>>Sent: Friday, January 05, 2018 3:48 AM >>>To: Gao, Liming >>>Cc: edk2-devel@lists.01.org >>>Subject: Re: FW: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH i= n >>>C Makefile (#122) >>> >>>Added similar changes to `BaseTools/Source/C/Makefiles/header.makefile`. >>> >>>Thanks, >>>-Chema >>> >>> >>>On Fri, Dec 29, 2017 at 7:17 AM, Gao, Liming wrot= e: >>>> I suggest GNUmakefile also adds this condition to report error message= if >>>HOST_ARCH is not set correctly. >>>> >>>>> -----Original Message----- >>>>> From: chemag@gmail.com [mailto:chemag@gmail.com] On Behalf Of >>>Chema Gonzalez >>>>> Sent: Friday, December 29, 2017 6:19 AM >>>>> To: edk2-devel@lists.01.org >>>>> Cc: Gao, Liming >>>>> Subject: Fwd: FW: [tianocore/edk2] BaseTools: Barf on unknown >>>HOST_ARCH in C Makefile (#122) >>>>> >>>>> Sure. >>>>> >>>>> Thanks, >>>>> -Chema >>>>> >>>>> ---------- Forwarded message ---------- >>>>> From: Gao, Liming >>>>> Date: Wed, Dec 27, 2017 at 5:48 PM >>>>> Subject: FW: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH in >>>>> C Makefile (#122) >>>>> To: "chemag@gmail.com" >>>>> >>>>> >>>>> Could you send patch to edk2-devel@lists.01.org? >>>>> >>>>> >>>>> >>>>> From: chemag [mailto:notifications@github.com] >>>>> Sent: Thursday, December 28, 2017 9:26 AM >>>>> To: tianocore/edk2 >>>>> Cc: Subscribed >>>>> Subject: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH in C >>>>> Makefile (#122) >>>>> >>>>> >>>>> >>>>> I was getting HOST_ARCH set using the linux arch name ("x86_64"), whi= ch >>>>> is different from the MS one ("X64"). >>>>> >>>>> It is not clear anyway we can proceed without valid build variables >>>>> (ARCH_INCLUDE, BIN_PATH, LIB_PATH, SYS_BIN_PATH, and >>>>> SYS_LIB_PATH). >>>>> >>>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>>> Signed-off-by: Chema Gonzalez chemag@gmail.com >>>>> >>>>> ________________________________ >>>>> >>>>> You can view, comment on, or merge this pull request online at: >>>>> >>>>> https://github.com/tianocore/edk2/pull/122 >>>>> >>>>> Commit Summary >>>>> >>>>> BaseTools: Barf on unknown HOST_ARCH in C Makefile >>>>> >>>>> File Changes >>>>> >>>>> M BaseTools/Source/C/Makefiles/ms.common (6) >>>>> >>>>> Patch Links: >>>>> >>>>> https://github.com/tianocore/edk2/pull/122.patch >>>>> https://github.com/tianocore/edk2/pull/122.diff >>>>> >>>>> =E2=80=94 >>>>> You are receiving this because you are subscribed to this thread. >>>>> Reply to this email directly, view it on GitHub, or mute the thread.