From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400d:c09::229; helo=mail-qk0-x229.google.com; envelope-from=chemag@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-qk0-x229.google.com (mail-qk0-x229.google.com [IPv6:2607:f8b0:400d:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 879352236BA83 for ; Thu, 4 Jan 2018 11:42:50 -0800 (PST) Received: by mail-qk0-x229.google.com with SMTP id d202so3323594qkc.9 for ; Thu, 04 Jan 2018 11:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=9PxjSG9bJ2eU7xaFSw9aWStPpb4YZPdg2wMYA9ibW8o=; b=kEM/Xcr55OMDwv1rQKGSAGvqqwJWJ/at1pAdm2Tsi/epe1nWfjMCiLC9lq2rvjH/33 QdE0UwrEzZac3gDwVczaNRHR3nqX3ZeTNzaJxwgTxv3Mfp+DHuehMlkLsdVMdgGgNgkq clNjt2oFHhyuLg7UwlzmWv6XTHEV684o2gmC414xXA6y0M6D9KPW644w0ewurSaMNuoy 1I/lE4wi7Le7f2xyW3KVH46QWEXp+zsWD44oXbAHH3ZFFRL4HsiCwI+A3K4qFkozI6nj rPPoIgYQmdEMCvV1VqYnO4E063805l8xFhEpa0VZbrIfudvpSaFtUOIodtFacoFwry46 wlig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=9PxjSG9bJ2eU7xaFSw9aWStPpb4YZPdg2wMYA9ibW8o=; b=HPiXyqFb6lGJRXJYde04nGoww6fzyhtrrBOKQdywfXFE3CdF44PXO+bKXtFkmtg3Ss RvqVcBicrAi/0Jq3ksV5rJhshC3eWJrQZFUH95RlpfvTFuR5+OOWT2FZxPXRVQYLdgrU 8FFplrpGkY32EIQ5DfSuUVG2r835RC6bnPhzyDJJ4j/H3LfoH0kYgFJs+w2Y4O/1qYa3 XHmPBPCobMO7BdxkHFEdJSyQOOQnKoSDJURvtGGTzVHfxerZPqInlc8Oatapra6wpPkq Vk3LHcIdmKs3gxvOW+xFGK6H2Z4gykvoa9QhbqEK+NC20CqM4D29QTDuK+nXOOHCvI/a ITEg== X-Gm-Message-State: AKwxytfDivIE59QTY1uptrANIuL/es1CYAJrg25rIeabYdWJ5BR+5Jme Ukl6J2xsVSKWgDPmCv5nyg7WBnKQL+AnaojDp+WvjaDI X-Google-Smtp-Source: ACJfBovAH676IB7HtL6u598Z+NwiIh779CoMAVh2AVmu3hBYbN5zRex1x+OVfBucYvl4BqmIfnvYFLMB9bo2Ec3+Bbk= X-Received: by 10.55.148.6 with SMTP id w6mr932283qkd.196.1515095275063; Thu, 04 Jan 2018 11:47:55 -0800 (PST) MIME-Version: 1.0 Sender: chemag@gmail.com Received: by 10.200.49.69 with HTTP; Thu, 4 Jan 2018 11:47:54 -0800 (PST) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E19B325@SHSMSX104.ccr.corp.intel.com> References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E199A2D@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E19B325@SHSMSX104.ccr.corp.intel.com> From: Chema Gonzalez Date: Thu, 4 Jan 2018 11:47:54 -0800 X-Google-Sender-Auth: R0IpBLBlI0s3ZrwBZVUUs614Of4 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" Subject: Re: FW: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH in C Makefile (#122) X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jan 2018 19:42:51 -0000 X-Groupsio-MsgNum: 19814 Content-Type: multipart/mixed; boundary="94eb2c085154ac14080561f89b7e" --94eb2c085154ac14080561f89b7e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Added similar changes to `BaseTools/Source/C/Makefiles/header.makefile`. Thanks, -Chema On Fri, Dec 29, 2017 at 7:17 AM, Gao, Liming wrote: > I suggest GNUmakefile also adds this condition to report error message if= HOST_ARCH is not set correctly. > >> -----Original Message----- >> From: chemag@gmail.com [mailto:chemag@gmail.com] On Behalf Of Chema Gonz= alez >> Sent: Friday, December 29, 2017 6:19 AM >> To: edk2-devel@lists.01.org >> Cc: Gao, Liming >> Subject: Fwd: FW: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH = in C Makefile (#122) >> >> Sure. >> >> Thanks, >> -Chema >> >> ---------- Forwarded message ---------- >> From: Gao, Liming >> Date: Wed, Dec 27, 2017 at 5:48 PM >> Subject: FW: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH in >> C Makefile (#122) >> To: "chemag@gmail.com" >> >> >> Could you send patch to edk2-devel@lists.01.org? >> >> >> >> From: chemag [mailto:notifications@github.com] >> Sent: Thursday, December 28, 2017 9:26 AM >> To: tianocore/edk2 >> Cc: Subscribed >> Subject: [tianocore/edk2] BaseTools: Barf on unknown HOST_ARCH in C >> Makefile (#122) >> >> >> >> I was getting HOST_ARCH set using the linux arch name ("x86_64"), which >> is different from the MS one ("X64"). >> >> It is not clear anyway we can proceed without valid build variables >> (ARCH_INCLUDE, BIN_PATH, LIB_PATH, SYS_BIN_PATH, and >> SYS_LIB_PATH). >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Chema Gonzalez chemag@gmail.com >> >> ________________________________ >> >> You can view, comment on, or merge this pull request online at: >> >> https://github.com/tianocore/edk2/pull/122 >> >> Commit Summary >> >> BaseTools: Barf on unknown HOST_ARCH in C Makefile >> >> File Changes >> >> M BaseTools/Source/C/Makefiles/ms.common (6) >> >> Patch Links: >> >> https://github.com/tianocore/edk2/pull/122.patch >> https://github.com/tianocore/edk2/pull/122.diff >> >> =E2=80=94 >> You are receiving this because you are subscribed to this thread. >> Reply to this email directly, view it on GitHub, or mute the thread. --94eb2c085154ac14080561f89b7e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-BaseTools-Barf-on-unknown-HOST_ARCH-in-C-Makefile.patch" Content-Disposition: attachment; filename="0001-BaseTools-Barf-on-unknown-HOST_ARCH-in-C-Makefile.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jc0wlszl0 RnJvbSBmMWI3YjdjY2I3OGU4NTM0MzNkNDE2NTJmMGJlNDlhYTE0MDMwZjAwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGVtYSBHb256YWxleiA8Y2hlbWFnQGZiLmNvbT4KRGF0ZTog V2VkLCAyNyBEZWMgMjAxNyAxNjoyMzo1NiAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEJhc2VUb29s czogQmFyZiBvbiB1bmtub3duIEhPU1RfQVJDSCBpbiBDIE1ha2VmaWxlCgpJIHdhcyBnZXR0aW5n IGBIT1NUX0FSQ0hgIHNldCB1c2luZyB0aGUgbGludXggYXJjaCBuYW1lICgieDg2XzY0IiksIHdo aWNoCmlzIGRpZmZlcmVudCBmcm9tIHRoZSBNUyBvbmUgKCJYNjQiKS4KCkl0IGlzIG5vdCBjbGVh ciBhbnl3YXkgd2UgY2FuIHByb2NlZWQgd2l0aG91dCB2YWxpZCBidWlsZCB2YXJpYWJsZXMKKGBB UkNIX0lOQ0xVREVgLCBgQklOX1BBVEhgLCBgTElCX1BBVEhgLCBgU1lTX0JJTl9QQVRIYCwgYW5k CmBTWVNfTElCX1BBVEhgKS4KCkNvbnRyaWJ1dGVkLXVuZGVyOiBUaWFub0NvcmUgQ29udHJpYnV0 aW9uIEFncmVlbWVudCAxLjEKU2lnbmVkLW9mZi1ieTogQ2hlbWEgR29uemFsZXogPGNoZW1hZ0Bn bWFpbC5jb20+Ci0tLQogQmFzZVRvb2xzL1NvdXJjZS9DL01ha2VmaWxlcy9oZWFkZXIubWFrZWZp bGUgfCAxMiArKysrKystLS0tLS0KIEJhc2VUb29scy9Tb3VyY2UvQy9NYWtlZmlsZXMvbXMuY29t bW9uICAgICAgIHwgIDYgKysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyks IDggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvQmFzZVRvb2xzL1NvdXJjZS9DL01ha2VmaWxl cy9oZWFkZXIubWFrZWZpbGUgYi9CYXNlVG9vbHMvU291cmNlL0MvTWFrZWZpbGVzL2hlYWRlci5t YWtlZmlsZQppbmRleCAyN2FhMjhiLi5lMDM0ZGEyIDEwMDY0NAotLS0gYS9CYXNlVG9vbHMvU291 cmNlL0MvTWFrZWZpbGVzL2hlYWRlci5tYWtlZmlsZQorKysgYi9CYXNlVG9vbHMvU291cmNlL0Mv TWFrZWZpbGVzL2hlYWRlci5tYWtlZmlsZQpAQCAtMjksMTggKzI5LDE4IEBAIEJVSUxEX0xEID89 IGxkCiBMSU5LRVIgPz0gJChCVUlMRF9DQykNCiBpZmVxICgkKEhPU1RfQVJDSCksIElBMzIpDQog QVJDSF9JTkNMVURFID0gLUkgJChNQUtFUk9PVCkvSW5jbHVkZS9JYTMyLw0KLWVuZGlmDQogDQot aWZlcSAoJChIT1NUX0FSQ0gpLCBYNjQpDQorZWxzZSBpZmVxICgkKEhPU1RfQVJDSCksIFg2NCkN CiBBUkNIX0lOQ0xVREUgPSAtSSAkKE1BS0VST09UKS9JbmNsdWRlL1g2NC8NCi1lbmRpZg0KIA0K LWlmZXEgKCQoSE9TVF9BUkNIKSwgQVJNKQ0KK2Vsc2UgaWZlcSAoJChIT1NUX0FSQ0gpLCBBUk0p DQogQVJDSF9JTkNMVURFID0gLUkgJChNQUtFUk9PVCkvSW5jbHVkZS9Bcm0vDQotZW5kaWYNCiAN Ci1pZmVxICgkKEhPU1RfQVJDSCksIEFBUkNINjQpDQorZWxzZSBpZmVxICgkKEhPU1RfQVJDSCks IEFBUkNINjQpDQogQVJDSF9JTkNMVURFID0gLUkgJChNQUtFUk9PVCkvSW5jbHVkZS9BQXJjaDY0 Lw0KKw0KK2Vsc2UNCiskKGVycm9yIEJhZCBIT1NUX0FSQ0gpDQogZW5kaWYNCiANCiBJTkNMVURF ID0gJChUT09MX0lOQ0xVREUpIC1JICQoTUFLRVJPT1QpIC1JICQoTUFLRVJPT1QpL0luY2x1ZGUv Q29tbW9uIC1JICQoTUFLRVJPT1QpL0luY2x1ZGUvIC1JICQoTUFLRVJPT1QpL0luY2x1ZGUvSW5k dXN0cnlTdGFuZGFyZCAtSSAkKE1BS0VST09UKS9Db21tb24vIC1JIC4uIC1JIC4gJChBUkNIX0lO Q0xVREUpIA0KZGlmZiAtLWdpdCBhL0Jhc2VUb29scy9Tb3VyY2UvQy9NYWtlZmlsZXMvbXMuY29t bW9uIGIvQmFzZVRvb2xzL1NvdXJjZS9DL01ha2VmaWxlcy9tcy5jb21tb24KaW5kZXggYTZiZmVh NS4uMDYzOTlkZiAxMDA2NDQKLS0tIGEvQmFzZVRvb2xzL1NvdXJjZS9DL01ha2VmaWxlcy9tcy5j b21tb24KKysrIGIvQmFzZVRvb2xzL1NvdXJjZS9DL01ha2VmaWxlcy9tcy5jb21tb24KQEAgLTQy LDE0ICs0MiwxNiBAQCBCSU5fUEFUSCAgICAgPSAkKEJBU0VfVE9PTFNfUEFUSClcQmluXFdpbjMy CiBMSUJfUEFUSCAgICAgPSAkKEJBU0VfVE9PTFNfUEFUSClcTGliXFdpbjMyDQogU1lTX0JJTl9Q QVRIID0gJChFREtfVE9PTFNfUEFUSClcQmluXFdpbjMyDQogU1lTX0xJQl9QQVRIID0gJChFREtf VE9PTFNfUEFUSClcTGliXFdpbjMyDQotIUVORElGDQogDQotIUlGICIkKEhPU1RfQVJDSCkiPT0i WDY0Ig0KKyFFTFNFSUYgIiQoSE9TVF9BUkNIKSI9PSJYNjQiDQogQVJDSF9JTkNMVURFID0gJChT T1VSQ0VfUEFUSClcSW5jbHVkZVxYNjQNCiBCSU5fUEFUSCAgICAgPSAkKEJBU0VfVE9PTFNfUEFU SClcQmluXFdpbjY0DQogTElCX1BBVEggICAgID0gJChCQVNFX1RPT0xTX1BBVEgpXExpYlxXaW42 NA0KIFNZU19CSU5fUEFUSCA9ICQoRURLX1RPT0xTX1BBVEgpXEJpblxXaW42NA0KIFNZU19MSUJf UEFUSCA9ICQoRURLX1RPT0xTX1BBVEgpXExpYlxXaW42NA0KKw0KKyFFTFNFDQorIUVSUk9SICJV bmtub3duIEhPU1RfQVJDSCB2YXJpYWJsZSINCiAhRU5ESUYNCiANCiBDQyA9IGNsLmV4ZQ0KLS0g CjIuNy40Cgo= --94eb2c085154ac14080561f89b7e--