From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A26A2941106 for ; Thu, 7 Dec 2023 04:48:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=bWpWBjFPI7+xBRAXimaaC+hdm2q9UKD9PuMSXmZu1s8=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701924502; v=1; b=AgsP1z39Jf6ODNx2HIVrHy/dK0zyXN4RbPVHxlFf3MUFUzBcqWpczfTMMKlQrU+2AdYzZsNk 9kbTx8VGl7eyp5XpEPlPguxgLkXUTaKhyqYALA9d7mUFuo6AHKaKhg8kvcjoAVSBRBp+izWbW8n AzxZ1rkzzf6XhhNd1Miusiz4= X-Received: by 127.0.0.2 with SMTP id 6gODYY7687511x9VwGl8UYQB; Wed, 06 Dec 2023 20:48:22 -0800 X-Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by mx.groups.io with SMTP id smtpd.web11.76408.1701924501340717766 for ; Wed, 06 Dec 2023 20:48:21 -0800 X-Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a1e7971db2aso46023266b.3 for ; Wed, 06 Dec 2023 20:48:21 -0800 (PST) X-Gm-Message-State: Q1xu7rMXCe2xg7DA4jitaq4fx7686176AA= X-Google-Smtp-Source: AGHT+IFqkdpDVw4sHORLIvZDwjJbpyOU75we8DT9T/lEgwD/vJY37SrBqd3i2WE/gUivan30F4OtK4jgxIV5Nm08O+Q= X-Received: by 2002:a17:906:51cd:b0:a1e:5ea5:c5d2 with SMTP id v13-20020a17090651cd00b00a1e5ea5c5d2mr535466ejk.106.1701924499592; Wed, 06 Dec 2023 20:48:19 -0800 (PST) MIME-Version: 1.0 References: <20231031173700.647004-1-ngompa@fedoraproject.org> <58ec87dc-ce03-6ad8-681a-d815bc5c39f9@arm.com> In-Reply-To: From: "Neal Gompa" Date: Wed, 6 Dec 2023 23:47:43 -0500 Message-ID: Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery To: Laszlo Ersek Cc: Jeremy Linton , devel@edk2.groups.io, Pete Batard , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Gerd Hoffmann , Samer El-Haj-Mahmoud Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ngompa13@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=AgsP1z39; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Nov 24, 2023 at 6:36=E2=80=AFPM Neal Gompa wro= te: > > On Thu, Nov 2, 2023 at 6:35=E2=80=AFAM Laszlo Ersek w= rote: > > > > On 10/31/23 23:27, Jeremy Linton wrote: > > > On 10/31/23 12:37, Neal Gompa via groups.io wrote: > > >> From: Neal Gompa > > >> > > >> Currently, the ReadyToBoot event is only signaled when a formal Boot > > >> Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()). > > >> > > >> However, the introduction of Platform Recovery in UEFI 2.5 makes it > > >> necessary to signal ReadyToBoot when a Platform Recovery boot loader > > >> runs because otherwise it may lead to the execution of a boot loader > > >> that has similar requirements to a regular one that is not launched > > >> as a Boot Manager option. > > >> > > >> This is especially critical to ensuring that the graphical console > > >> is actually usable during platform recovery, as some platforms do > > >> rely on the ConsolePrefDxe driver, which only performs console > > >> initialization after ReadyToBoot is triggered. > > >> > > >> This patch fixes that behavior by calling EfiSignalEventReadyToBoot = () > > >> in EfiBootManagerProcessLoadOption () when invoking platform recover= y, > > >> which is the function that sets up the platform recovery boot proces= s. > > >> > > >> The expected behavior has been clarified in the UEFI 2.10 specificat= ion > > >> to explicitly indicate this behavior is required for correct operati= on. > > >> > > >> This is a rebased version of the patch originally written by Pete Ba= tard. > > > > > > Took me a bit to swap in that whole conversation again, and recheck t= he > > > spec's and code paths, but this all looks fine to me and should allow > > > the PFTF build to drop the similar patch from Pete that has been carr= ied > > > downstream for the past couple years. > > > > > > As for testing the previous patch has been in the field for a couple > > > years now and i'm not aware of it causing any issues. The additional > > > restriction of limiting it to platform recovery logically makes sense= , > > > and as far as I can see shouldn't cause any problems. > > > > > > So, > > > > > > Reviewed-by: Jeremy Linton > > > > > > > > > As a PS: I also went to check the ready to boot behavior for OsRecove= ry > > > and realized that apparently none of that support was ever merged? > > > > What else is there, outside of this patch, in need of upstreaming? > > > > > That seems a bit of an oversight since its been in the spec for a few= years now. > > > > "ready-to-boot for OsRecovery" is new in UEFI 2.10 (according to the > > commit message), which is quite recent ("Aug 29, 2022"). > > > > I couldn't find the Mantis ticket in the Revision History (for 2.10) th= ough. > > > > Is there anything else holding up committing this patch? Jeremy and > you reviewed it earlier in the month... > Friendly ping again? It's been a month now... --=20 =E7=9C=9F=E5=AE=9F=E3=81=AF=E3=81=84=E3=81=A4=E3=82=82=E4=B8=80=E3=81=A4=EF= =BC=81/ Always, there's only one truth! -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112157): https://edk2.groups.io/g/devel/message/112157 Mute This Topic: https://groups.io/mt/102302654/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-