From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3A1D178003C for ; Mon, 3 Jun 2024 16:14:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=F0QX52hRHqYXPK9o12KT45dpDE5lnz8IwI3m9qAi05w=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1717431248; v=1; b=YzC4jYbVO56rPRH5aAOteou8vNJhY2xBRHf1uBpAzZmkpv/StW/YHHeX9r4CACkqGG4MTzD+ rft6oTbJBpc/AhdOCI86GwxsBL6an4Azdoc+JuOcXfc96jjhrVQY6r1iiZwCkWDUXx0yLWVxKfb Vxxx2RglQq8Foloh7K17KNmmBXqHO/XA3h7ZMpP6DHozDetPUpVQ2WV7rQZcm3gBkUEoq7OUs7c zbpzGYhdbGT4Xv4AH3zXuLeZ8kPrHSSA32HVkqMxdsmyKGIyPFisv7IG4X7CYJXlC+urEdc5FSX fiiO30aG6swkWrposdEY4qeV6l+xnLmKDZtofS2I0wGQw== X-Received: by 127.0.0.2 with SMTP id r0HjYY7687511xzUCovRNIJN; Mon, 03 Jun 2024 09:14:07 -0700 X-Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by mx.groups.io with SMTP id smtpd.web10.87934.1717431246683801342 for ; Mon, 03 Jun 2024 09:14:06 -0700 X-Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a62ef52e837so12757466b.3 for ; Mon, 03 Jun 2024 09:14:06 -0700 (PDT) X-Gm-Message-State: PY6Iv2mob81xEoopEENe7vN1x7686176AA= X-Google-Smtp-Source: AGHT+IHjMl3CuJRMFcKllSFLgexUTL4p+xCLpSotervVqyR+85uSFNK397zQ3umHQXuL7Ken52l1q7kErDFRD/STZgk= X-Received: by 2002:a17:906:57da:b0:a68:f1ca:a8df with SMTP id a640c23a62f3a-a68f1caa98bmr298421266b.71.1717431244494; Mon, 03 Jun 2024 09:14:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Neal Gompa" Date: Mon, 3 Jun 2024 12:13:27 -0400 Message-ID: Subject: Re: [edk2-devel] GitHub PR Code Review process now active To: devel@edk2.groups.io, michael.d.kinney@intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 03 Jun 2024 09:14:07 -0700 Resent-From: ngompa13@gmail.com Reply-To: devel@edk2.groups.io,ngompa13@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=YzC4jYbV; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, May 28, 2024 at 2:53=E2=80=AFPM Michael D Kinney via groups.io wrote: > > Hello, > > The GitHub PR code review process is now active. Please > use the new PR based code review process for all new > submissions starting today. > > * The Wiki has been updated with the process changes. > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Developmen= t-Process > > Big thanks to Michael Kubacki for writing up all the > changes based on the RFC proposal and community discussions. > > We will learn by using, so if you see anything missing or > incorrect or clarifications needed, please send feedback > here so the Wiki pages can be updated quickly for everyone. > > * The edk2 repo settings have been updated to require > a GitHub PR code review approval before merging and > all conversations must be resolved before merging. > > * A PR has been opened that removes the requirement for > Cc: tags in the commit messages and is the first PR > that will use the new process. This PR needs to be > reviewed and merged to support the revised commit > message format. > > https://github.com/tianocore/edk2/pull/5688 > > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Fo= rmat > > * Please use "Draft" PRs to run CI without any reviews. > Once ready for reviews, convert from "Draft" to > "Ready for Review". > Generally GitHub doesn't allow CI to run on PRs created as draft pull requests. Was this changed for edk2? --=20 =E7=9C=9F=E5=AE=9F=E3=81=AF=E3=81=84=E3=81=A4=E3=82=82=E4=B8=80=E3=81=A4=EF= =BC=81/ Always, there's only one truth! -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119429): https://edk2.groups.io/g/devel/message/119429 Mute This Topic: https://groups.io/mt/106355103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-