From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9178C740034 for ; Fri, 24 Nov 2023 23:37:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZCFLmWboWt6rgKueFCwZl1jqLP6OKacja4hDRxF76Tc=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700869022; v=1; b=l/9wFIJnTFdj/pkelk6LdaQIbZGK3DnYnQQ0D4yrmFIIhXtrleUmwpt79gFLT01ANgCc3KOQ F0/tJidwUvjFwenMAY+aHGiK0dcZAHThp4jMEEPY/PW1/OignvXjQ/KOMmXKqPVES8AaRtGuO1A HQ4GI/EO2gljX9GL/t3JP7fA= X-Received: by 127.0.0.2 with SMTP id K9U7YY7687511xvEFPVubSTg; Fri, 24 Nov 2023 15:37:02 -0800 X-Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by mx.groups.io with SMTP id smtpd.web11.9553.1700869021174279320 for ; Fri, 24 Nov 2023 15:37:01 -0800 X-Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-54b0c7987easo775506a12.3 for ; Fri, 24 Nov 2023 15:37:00 -0800 (PST) X-Gm-Message-State: nEhkiM92ApoeprwITqz5p8Xox7686176AA= X-Google-Smtp-Source: AGHT+IEte1kfSxld9pYa/nyS0DSFdgffCnurpNREOQayDwJBy4a1oZTURl39sag0NgJIDsigjWLDG5l8LUZbgossjO8= X-Received: by 2002:a17:906:5da:b0:a03:a857:c6e0 with SMTP id t26-20020a17090605da00b00a03a857c6e0mr2729142ejt.77.1700869019131; Fri, 24 Nov 2023 15:36:59 -0800 (PST) MIME-Version: 1.0 References: <20231031173700.647004-1-ngompa@fedoraproject.org> <58ec87dc-ce03-6ad8-681a-d815bc5c39f9@arm.com> In-Reply-To: From: "Neal Gompa" Date: Fri, 24 Nov 2023 18:36:22 -0500 Message-ID: Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery To: Laszlo Ersek Cc: Jeremy Linton , devel@edk2.groups.io, Pete Batard , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Gerd Hoffmann , Samer El-Haj-Mahmoud Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ngompa13@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="l/9wFIJn"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, Nov 2, 2023 at 6:35=E2=80=AFAM Laszlo Ersek wro= te: > > On 10/31/23 23:27, Jeremy Linton wrote: > > On 10/31/23 12:37, Neal Gompa via groups.io wrote: > >> From: Neal Gompa > >> > >> Currently, the ReadyToBoot event is only signaled when a formal Boot > >> Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()). > >> > >> However, the introduction of Platform Recovery in UEFI 2.5 makes it > >> necessary to signal ReadyToBoot when a Platform Recovery boot loader > >> runs because otherwise it may lead to the execution of a boot loader > >> that has similar requirements to a regular one that is not launched > >> as a Boot Manager option. > >> > >> This is especially critical to ensuring that the graphical console > >> is actually usable during platform recovery, as some platforms do > >> rely on the ConsolePrefDxe driver, which only performs console > >> initialization after ReadyToBoot is triggered. > >> > >> This patch fixes that behavior by calling EfiSignalEventReadyToBoot () > >> in EfiBootManagerProcessLoadOption () when invoking platform recovery, > >> which is the function that sets up the platform recovery boot process. > >> > >> The expected behavior has been clarified in the UEFI 2.10 specificatio= n > >> to explicitly indicate this behavior is required for correct operation= . > >> > >> This is a rebased version of the patch originally written by Pete Bata= rd. > > > > Took me a bit to swap in that whole conversation again, and recheck the > > spec's and code paths, but this all looks fine to me and should allow > > the PFTF build to drop the similar patch from Pete that has been carrie= d > > downstream for the past couple years. > > > > As for testing the previous patch has been in the field for a couple > > years now and i'm not aware of it causing any issues. The additional > > restriction of limiting it to platform recovery logically makes sense, > > and as far as I can see shouldn't cause any problems. > > > > So, > > > > Reviewed-by: Jeremy Linton > > > > > > As a PS: I also went to check the ready to boot behavior for OsRecovery > > and realized that apparently none of that support was ever merged? > > What else is there, outside of this patch, in need of upstreaming? > > > That seems a bit of an oversight since its been in the spec for a few y= ears now. > > "ready-to-boot for OsRecovery" is new in UEFI 2.10 (according to the > commit message), which is quite recent ("Aug 29, 2022"). > > I couldn't find the Mantis ticket in the Revision History (for 2.10) thou= gh. > Is there anything else holding up committing this patch? Jeremy and you reviewed it earlier in the month... -- =E7=9C=9F=E5=AE=9F=E3=81=AF=E3=81=84=E3=81=A4=E3=82=82=E4=B8=80=E3=81=A4=EF= =BC=81/ Always, there's only one truth! -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111703): https://edk2.groups.io/g/devel/message/111703 Mute This Topic: https://groups.io/mt/102302654/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-